Thursday, October 24, 2024
18 changes
1 change
Resolved issues and error corrections
This fixes a display issue where message author avatars could disappear in public channels after the sender left, especially for guests viewing the conversation. It helps keep chat history clear and recognizable for users without changing the conversation content.
Original PR description
Steps to reproduce: - Create a public channel - Add a non website_published user as a new member - Log in as that new member and send a message then leave the channel - Open the channel as a quest - The author avatar of the message is not there
13 changes
Resolved issues and error corrections
The table picker in the HTML editor now closes when users press most keys, instead of staying open while they type. This makes table insertion feel more predictable and avoids the picker lingering over the editing area.
Original PR description
**Current behavior before PR:** - After opening the table picker, it does not close when typing, unless Escape key was pressed **Desired behavior after PR is merged:** - Now, the table picker will close when any key is pressed except for arrow keys.
4 changes
Resolved issues and error corrections
This update resolves a bug that prevented the 'Data Merge: Find Duplicate Records' process from correctly identifying duplicate records when a model's company field wasn't directly stored. The fix ensures the system can now accurately match duplicates even when relying on related fields, improving data accuracy.
Original PR description
Steps ----- 1. Create a deduplication rule for a model with a non-stored company field (e.g. Document). Add a field to the deduplication rules. 2. Run the "Data Merge: Find Duplicate Records" scheduled action. ** ValueError: <class 'psycopg2.errors.UndefinedColumn'>: "column documents_document.company_id does not exist ** Change ----- Handle the case where the company field of the model is not stored but still accessible through its related field in another table. opw-4114062 Forward-Port-Of: odoo/enterprise#68816
This fix ensures mobile users can create stock move records when required details are filled automatically in the background. It prevents situations where warehouse staff could be blocked from recording stock movements on mobile devices.
Original PR description
Since the `name` field is set via onchange, we need it here. Currently on mobile, a user may be prevented altogether from creating a stock move record in some situations. opw-4278098
Restores a previously removed action so customers with older analytic views can still use the view button without hitting an error. This prevents a user-facing crash and keeps existing custom or not-yet-updated screens working as expected.
Original PR description
The `action_read_distribution_model` method was removed from the following commit. https://github.com/odoo/odoo/pull/182278/commits/777dea298fd74f2349ca22d05fe7f48596216dfe Since the client's non-updated views still call it, but get a traceback as it doesn't exist anymore. Error:- ``` AttributeError: The method 'action_read_distribution_model' does not exist on the model 'account.analytic.distribution.model' ``` We add it again to fix the issue. sentry-5804153543
Sharing a project without adding collaborators no longer sends an unnecessary notification. This prevents confusing messages and makes the sharing flow clearer for users.
Original PR description
Previously, when a project was shared without adding collaborators, an incorrect notification was sent, potentially confusing for the user. this commit ensures no notification is triggered if the collaborator's O2M field is empty,thereby avoiding misleading messages. task-3956252
Changing a user's tour setting from the form now correctly stops any running guided tour when tours are disabled. This prevents unwanted onboarding or help tours from continuing after a user or administrator turns them off.
Original PR description
Before this commit, changing tour_enabled on the form view of the user was not deactivating the running tour. After this commit, the running tour is deactivated if the tour_enabled is false when loading the tour service. TASK-ID: 4276412 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix keeps the work order button column in manufacturing orders sized correctly when start, pause, or stop buttons appear or disappear. Users should see a cleaner, more reliable layout without needing to resize the page to refresh the view.
Original PR description
The column containing the buttons start/pause/stop does not recompute it's size when one of the button appears/disappears, but it does when the column/the page is resized. In this fix, we revert https://github.com/odoo/odoo/pull/169177 which was not relevant anymore and we ensure to recompute the width every time if we're not using the magic column width.  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Pivot titles used only in dashboard editing screens will no longer be sent for translation. This reduces unnecessary translation work without changing what end users see in standard dashboards.
Original PR description
In standards dashboards, pivot titles are currently extracted from the json files to be translated. But those titles are not visible in dashboard mode (only in edit mode, in the side panels and menus). The cost of translating those titles is not worth it. .pot files will be re-exported later, when TIC is back. She already warned the translators to skip those translation anyway. Task 4239967 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The analytic distribution model list now relies on Odoo's built-in form-opening button instead of a duplicate custom button. This keeps the interface consistent and avoids redundant controls for users when opening records.
Original PR description
In this commit: https://github.com/odoo/odoo/commit/43027a34a6e51901ff869beec2bba74218b29356 They added a new button to open the form view directly. If the view has an attribute open_form_view to True or being in debug mode. Since we manually added a button to do the exact same thing, let's use the button from the list view. task: 4204366 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Creating a new Link Tracker record no longer triggers an error when required URL details are not yet filled in. This prevents an interruption for users setting up tracked links from Link Tracker or related apps like mass mailing.
Original PR description
After the new `_monkeypatches` of `url_join`/`_check_str_tuple` we're getting TypeError traceback on creating a Link Tracker. Steps ===== Install Link Tracker and an associate module(i.e., mass mailing) Turn on developer mode Open Link Tracker app and try to create a new record Traceback: `TypeError: Cannot mix str and bytes arguments (got (False, 'False'))` Technical: ========== When creating a new we don't have `short_url_host` or `code`, thus its giving False. Also, code was in in `""`, means False , "False", its unnecessary. After this commit: =================== There will be no traceback on creating a Link Tracker. Task-4279725
The payroll accounting test suite for Switzerland was adjusted to match a recent internal payslip validation change. This helps keep automated checks reliable and reduces the risk of payroll-related regressions reaching users.
The balance sheet report now handles companies that have no journals configured instead of showing an error. This prevents users from hitting a traceback when opening financial reports in empty or newly configured databases.
Original PR description
When there are no journals and the user tries to open the balance sheet report, a traceback will appear. Steps to reproduce the error: - Install ``account_reports`` module without demo data - Remove…
When there are no journals and the user tries to open the balance sheet report,
a traceback will appear.
Steps to reproduce the error:
- Install ``account_reports`` module without demo data
- Remove all journals
- Go Reporting > Open Balance sheet
Traceback:
```
StopIteration: null
File "odoo/http.py", line 2364, in __call__
response = request._serve_db()
File "odoo/http.py", line 1891, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1954, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 137, in retrying
result = func()
File "odoo/http.py", line 1921, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2168, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 330, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 728, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 517, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "home/odoo/src/enterprise/18.0/account_reports/models/account_report.py", line 1914, in get_options
initializer(options, previous_options=previous_options)
File "home/odoo/src/enterprise/18.0/account_reports/models/account_report.py", line 379, in _init_options_journals
options['journals'].extend(next(iter(company_journals_map.values())))
```
https://github.com/odoo/enterprise/blob/302eb1052609462fe607f77fcc934690f9abbe5a/account_reports/models/account_report.py#L379
When there are no journals ``company_journals_map`` will be empty,
So, it will lead to the above traceback.
sentry-5993507281Spreadsheet side panels now use a consistent bold style for their titles and labels. This fixes a visual inconsistency, making the interface feel more polished and easier to scan for users.
Original PR description
## Description The font weight of this side panel was previously inconsistent with other side panels. This commit ensures that the font weight is now uniform across all side panels. Task: 4194259
A test was added to ensure spreadsheet pivot autocomplete works correctly when using positional pivot arguments in Odoo. This helps prevent a previously fixed issue from returning and supports more reliable spreadsheet behavior for users.
Original PR description
This commit adds a test for a bug fix merged in o-spreadsheet, but the behavior can actually only be triggered in odoo, with positional pivot arguments. Task: 4235329
This update fixes an inconsistency in how query counts are measured for the test_mail module. Previously, a specific setup caused inaccurate results, particularly in single-module builds. This change adds a reliable query counter, addressing a performance issue that has been resolved through an optimization in the ORM.
Original PR description
The query count in single module build is higher than the one with all modules installed. - test_mail_enterprise…
The query count in single module build is higher than the one with all modules installed. - test_mail_enterprise   - test_mail_enterprise + documents_project   In summary, a one2many fields document_ids on document_projects triggers an [orm optimisation](https://github.com/odoo/odoo/pull/111651/files) leading to 10 less queries. In 16.0 the query count adapted in an all-enterprise build fails in single module In 17.0 a regression of performance was missed because a margin is added on a bunch of query count that didn't break in the all-enterprise build This pr proposes to add a field with the corresponding optimization in the test module in stable, to have reliable query counter. This field will be moved to the document module in master. RunbotError-65777 Forward-Port-Of: odoo/enterprise#72598
This update resolves an issue where clicking 'Insert in spreadsheet' in pivot views incorrectly redirected users to the dashboard without saving. The fix, implemented starting with saas-17.4, completely removes the 'Dashboards' tab from the pivot view, eliminating the error. This ensures users can properly access spreadsheet functionality.
Original PR description
Steps to reproduce: - install Documents and CRM - login as Marc Demo - go to any pivot view - click on "Insert in spreadsheet" - select the Dashboards tab and confirm => boom In this version, the fix is sub-optimal. The user will be redirected to the dashboard, but nothing happens. It's fixed properly starting with saas-17.4 because the code changed and it's mush easier and safer to fix. The Dashboard tab won't appear at all. Task: 4273554
This update resolves a problem preventing the Social Marketing tour from functioning correctly. The fix addresses an issue with accessing a key input field and updates the tour's triggering mechanism for compatibility across Odoo versions. This ensures a smoother onboarding experience for new users.
Original PR description
Fixed onboarding Social Marketing tour which is not working properly. Reason ====== We're not getting this `'textarea[name="message"]` for some reasons, & there is no `name` attribute in textarea. Also, we removed `extra_tringger` in later version, and we can use `run: 'edit` instead so removed that & used common classes that works on all version. Task-4210376 Forward-Port-Of: odoo/enterprise#71016