Monday, October 28, 2024
14 changes · 17.0
Resolved issues and error corrections
This fixes a display issue where editing nested forms in Studio could remove the expected form styling after leaving Studio. Users working with delivery orders and similar records should see the correct layout remain intact, reducing confusion during navigation.
Original PR description
Steps to reproduce ================== - Install stock,mrp,web_studio - Go to Inventory > Delivery Orders - Open WH/OUT/00001 - Open studio - On the x2many field, click on "Edit form" -> Studio switches to that view, - Click on "Edit form" again for the new lines - Exit studio - Click on the hamburger button -> The styling is broken Cause of the issue ================== When clicking on "Edit form", studio inlines the selected form view. The nosheet form style is only applied if the form contains no sheet element. In this case, there is a sheet element, but inside a nested form. Solution ======== Only consider sheets if they are part of the current form view. opw-4130337
Control panel breadcrumb tooltips are now included in Odoo's translation system. This ensures users working in different languages see these interface hints in their selected language, improving usability and consistency.
Original PR description
Control panel breadcrumb tooltips aren't translated. This is because the tooltip is defined with a t-att-*, and dynamic attributes are never translatable. This commit redefines the tooltip in a different way that allows translation. opw-4160838 Enterprise: https://github.com/odoo/enterprise/pull/72501
This fixes an issue where user menu items containing HTML were shown as escaped text in the mobile menu. Mobile users now see the same clean menu labels as desktop users, improving consistency and readability.
Original PR description
HTML user menu items were escaped on the mobile client Fixes #145693 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an internal API key deletion test from failing when customer databases have automated actions that run during user creation. It improves test reliability without changing day-to-day product behavior for users.
Original PR description
Description of the issue/feature this PR addresses: TestAPIKeys.test_delete creates an user, which might trigger an automated action. However that action would fail [here](https://github.com/odoo/odoo/blob/17.0/addons/base_automation/models/base_automation.py#L67), since the mockup request that is set up in the test does not include a function request.get_json_data() nor request.httprequest.args Current behavior before PR: The test fails on databases that have an automated action triggered on user creation Desired behavior after PR is merged: This test should not fail on such databases This issue has been discussed [here](https://discord.com/channels/678381219515465750/687339689522364423/1300410221482479636)
This update fixes a translation issue within the Spreadsheet Edition of Odoo, ensuring breadcrumb tooltips are accurately displayed in multiple languages. This improves the user experience for international users and maintains consistent branding across different locales. The change addresses a minor usability concern.
Original PR description
opw-4160838 Community: https://github.com/odoo/odoo/pull/184555
This update resolves a bug where the mail-chatter dropzone remained open after dragging a document to a folder. The fix removes a technical restriction that was preventing the dropzone from closing, improving the user experience when moving documents.
Original PR description
Steps to reproduce: 1. select a document 2. open chatter 3. drag(preview part) and drop to the others folder 4. the mail-chatter-dropzone remains open Technical Reason: Removing the unnecessary stop propagation on the search panel's document drop event as it was preventing it from being caught by the window keeping the chatter drop zone open. After this commit: The mail-chatter-dropzone will be closed after being moved to drag documents to the folders. Task-4268738
This update fixes an issue where timesheet hour calculations were inaccurate due to using UTC time zones. By adjusting the calculation to reflect the user's local calendar time zone, the system now correctly determines under/overtime hours, ensuring accurate timesheet reporting. This improves the reliability of timesheet data.
Original PR description
Steps ----- - Install timesheet_grid - Set monday as the first day of the week in the language settings - Set the timezone of the user's working schedule to a more advanced timezone, e.g. UTC+10 - Go to Timesheets and add some hours on monday -> The under/over time is calculated relative to a lower number of hours than the real number of working hours for that day. Cause ----- `get_daily_working_hours` uses UTC's start/end of day for the start and end of the period, causing some working hours near the start/end of the period to be missed. opw-4163183
A recent change in Belgium's time zone rules caused a test to fail. This fix ensures the test consistently uses UTC time, eliminating discrepancies caused by timezone offsets. This prevents inaccurate test results and ensures the reliability of our project management features.
Original PR description
Before this commit, the test `test_editing_task_planned_date` was written by using the belgium timezone but this test starts failing after the end of the summer time in belgium timezone since inside that test, the timezone used is the one used of the current calendar set on the company and/or the timezone set on the current user, that is the belgium one. And so, due to the change of the hours in belgium timezone to now use "winter time" the offset between the `datetime.now` with belgium timezone and the one using utc timezone is no longer 2 hours but 1 hour. Because of that the assets are totally wrong because the expected results are fixed and do not take into account the offset could change. This commit makes sure the test uses only utc as timezone to avoid using offset between 2 timezones since the asserts are fixed and not dynamic according to the offset between 2 timezones. runbot-104873
This update corrects a visual issue in the Odoo Studio application where the 'previous' button in the navigation bar was incorrectly positioned. This ensures a consistent and user-friendly experience when creating new applications within Studio. The fix improves the overall usability of the Studio interface.
Original PR description
Before this commit currently when creating a new app using Studio the previous button icon in the navbar appears in the wrong direction After this commit The previous button icon should appear in the right direction Task - 3845561 Forward-Port-Of: odoo/enterprise#61835
This update resolves an issue where a line was incomplete when creating applications using the Odoo Studio. The commit ensures that all necessary fields are correctly populated during app creation, improving the user experience and preventing data inconsistencies. This change was part of a larger effort to enhance the Studio's functionality.
Original PR description
Before this commit: while creating the app for the 'Suggested features for your new model' title the line is not completed. After this commit: the line should be completed. Task:-3845561 Forward-Port-Of: odoo/enterprise#61824
This update fixes a potential issue where communication text after processing could incorrectly include a forward slash. The code has been reorganized to improve reusability and testability, and the function is now used across multiple payment modules. Deprecated functions have been removed to streamline the system.
Original PR description
This commit aims to fix an issue in the sanitize_communication function and move its logic to the account_batch_payment module to improve reusability and testability. The function trims the communication text after removing the '/' characters. However, if the communication text contains '/' and is truncated, the '/' could end up at the end of the string (see tests for more examples). The solution is to remove the '/' after truncating the text. Additionally, the sanitize_communication function has been moved to the account_batch_payment module, since this module is a dependency for both account_sepa and account_sepa_direct_debit, these two modules can now use it as well. The functions sanitize_communication and _sanitize_communication have been marked as deprecated and will be removed in the master branch. opw-4220421 Forward-Port-Of: odoo/enterprise#71552
This update resolves a technical issue that caused tracebacks when creating GST return periods without specifying a month or quarter. The system now gracefully handles missing month/quarter data, preventing errors and ensuring smoother GST return period creation. This improves the reliability of the Odoo Enterprise system for Invoicing reports.
Original PR description
Before this commit: - Creating a GST return period with a quarterly periodicity without selecting a quarter will raise a traceback. - Creating a GST return period with a monthly periodicity without…
Before this commit: - Creating a GST return period with a quarterly periodicity without selecting a quarter will raise a traceback. - Creating a GST return period with a monthly periodicity without selecting a month will raise a traceback. Reason: - While calculating the start_date and end_date of the quarterly return period: `period_start = fields.Date.context_today(self).replace(day=1, month=int(record.month), year=int(record.year))` If there is no month, then int(record.month) will return 0 and The month should be between 1 and 12, so it will raise an error. - While calculating the start_date and end_date of the monthly return period: `period_start = fields.Date.context_today(self).replace(day=1, month=int(record.quarter), year=int(record.year))` If there is no quarter, then int(record.quarter) will return 0 and The month should be between 1 and 12, so it will raise an error. After this commit: - The start_date and end_date will not be calculated if a month or quarter is not defined for the monthly or quarterly return periods. Traceback - https://pastebin.com/LyKUDrH5 Task-4243468 Forward-Port-Of: odoo/enterprise#71883
This update resolves a bug on mobile devices where the document inspector was unexpectedly opening repeatedly when navigating between documents. The fix corrects a logic error in the code that caused the inspector to open unnecessarily, ensuring a smoother document viewing experience.
Original PR description
Steps to reproduce: 1. Go to documents on mobile 2. Click on doc thumbnail 3. The inspector open where preview should open When the preview is open, click on an arrow to see the previous or the next doc 1. The inspector opens again where the previous or next should Technical Reason: In 'documents_inspector.js' file, a condition set only open the inspector if there is only one selected element, so every time it get executed and opens the inspector. After this commit: 1. Click on a doc thumbnail, the preview will open. 2. When the preview is open, click on an arrow to see the previous or the next doc will not open the inspector. Task-3919285 Forward-Port-Of: odoo/enterprise#62957
This update resolves a minor typo in the Japanese accounting module (l10n_jp_zengin). The fix ensures that all messages displayed to users are grammatically correct and professional, improving the overall user experience. This change has no impact on core functionality.
Original PR description
X-original-commit: 698b81c