Odoo Changelog — 2024-10-28

Monday, October 28, 2024

34 changes · saas-17.4

Bug Fixes(11)

Resolved issues and error corrections

[FIX] hr_expense: only purchase journals in employee's expense journal settings

Coresaas-17.4hr_expense

The Employee Expense Journal setting now limits choices to purchase journals only. This prevents users from selecting an unsuitable journal and helps keep expense accounting setup accurate.

Original PR description

## Steps:

1- Expenses
2- Settings
3- Employee Expense Journal: all the journals can be selected. It should be only "Purchase" journals.

This PR adds a filtering domain to the `expense_journal_id` field to filter out non 'purchase' journals.

opw-4251517

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#expenses#settings#journals

[FIX] mrp: click in the subcontracting line without raise an error

PR #185467

Coresaas-17.4mrp

Users can now expand subcontracting lines in the Bill of Materials overview without seeing an error pop-up. This improves reliability for manufacturing teams reviewing subcontracted components and keeps the BoM overview usable.

Original PR description

Whe the user clicks on a subcontracting line in the BOM overview, an error is raised. This occurs because we are passing false when subcontracting lines are not folded, but a function is expected. The solution is to pass a function, which should be a void function when toggleFolded is false.

Steps to reproduce:
1. Go to the Manufacturing app.
2. Enable the Subcontracting feature in the Setting tab.
3. Navigate to the BoM overview in the Products tab.
4. Open a BoM that includes subcontracting.
5. Click to expand the subcontracting line.

Previous behaviour: An error pop-up appears.
Current behaviour: Opens without any error.


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#manufacturing#subcontracting#bill-of-materials

[FIX] web: report scss: hr node hardcoded border

PR #185497

Coresaas-17.4web

This fixes an issue where horizontal divider lines could display incorrectly in generated reports. The change helps keep printed or PDF reports visually consistent after the underlying styling framework update.

Original PR description

Since 058212e12b5079eba870bde9775fe98f27928935 Bootstrap's version is 5.3

Many more style is set by CSS Custome properties which wkhtmltopdf does not support

This fixes the <hr /> case.

opw-4265150

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#reports#pdf#styling

[FIX] web_editor: apply fontsize for table selection

PR #184104

Coresaas-17.4web_editor

This fixes a problem where changing font size did not apply when users selected text across table cells in the web editor. The editor now keeps the table selection intact during the formatting process, so the chosen font size is applied as expected.

Original PR description

Issue:
=====
FontSize isn't being applied on table selection.

Steps to reproduce the issue:
=============================
- Create a new to do
- Add a table
- Add content in some cells
- Select from the middle of the content of the first cell to the middle
  of the content of the last cell
- Apply font size
- Nothing happens

Origin of the issue:
====================
When we have `useResponsiveFontSizes` enabled, we first set the fontSize
with undefined and then we set the fontSizeClassName, but in the first
execCommand we trigger `historyStep` event. The event is handled by the
`html_field` and it will check if the field is dirty. In the process of
checking we call `getValue` of `Wysiwyg`. `getValue` will run
`cleanForSave` on the editor which will deselect tables.

Solution:
=========
We reset the selection after the first execCommand.

opw-4237983

#font size#tables#web editor

[FIX] website_sale: change placeholder for website in pricelist

PR #185045

Coresaas-17.4website_sale

The Website field on pricelists now says “Select a website” instead of implying that leaving it blank applies the pricelist to all websites. This helps users avoid misconfiguring pricelists by making the empty-field behavior clearer.

Original PR description

**Prior to this commit:**
- While configuring a pricelist, if we don't select any website in the Website field, the placeholder let us think that it should be applied on 'All websites'.

**Post this commit:**
- The placeholder is renamed as 'Select a website' as the pricelist doesn't apply to any website when the field is empty.

**Affected version:** saas-17.4~master
**opw**-4256656

#pricelist#website#placeholder#configuration

[FIX] website: allow forms without emails to be submitted when logged in

PR #185032

Coresaas-17.4website

Website forms that do not ask for an email address can now be submitted successfully by logged-in users. This prevents valid forms, such as job application forms customized without an email field, from failing unnecessarily.

Original PR description

Since [1] e-mails from forms are compared to the logged in user's e-mail when a website form is submitted. Because of this forms without e-mail cannot be used anymore when the user is not logged in.

This commit removes this comparison for forms that do not contain an e-mail field.

Steps to reproduce:
- Install website_hr_recruitment
- Drop a form into the home page
- Set the form action to "Apply for a Job"
- Remove the e-mail field
- Save
- Submit the form

=> An error occurred

[1]: https://github.com/odoo/odoo/commit/1aa5cbb06be85e94c01f8f55ef57b9415b9bb50f

task-4282750

#website#forms#submission

[FIX] maintenance: specify click in next week step run

PR #185454

Coresaas-17.4maintenance

A maintenance module test was corrected so its calendar can reliably move to the next week during automated checks. This helps prevent false test failures, especially around Saturdays, supporting more stable releases without changing user-facing features.

Original PR description

In commit 9f4f1d8e92d0dc68b5628194d9da56d346e708f6, "Move to next week" step is not being processed because of missing `run` argument.
It is necessary for the test to work on saturday and was the main reason of the previous commit being deployed.

runbot-error-65494

#maintenance#testing#calendar#stability

[FIX] base: del 0 val parent_res_id when duplicating filter

PR #184414

Coresaas-17.4base

Fixes an issue that caused an error when duplicating saved user-defined filters. This restores the expected copy behavior, helping users and administrators manage filters without interruption.

Original PR description

**Current behavior:**
Duplicating a user-defined filter will fail and trigger an exception.

**Expected behavior:**
Record duplicates.

**Steps to reproduce:**
1. Go to some menu, create a filter

2. In technical settings, go to user-defined-filters menu

3. Select one and duplicate it -> Exception

**Cause of issue:**
The SQL constraint check_res_id_only_when_embedded_action is triggering because `embedded_parent_res_id` is an Integer type field which, when NULL in postgres, will be interpreted by the ORM as 0 when the record we want to duplicate has its values copied.

**Fix:**
In the copy_data override for `ir.filters`, delete the key, value pair for `embedded_parent_res_id` if its value is 0. The only case this problem arises in, is when we copy values from an existing filter record and directly use them for creating a new one- i.e., on duplication/copy.

opw-4234421

#filters#duplication#user-defined filters

[FIX] spreadsheet_edition: correct stacked checkbox label

PR #72015

Enterprisesaas-17.4spreadsheet_edition

The chart configuration panel now refreshes the stacked option label when users switch chart types. This prevents confusing or outdated wording and helps users configure spreadsheet charts more reliably.

Original PR description

This PR addresses an issue where the stacked checkbox label in the chart config panel was not updating when the chart type was changed.

Task: 4251670

#spreadsheet#charts#configuration

[FIX] account_accountant: bank reconciliation empty layout

PR #72418

Enterprisesaas-17.4account_accountant

The bank reconciliation screen now keeps its two-column layout even when there are no transactions to show. This avoids a confusing empty-state layout and helps users keep the same visual structure while waiting for activity.

Original PR description

We want to keep the two columns layout when there is no transaction yet.

Task-id: 4150010

#bank-reconciliation#empty-state#layout

[FIX] pos_restaurant_appointment: add Appointment Resource field to the tree view

PR #72381

Enterprisesaas-17.4pos_restaurant_appointment

Restaurant floor table setup now includes the appointment resource information needed when bookings are enabled. This restores access to an important booking configuration that became unavailable after the table list was made editable directly.

Original PR description

Steps to reproduce:

1. Install Restaurant and Appointments
2. in PoS's Settings, enable booking
3. go to PoS -> Configurations -> Floor plans
4. Select a floor

There is no "Appointment resource" field in the tree view.

Initially in 17.2, the tree items in the floor page (the tables) were not editable in place, so clicking on a table opened the form view where we could change the "Appointment resource". However, in 17.4, the tree was made editable in place, but we've missed adding the "Appointment resource" field.

This PR adds back the field "Appointment resource" (as hidden field) to the floor tables tree view. The changes in this PR were copied from version 18.0, where this bug was already fixed by commit https://github.com/odoo/enterprise/commit/f240b921dd3548b5f91d947354abc85f947f486b

opw-4237285

#appointments#restaurant#pos#booking

Other(23)

Miscellaneous changes

[FW][PERF] sale_stock: improve perf of _get_outgoing_incoming_moves

PR #185590

Coresaas-17.4sale_stock

Issue --> A noticeable amount of time is spent in the method `_get_outgoing_incoming_moves` when doing the `OR` operation on the stock.move recordsets when there is a large number of moves to iterate through. Solution --> Replace the odoo recordset operations with set operations. Benchmarks --> | # of moves | Before | After | |--------|--------|--------| | 32000 | 24.08s | 1.43s | | 7300 | 1.74s | 0.40s | opw-4220302 Forward-Port-Of: odoo/odoo#185251 Forward-Port-Of: odoo/

Original PR description

Issue -->

A noticeable amount of time is spent in the method `_get_outgoing_incoming_moves` when doing the `OR` operation on the stock.move recordsets when there is a large number of moves to iterate through.

Solution -->

Replace the odoo recordset operations with set operations.

Benchmarks -->

| # of moves | Before | After |
|--------|--------|--------|
| 32000 | 24.08s | 1.43s |
| 7300 | 1.74s | 0.40s | 

opw-4220302

Forward-Port-Of: odoo/odoo#185251
Forward-Port-Of: odoo/odoo#183671

## Steps: 1- Expenses 2- Settings 3- Employee Expense Journal: all the journals can be selected. It should be only "Purchase" journals. This PR adds a filtering domain to the `expense_journal_id` field to filter out non 'purchase' journals. opw-4251517 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Whe the user clicks on a subcontracting line in the BOM overview, an error is raised. This occurs because we are passing false when subcontracting lines are not folded, but a function is expected. The solution is to pass a function, which should be a void function when toggleFolded is false. Steps to reproduce: 1. Go to the Manufacturing app. 2. Enable the Subcontracting feature in the Setting tab. 3. Navigate to the BoM overview in the Products tab. 4. Open a BoM that includes subcontracting. 5. Click to expand the subcontracting line. Previous behaviour: An error pop-up appears. Current behaviour: Opens without any error. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Since 058212e12b5079eba870bde9775fe98f27928935 Bootstrap's version is 5.3 Many more style is set by CSS Custome properties which wkhtmltopdf does not support This fixes the <hr /> case. opw-4265150 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Issue: ===== FontSize isn't being applied on table selection. Steps to reproduce the issue: ============================= - Create a new to do - Add a table - Add content in some cells - Select from the middle of the content of the first cell to the middle of the content of the last cell - Apply font size - Nothing happens Origin of the issue: ==================== When we have `useResponsiveFontSizes` enabled, we first set the fontSize with undefined and then we set the fontSizeClassName, but in the first execCommand we trigger `historyStep` event. The event is handled by the `html_field` and it will check if the field is dirty. In the process of checking we call `getValue` of `Wysiwyg`. `getValue` will run `cleanForSave` on the editor which will deselect tables. Solution: ========= We reset the selection after the first execCommand. opw-4237983

**Prior to this commit:** - While configuring a pricelist, if we don't select any website in the Website field, the placeholder let us think that it should be applied on 'All websites'. **Post this commit:** - The placeholder is renamed as 'Select a website' as the pricelist doesn't apply to any website when the field is empty. **Affected version:** saas-17.4~master **opw**-4256656

Since [1] e-mails from forms are compared to the logged in user's e-mail when a website form is submitted. Because of this forms without e-mail cannot be used anymore when the user is not logged in. This commit removes this comparison for forms that do not contain an e-mail field. Steps to reproduce: - Install website_hr_recruitment - Drop a form into the home page - Set the form action to "Apply for a Job" - Remove the e-mail field - Save - Submit the form => An error occurred [1]: https://github.com/odoo/odoo/commit/1aa5cbb06be85e94c01f8f55ef57b9415b9bb50f task-4282750

In commit 9f4f1d8e92d0dc68b5628194d9da56d346e708f6, "Move to next week" step is not being processed because of missing `run` argument. It is necessary for the test to work on saturday and was the main reason of the previous commit being deployed. runbot-error-65494

**Current behavior:** Duplicating a user-defined filter will fail and trigger an exception. **Expected behavior:** Record duplicates. **Steps to reproduce:** 1. Go to some menu, create a filter 2. In technical settings, go to user-defined-filters menu 3. Select one and duplicate it -> Exception **Cause of issue:** The SQL constraint check_res_id_only_when_embedded_action is triggering because `embedded_parent_res_id` is an Integer type field which, when NULL in postgres, will be interpreted by the ORM as 0 when the record we want to duplicate has its values copied. **Fix:** In the copy_data override for `ir.filters`, delete the key, value pair for `embedded_parent_res_id` if its value is 0. The only case this problem arises in, is when we copy values from an existing filter record and directly use them for creating a new one- i.e., on duplication/copy. opw-4234421

Steps to reproduce: 1. Install Restaurant and Appointments 2. in PoS's Settings, enable booking 3. go to PoS -> Configurations -> Floor plans 4. Select a floor There is no "Appointment resource" field in the tree view. Initially in 17.2, the tree items in the floor page (the tables) were not editable in place, so clicking on a table opened the form view where we could change the "Appointment resource". However, in 17.4, the tree was made editable in place, but we've missed adding the "Appointment resource" field. This PR adds back the field "Appointment resource" (as hidden field) to the floor tables tree view. The changes in this PR were copied from version 18.0, where this bug was already fixed by commit https://github.com/odoo/enterprise/commit/f240b921dd3548b5f91d947354abc85f947f486b opw-4237285

**Current behavior:** Using the DHL delivery shipping module, if you complete a sale order's delivery and then add new product to the order and, again, validate the new delivery, the shipping chatter will be posted in all of the sale order's pickings. **Expected behavior:** The chatter should only be posted in the picking which was actually validated. **Steps to reproduce:** *Install delivery_dhl and l10n_be_hr_payroll* *Swap to My Belgian Company* *Duplicate the My Belgian Company partner record, giving it new unique values where necessary (VAT, address, etc.)* 1. Create a new sale order to the copied Belgian company 2. Add some storable product and add DHL EU shipping to the order (only DHL connector working) 3. Confirm the order, and validate the delivery 4. Back on the sale order, add another order line and save 5. Validate the new delivery, see that the delivery chatter is posted on both deliveries **Cause of the issue:** The message is currently logged on `sale_id.picking_ids`. **Fix:** Change the line in question to only log the message on the currently iterated over picking, as well as any relevant, previously created ones (e.g., in a multistep route context). opw-4059145 Forward-Port-Of: odoo/enterprise#72730 Forward-Port-Of: odoo/enterprise#71441

### Steps to reproduce: - Create a product with a bom and an operation op1 - Create and confirm an MO for 1 unit of that product - Go to the shopfloor > on the operation > 3 dots > Add component - Add a component to be consumed in that operation #### > While the componenet was correctly added to the MO and linked to the WO it is not visible on hte shopfloor. ### Cause of the issue: The only moves that are visible on "MrpDisplayRecord"'s are the move that are in `manual_consumption = True` see: https://github.com/odoo/enterprise/blob/88a092acd261db8f3a8ee1f0cf8174c3d7089472/mrp_workorder/static/src/mrp_display/mrp_display_record.js#L188-L191 However, when a product is added via the `action_add_component` > `add_product`, the `manual_consumption` of the move is computed as if it was added to the MO without being linked to a `bom_line_id`: https://github.com/odoo/enterprise/blob/88a092acd261db8f3a8ee1f0cf8174c3d7089472/mrp_workorder/wizard/additional_product.py#L36-L46 https://github.com/odoo/odoo/blob/2d652f42f63c2501b1a9feb7a4830ea3d7d05f51/addons/mrp/models/mrp_production.py#L1198 As a result the move_raw is added as a manual_consumption = False. ### Note: Thank to Commit eb751b5f861b25205dbb0b0fb90ddcdbbcd10f55 , the issue is not reproducible in 18.0 anymore. This was soved in the same manner: https://github.com/odoo/enterprise/blob/2a0ccbe7058f8d4383a63ed1897945bec3a1cec3/mrp_workorder/models/mrp_production.py#L36-L38 https://github.com/odoo/enterprise/blob/2a0ccbe7058f8d4383a63ed1897945bec3a1cec3/mrp_workorder/models/mrp_production.py#L107-L114 opw-4199156 Forward-Port-Of: odoo/enterprise#72330 Forward-Port-Of: odoo/enterprise#71803

Bug Fixes(11)

[FIX] hr_expense: only purchase journals in employee's expense journal settings

[FIX] mrp: click in the subcontracting line without raise an error

[FIX] web: report scss: hr node hardcoded border

[FIX] web_editor: apply fontsize for table selection

[FIX] website_sale: change placeholder for website in pricelist

[FIX] website: allow forms without emails to be submitted when logged in

[FIX] maintenance: specify click in next week step run

[FIX] base: del 0 val parent_res_id when duplicating filter

[FIX] spreadsheet_edition: correct stacked checkbox label

[FIX] account_accountant: bank reconciliation empty layout

[FIX] pos_restaurant_appointment: add Appointment Resource field to the tree view

Other(23)

[FW][PERF] sale_stock: improve perf of _get_outgoing_incoming_moves

Bug Fixes(11)

[FIX] hr_expense: only purchase journals in employee's expense journal settings

[FIX] mrp: click in the subcontracting line without raise an error

[FIX] web: report scss: hr node hardcoded border

[FIX] web_editor: apply fontsize for table selection

[FIX] website_sale: change placeholder for website in pricelist

[FIX] website: allow forms without emails to be submitted when logged in

[FIX] maintenance: specify click in next week step run

[FIX] base: del 0 val parent_res_id when duplicating filter

[FIX] spreadsheet_edition: correct stacked checkbox label

[FIX] account_accountant: bank reconciliation empty layout

[FIX] pos_restaurant_appointment: add Appointment Resource field to the tree view

Other(23)

[FW][PERF] sale_stock: improve perf of _get_outgoing_incoming_moves

[FW][FIX] stock: add language to context in traceability report

[FW][FIX] sale_loyalty: only display tax_desc on line if there's multiple

[FW][FIX] mail: emoji generator doesn't work with '<'

[FW][FIX] l10n_es_pos: not invoice when settling customer accounts

[FW][FIX] l10n_hu_edi: bank account number error

[FW][FIX] l10n_in: Remove Enterprise Widget from Indian Electronic Waybill

[FW][FIX] uom: can not delete uom category

[FW][FIX] l10n_de: fix the deletion of invoices that have corrupted attachments

[FW][FIX] stock: display the quant name in detailed operation

[FW][FIX] point_of_sale: Trusted pos only show pos from the current company

[FW][I18N] l10n_din5008{_*}: Correct and clean up translations

[FW][IMP] l10n_it_edi: DatiFattureCollegate must include all reconciled moves

[FW][FIX] stock_account: Use correct UOM for correction svl quantity

[FW][FIX] pos_sale: show correct value when paying through downpayment(percentage)

[FW][FIX] delivery_dhl: post delivery chatter in relevant pickings

[FW][FIX] mrp_workorder: display additional component on shopfloor

[FW][FIX] account_accountant: edit exchange in bank reco widget

[FW][FIX] pos_settle_due: easily recognize settling account orders

[FW][FIX] sale_purchase_inter_company_rules: transfer order dates

[FW][FIX] quality_control: display all quality checks linked to finished lot

[I18N] l10n_din5008_*: Correct and clean up translations

[FW][FIX] l10n_jp_zengin: fix typo message