Monday, October 28, 2024
11 changes · saas-17.4
Resolved issues and error corrections
The Employee Expense Journal setting now limits choices to purchase journals only. This prevents users from selecting an unsuitable journal and helps keep expense accounting setup accurate.
Original PR description
## Steps: 1- Expenses 2- Settings 3- Employee Expense Journal: all the journals can be selected. It should be only "Purchase" journals. This PR adds a filtering domain to the `expense_journal_id` field to filter out non 'purchase' journals. opw-4251517 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users can now expand subcontracting lines in the Bill of Materials overview without seeing an error pop-up. This improves reliability for manufacturing teams reviewing subcontracted components and keeps the BoM overview usable.
Original PR description
Whe the user clicks on a subcontracting line in the BOM overview, an error is raised. This occurs because we are passing false when subcontracting lines are not folded, but a function is expected. The solution is to pass a function, which should be a void function when toggleFolded is false. Steps to reproduce: 1. Go to the Manufacturing app. 2. Enable the Subcontracting feature in the Setting tab. 3. Navigate to the BoM overview in the Products tab. 4. Open a BoM that includes subcontracting. 5. Click to expand the subcontracting line. Previous behaviour: An error pop-up appears. Current behaviour: Opens without any error. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where horizontal divider lines could display incorrectly in generated reports. The change helps keep printed or PDF reports visually consistent after the underlying styling framework update.
Original PR description
Since 058212e12b5079eba870bde9775fe98f27928935 Bootstrap's version is 5.3 Many more style is set by CSS Custome properties which wkhtmltopdf does not support This fixes the <hr /> case. opw-4265150 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a problem where changing font size did not apply when users selected text across table cells in the web editor. The editor now keeps the table selection intact during the formatting process, so the chosen font size is applied as expected.
Original PR description
Issue: ===== FontSize isn't being applied on table selection. Steps to reproduce the issue: ============================= - Create a new to do - Add a table - Add content in some cells - Select from the middle of the content of the first cell to the middle of the content of the last cell - Apply font size - Nothing happens Origin of the issue: ==================== When we have `useResponsiveFontSizes` enabled, we first set the fontSize with undefined and then we set the fontSizeClassName, but in the first execCommand we trigger `historyStep` event. The event is handled by the `html_field` and it will check if the field is dirty. In the process of checking we call `getValue` of `Wysiwyg`. `getValue` will run `cleanForSave` on the editor which will deselect tables. Solution: ========= We reset the selection after the first execCommand. opw-4237983
The Website field on pricelists now says “Select a website” instead of implying that leaving it blank applies the pricelist to all websites. This helps users avoid misconfiguring pricelists by making the empty-field behavior clearer.
Original PR description
**Prior to this commit:** - While configuring a pricelist, if we don't select any website in the Website field, the placeholder let us think that it should be applied on 'All websites'. **Post this commit:** - The placeholder is renamed as 'Select a website' as the pricelist doesn't apply to any website when the field is empty. **Affected version:** saas-17.4~master **opw**-4256656
Website forms that do not ask for an email address can now be submitted successfully by logged-in users. This prevents valid forms, such as job application forms customized without an email field, from failing unnecessarily.
Original PR description
Since [1] e-mails from forms are compared to the logged in user's e-mail when a website form is submitted. Because of this forms without e-mail cannot be used anymore when the user is not logged in. This commit removes this comparison for forms that do not contain an e-mail field. Steps to reproduce: - Install website_hr_recruitment - Drop a form into the home page - Set the form action to "Apply for a Job" - Remove the e-mail field - Save - Submit the form => An error occurred [1]: https://github.com/odoo/odoo/commit/1aa5cbb06be85e94c01f8f55ef57b9415b9bb50f task-4282750
A maintenance module test was corrected so its calendar can reliably move to the next week during automated checks. This helps prevent false test failures, especially around Saturdays, supporting more stable releases without changing user-facing features.
Original PR description
In commit 9f4f1d8e92d0dc68b5628194d9da56d346e708f6, "Move to next week" step is not being processed because of missing `run` argument. It is necessary for the test to work on saturday and was the main reason of the previous commit being deployed. runbot-error-65494
Fixes an issue that caused an error when duplicating saved user-defined filters. This restores the expected copy behavior, helping users and administrators manage filters without interruption.
Original PR description
**Current behavior:** Duplicating a user-defined filter will fail and trigger an exception. **Expected behavior:** Record duplicates. **Steps to reproduce:** 1. Go to some menu, create a filter 2. In technical settings, go to user-defined-filters menu 3. Select one and duplicate it -> Exception **Cause of issue:** The SQL constraint check_res_id_only_when_embedded_action is triggering because `embedded_parent_res_id` is an Integer type field which, when NULL in postgres, will be interpreted by the ORM as 0 when the record we want to duplicate has its values copied. **Fix:** In the copy_data override for `ir.filters`, delete the key, value pair for `embedded_parent_res_id` if its value is 0. The only case this problem arises in, is when we copy values from an existing filter record and directly use them for creating a new one- i.e., on duplication/copy. opw-4234421
The chart configuration panel now refreshes the stacked option label when users switch chart types. This prevents confusing or outdated wording and helps users configure spreadsheet charts more reliably.
Original PR description
This PR addresses an issue where the stacked checkbox label in the chart config panel was not updating when the chart type was changed. Task: 4251670
The bank reconciliation screen now keeps its two-column layout even when there are no transactions to show. This avoids a confusing empty-state layout and helps users keep the same visual structure while waiting for activity.
Original PR description
We want to keep the two columns layout when there is no transaction yet. Task-id: 4150010
Restaurant floor table setup now includes the appointment resource information needed when bookings are enabled. This restores access to an important booking configuration that became unavailable after the table list was made editable directly.
Original PR description
Steps to reproduce: 1. Install Restaurant and Appointments 2. in PoS's Settings, enable booking 3. go to PoS -> Configurations -> Floor plans 4. Select a floor There is no "Appointment resource" field in the tree view. Initially in 17.2, the tree items in the floor page (the tables) were not editable in place, so clicking on a table opened the form view where we could change the "Appointment resource". However, in 17.4, the tree was made editable in place, but we've missed adding the "Appointment resource" field. This PR adds back the field "Appointment resource" (as hidden field) to the floor tables tree view. The changes in this PR were copied from version 18.0, where this bug was already fixed by commit https://github.com/odoo/enterprise/commit/f240b921dd3548b5f91d947354abc85f947f486b opw-4237285