Monday, October 28, 2024
1 change
Code cleanup and technical improvements
This change simplifies the internal structure used to run automated web tours by removing an extra conversion step. It should make the tour code easier for developers to understand and maintain, without changing the user-facing behavior of Odoo.
Original PR description
In this commit, we remove compileToMacro method from TourStepAutomatic class. The compileToMacro method complicates the understanding of how tours work. It is more obvious and above all simpler to directly return an object corresponding to the macro input (in TourAutomatic) rather than going through nested method calls. It also makes the TourStepAutomatic and TourAutomatic classes simpler and more understandable. (And this allows you to only have methods of less than 60 lines) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr