Tuesday, October 29, 2024
6 changes · 18.0
Resolved issues and error corrections
The mobile editing toolbar now stays directly above the on-screen keyboard instead of leaving an awkward gap. This makes editing content on phones smoother and reduces visual confusion for users.
Original PR description
Current behavior before PR: When the keyboard opens on mobile, the toolbar appears in the wrong position, leaving a space between the toolbar and the keyboard. Desired behavior after PR is merged: Now, when the keyboard opens on mobile, the toolbar will correctly stick to the top of the keyboard. task:4196686
This update fixes several small issues in automated guided tours for Project, Project Todo, and Website Sale Autocomplete. These changes help keep test flows stable by avoiding duplicate actions, using existing sample data, and waiting for records to be created before continuing.
Original PR description
In this commit, we make little fix for multiple tours. project_update_tour_tests.js: remove two time click. project_todo_main_functions.js: fill marc instead of test to avoid to create a new user. autocomplete_tour.js: precise trigger to remove run functions. project_tour.js: check the new record is created before continue the tour. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update applies the project's JavaScript formatting rules to web test files that previously missed automated checks. It helps keep the test suite consistent and easier to maintain, without changing customer-facing behavior.
Original PR description
Since the creation of v18, the JavaScript tooling wasn't enabled. The tooling was enabled in commit[1]. In this commit, we applied a manual eslint pass inside the "web/static/tests" directory to ensure we have well-formatted .test.js files. ``` eslint '**/web/static/tests/**/*.js' --fix ``` [1]: https://github.com/odoo/odoo/commit/f3407c392d4e7595e9a299662115df03bacbd41c
Fixes an issue where message author avatars disappeared for guests after a member left a public chat channel. This keeps chat history clearer and easier to follow for external or guest viewers.
Original PR description
Steps to reproduce: - Create a public channel - Add a non website_published user as a new member - Log in as that new member and send a message then leave the channel - Open the channel as a guest - The author avatar of the message is not there
This fixes a toolbar issue in the HTML editor where clicking near the edge of dropdown items could close the toolbar instead of selecting the option. It also ensures the selected 13px font size is displayed correctly, making formatting controls more reliable for users.
Original PR description
Description of the issue this PR addresses: Current behavior before PR: Clicking near the edge of a toolbar dropdown item would not work. This occurred because the `user-select-none` class was applied to the child element rather than the dropdown item itself, causing `onSelectionChange` to be triggered, followed by `updateToolbarVisibility` closing the toolbar. Desired behavior after PR is merged: The `user-select-none` class is now applied directly to the dropdown item, preventing `updateToolbarVisibility` from closing the toolbar when clicking near the edges of dropdown items. task-4241028 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The upload button for quote builder documents is now hidden until a quotation template has been saved. This prevents users from triggering an error when adding documents before the system has created the template record needed to attach them correctly.
Original PR description
When attempting to upload a file in the ``Quotation Templates`` without saving the template first, an error occurs in the terminal. Steps to reproduce: --- - Install the ``sale_management`` module -…
When attempting to upload a file in the ``Quotation Templates`` without saving the template first, an error occurs in the terminal. Steps to reproduce: --- - Install the ``sale_management`` module - Sales > Configuration > Sales Order > Quotation Templates - Create New > Quote Builder > Click on Upload - Try to upload a file Traceback: --- ``ValueError: invalid literal for int() with base 10: 'false'`` Previous Behaviour: --- When attempting to upload a file in the ``Quotation Templates`` without first saving the template, the template ID is not generated at [1]. As a result, at [2], we encounter an issue where ``int(sale_order_template_id) = 'false'``. This happens because the template tries to access its name in the uploaded file. If the template name is not available and we attempt to upload the file, ``resId`` at [1] will be returned as false. Solution: --- Until the template is saved, the upload button will remain hidden. Once the template is saved, the upload button will be displayed. This ensures that when a file is uploaded, the template name will be properly associated with it. [1]- https://github.com/odoo/odoo/blob/c5ce138697d7c5ebe200566dfb8b7ba55365f100/addons/sale_pdf_quote_builder/static/src/js/quotation_document_kanban/quotation_document_kanban_widget.js#L21-L23 [2]- https://github.com/odoo/odoo/blob/c5ce138697d7c5ebe200566dfb8b7ba55365f100/addons/sale_pdf_quote_builder/controllers/quotation_document.py#L24-L26 sentry-5963406254 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr