Odoo Changelog — 2024-10-30

Wednesday, October 30, 2024

31 changes · saas-17.4

Bug Fixes(6)

Resolved issues and error corrections

[FIX] website_sale: fix strikethrough price computation

Coresaas-17.4website_sale

Fixes when discounted prices are shown in the online store so the crossed-out comparison price is only displayed when it is actually higher than the price customers see. This prevents confusing cases where the original price appeared lower than the current tax-included price.

Original PR description

Previously, we compared the `compare_list_price` to the tax-excluded price to know whether to show a strikethrough price. However, if eCommerce was set up to show the tax-included price, we would sometimes show a strikethrough price that was smaller than the actual price (if `tax_excluded_price < compare_list_price and tax_included_price > compare_list_price`).

This change compares the `compare_list_price` to the price actually shown on eCommerce.

Partial backport of c5c2916a14bdc13b492f16e515c9231295607121

#ecommerce#pricing#discounts#taxes

[FIX] website: fix the history when sliding "Image Gallery"

PR #185744

Coresaas-17.4website

Fixes an issue where sliding an image gallery or similar carousel in the website editor could create unnecessary undo history entries. This keeps the editing history cleaner and makes undo behavior more predictable for website editors.

Original PR description

Since commit [1], sliding the `s_image_gallery` snippet, as well as any carousel not having the "Carousel" and "Carousel Item" options, should not add steps in the history. This was done by filtering the mutations records: all the class and attribute changes related to the sliding of these specific carousels are now ignored.

However, since commit [2], which fixed the auto-slide behavior of the carousels, an `o_carousel_sliding` class is now added on the `.carousel` element during the slide. The issue is that this class was not added in the list of classes to ignore when filtering the mutations, which therefore made this class addition/removal add a step in the history.

This commit fixes that by considering this class. Note that this fix was already made in upper versions, when forward-porting commit [1].

[1]: https://github.com/odoo/odoo/commit/509e78dcf786581a345913e76f6da72af6baec0b
[2]: https://github.com/odoo/odoo/commit/9eff9ae1904e0583f5dc60c6d925c52b48b208ec

task-3744613

[FIX] website: fix product ribbon shadow overlap on shop page

PR #185017

Coresaas-17.4website

Product images on the online shop could show stray ribbon shadows even when no ribbon was meant to appear, visually cropping the image corner. This fix hides those empty shadows so product tiles display cleanly and consistently.

Original PR description

In 17.4, the `o_ribbon_right` class was applied to all product ribbons on the
shop page, causing empty ribbon shadows to overlap and crop the top-right corner
of product images.

This CSS rule (`display: none`) hides shadows on empty ribbons, preventing
overlap. This approach matches the fix in later versions to avoid layout issues.

This is done already in the v18 with this commit
https://github.com/odoo/odoo/commit/b5b8a133eb67f01cabec01a1dc874e8a27a3bb46#diff-f338780f594d6b1f46eda5d3fb9fed86f3c3c8f65522fb93e639534e9d92cdb2R1832

opw-4190631

#website#shop#product images#visual fix

[FIX] bus: improve debug logs for WebSocket worker

PR #185801

Coresaas-17.4bus

This change adds clearer debug logging for the bus service's browser connection worker, making it easier for support and developers to understand connection behavior across tabs and browsers. It does not change end-user functionality, but should reduce investigation time when real-time updates or WebSocket connections need troubleshooting.

Original PR description

The bus service uses a shared worker to reduce the number of
connections to the server. However, debugging the worker state can be
challenging. If the shared worker is opened later, the WebSocket does
not appear in the network tab. Additionally, the worker manages
multiple tab and network states, which are not easy to visualize.

This commit adds debug logs to the WebSocket worker to track
communication between the client and worker, as well as between the
worker and server.

The log is done by each tab because Safari does not provide devtools
for the shared worker. As a result, logs would be unreachable. It's
easier to access the logs from the tab devtools.

#debugging#websocket#supportability

[FIX] website_sale: make input placeholder translatable.

PR #185480

Coresaas-17.4salewebsite_sale

The checkout placeholder for entering a customized product option is now included in the website sales translation files. This ensures shoppers using optional products see the prompt in their selected language, improving consistency for multilingual storefronts.

Original PR description

When you choose to add a free text value to a variant of the optional products at checkout, you will encounter a placeholder that is not translated: "Enter a customized value". This is because it's defined only in `sale` module, which is not a frontend module. This commit adds the untranslated text to the frontend module: website_sale.

Task-4229289

#translation#checkout#optional products

[FIX] appointment_account_payment: blacklist product service tracking

PR #71166

Enterprisesaas-17.4appointment_account_payment

Appointment users can now select up-front payment products that create project tasks, which were previously hidden by mistake. The change keeps unsuitable event-related products excluded while restoring valid service products, reducing setup friction for appointment payments.

Original PR description

In the Appointment app, when trying to select an "Up-front payment product," products configured to create a task in a project are not available in the dropdown list.

Cause of the issue:
In the `appointment_type` model definition within the `appointment_account_payment` module, a domain was applied on the `product_id` field, restricting the selectable products. The domain filtered out products with the `service_tracking` field set to values other than `"no"`. As a result, products that create tasks in projects (which have `service_tracking` set to `"task_global_project"`) were excluded. The commit https://github.com/odoo/enterprise/commit/ff54ff6cbdf79b1c24c468b5238d8eeb91e85cb9 aim was to prevent `event` and `event_booth` product to be selectable. This commit allows other product whose `service_tracking != 'no'` to be selectable while not allowing `event` and `event_booth`.

opw-4146731

#appointments#payments#products

Other(25)

Miscellaneous changes

[FW][FIX] base: compare email_normalized for {email/smtp}_from

PR #185836

Coresaas-17.4base

Use normalized emails for comparison to avoid issues linked to formatting. Task-4281171: [mail] {email/smtp}_from normalized comparison Forward-Port-Of: odoo/odoo#185766 Forward-Port-Of: odoo/odoo#185749

Original PR description

Use normalized emails for comparison to avoid issues linked to formatting.

Task-4281171: [mail] {email/smtp}_from normalized comparison

Forward-Port-Of: odoo/odoo#185766
Forward-Port-Of: odoo/odoo#185749

[FW][IMP] l10n_es: Add new tax grid for es

PR #185837

Previously, we compared the `compare_list_price` to the tax-excluded price to know whether to show a strikethrough price. However, if eCommerce was set up to show the tax-included price, we would sometimes show a strikethrough price that was smaller than the actual price (if `tax_excluded_price < compare_list_price and tax_included_price > compare_list_price`). This change compares the `compare_list_price` to the price actually shown on eCommerce. Partial backport of c5c2916a14bdc13b492f16e515c9231295607121

Since commit [1], sliding the `s_image_gallery` snippet, as well as any carousel not having the "Carousel" and "Carousel Item" options, should not add steps in the history. This was done by filtering the mutations records: all the class and attribute changes related to the sliding of these specific carousels are now ignored. However, since commit [2], which fixed the auto-slide behavior of the carousels, an `o_carousel_sliding` class is now added on the `.carousel` element during the slide. The issue is that this class was not added in the list of classes to ignore when filtering the mutations, which therefore made this class addition/removal add a step in the history. This commit fixes that by considering this class. Note that this fix was already made in upper versions, when forward-porting commit [1]. [1]: https://github.com/odoo/odoo/commit/509e78dcf786581a345913e76f6da72af6baec0b [2]: https://github.com/odoo/odoo/commit/9eff9ae1904e0583f5dc60c6d925c52b48b208ec task-3744613

In 17.4, the `o_ribbon_right` class was applied to all product ribbons on the shop page, causing empty ribbon shadows to overlap and crop the top-right corner of product images. This CSS rule (`display: none`) hides shadows on empty ribbons, preventing overlap. This approach matches the fix in later versions to avoid layout issues. This is done already in the v18 with this commit https://github.com/odoo/odoo/commit/b5b8a133eb67f01cabec01a1dc874e8a27a3bb46#diff-f338780f594d6b1f46eda5d3fb9fed86f3c3c8f65522fb93e639534e9d92cdb2R1832 opw-4190631

The bus service uses a shared worker to reduce the number of connections to the server. However, debugging the worker state can be challenging. If the shared worker is opened later, the WebSocket does not appear in the network tab. Additionally, the worker manages multiple tab and network states, which are not easy to visualize. This commit adds debug logs to the WebSocket worker to track communication between the client and worker, as well as between the worker and server. The log is done by each tab because Safari does not provide devtools for the shared worker. As a result, logs would be unreachable. It's easier to access the logs from the tab devtools.

When you choose to add a free text value to a variant of the optional products at checkout, you will encounter a placeholder that is not translated: "Enter a customized value". This is because it's defined only in `sale` module, which is not a frontend module. This commit adds the untranslated text to the frontend module: website_sale. Task-4229289

In the Appointment app, when trying to select an "Up-front payment product," products configured to create a task in a project are not available in the dropdown list. Cause of the issue: In the `appointment_type` model definition within the `appointment_account_payment` module, a domain was applied on the `product_id` field, restricting the selectable products. The domain filtered out products with the `service_tracking` field set to values other than `"no"`. As a result, products that create tasks in projects (which have `service_tracking` set to `"task_global_project"`) were excluded. The commit https://github.com/odoo/enterprise/commit/ff54ff6cbdf79b1c24c468b5238d8eeb91e85cb9 aim was to prevent `event` and `event_booth` product to be selectable. This commit allows other product whose `service_tracking != 'no'` to be selectable while not allowing `event` and `event_booth`. opw-4146731

On a stock move, when using a lot from a sub-location, the created SML will still start from SM's source location instead of lot's location To reproduce the issue: 1. In Settings, enable "Storage Locations" 2. Create a tracked-by-sn product P 3. Update its qty: - SN01 at WH/Stock - SN02 at WH/Stock/Shelf 1 4. Confirm a delivery with 1 x P 5. Enable the column "Serial Number" - SN01 should be present 6. Remove SN01, set SN02 7. Validate the transfer 8. Open the detailed operations Result: SN02 has been taken from WH/Stock, but the user probably wanted to use the existing one, in WH/Stock/Shelf 1. An onchange already exists to make sure that the user is not using a lot that already exists somewhere else. Before Odoo 17.2, we were considering the sub locations as not expected: https://github.com/odoo/odoo/blob/d5a7a3d02e3e2b4e47977abc8b9fc0d5d6135937/addons/stock/models/stock_move.py#L1167 But since Odoo 17.2 (via [1]), we now also accept the sub locations: https://github.com/odoo/odoo/blob/60b0bafc8abd1893c9cdd9913617c234692369cf/addons/stock/models/stock_move.py#L1242 This is a bit confusing because we don't display any warning anymore, but we don't select the correct source location neither. The commit should help the user and avoid that confusion [1] https://github.com/odoo/odoo/commit/99b39b72c7e65e85af6f06dcb6b02867623f3f69 OPW-4231749 Forward-Port-Of: odoo/odoo#185796

Steps to reproduce: - New Project > New Task > Timesheet 10h on task - New subtask on task > Timesheet 5h on subtask - Reporting > Tasks Analysis Remaining hours are computed incorrectly, when no allocated hours are set on a task, we have null values in database that prevent the computation of allocated_hours and remaining_hours which also messes up the project totals. The computation of remaining hours is also only supposed to occur when we have a non zero amount of allocated hours, otherwise the remaining hours are always 0. Additionally, the 'Total Hours' column is confusing for customers as it is meant to compute the total hours spent on a task (subtasks included) but is enabled by default when looking at the projects as a whole which does not make sense. For instance, with 'Task' parent of 'Subtask': | Name | Allocated | Hours spent | Remaining | Total Hours | | -------- | --------- | ----------- | ---------- | ----------- | | Project | 0 | 15 | -15 (-> 0) | 20 | | Task | 0 | 10 | -10 (-> 0) | 15 | | Subtask | 0 | 5 | -5 (-> 0) | 5 | The sum of total hours on project is meaningless and confusing so it is preferable not to have it enabled by default (Subtask is counted twice, once in Task and once itself). opw-4236984 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185490 Forward-Port-Of: odoo/odoo#184291

Steps to reproduce: 1. Go to a website page (in edit mode) > Switch the header template to `"Menu with Search Bar"`. 2. Set a highlight effect on the text element in the top section of the header. 3. The highlight keeps adapting itself infinitely. Technical details: After [1], two header navbars were added in the DOM (for the desktop view and mobile). Which means that the targeted text field is also duplicated and every change on it in Desktop will be reflected in the "invisible" mobile version. When the text is highlighted, the highlight observers are also adapting the content on both navbars... To understand the conflict, here is an example of the behaviour causing the infinite loop: **a.** DESKTOP TEMPLATE > Set a highlight on the text field: ```xml <span class="o_text_highlight"> <span class="o_text_highlight_item"> Text content. <svg.../> // SVG adapted to text dimensions. </span> ``` **b.** MOBILE TEMPLATE > The "field observer" will set the same content on the "invisible" mobile version: ```xml <span class="o_text_highlight"> <span class="o_text_highlight_item"> Text content. <svg.../> // SVG adapted to the desktop text dimensions. </span> ``` **c.** MOBILE TEMPLATE > The "highlights adaptation system" detects the changes on the hidden mobile field and adapts the highlight: ```xml <span class="o_text_highlight"> <span class="o_text_highlight_item"> Text content. <svg.../> // SVG adapted to the mobile text dimensions (0×0). </span> ``` **d.** DESKTOP TEMPLATE > The "field observer" will set the same content on the desktop version, which automatically triggers the highlight size adaptations... **e.** Same as [**b**]. Infinitely... In this very specific case, the text content is the same, only the highlight path is different (because one of the field duplicates is visible, and the other is hidden). The goal of this commit is to fix this behaviour by preventing the highlight's mutation observer from adapting invisible content. This way, the field synchronization mechanism will always set the same highlight SVG on the hidden duplicate too (*). [1]: https://github.com/odoo/odoo/pull/119650 (*): Remarks: - This won't have an impact on the saved content: We remove all size related DOM (SVG paths, line breaks,...) before the "save" and we only keep minimal information needed to rebuild the highlights. - Also, having a non-adapted effect on the hidden copy of the field is not an issue here since the "highlight resize observer" will immediately fix it once displayed (e.g. when switching to mobile preview). opw-4183587 task-4270159 Forward-Port-Of: odoo/odoo#183414

The purpose of this PR is to be able to process a lot of serial numbers at once. In receipt and deliveries In the current situation, the number of serial already in stock has an impact on the perf (due to `update_available_quantity` that do a `_gather` on current stock). All the metrics below are made with 50 000 SN already in stock Before (in seconds): || Receipt | Delivery | |--------|--------|--------| |100| 1.63 | 34.21 | |5000| 87.04 | 242.56 | |30 000| 563.75 | T.O. | After: || Receipt | Delivery | |--------|--------|--------| |100| 0.91 | 5.62 | |5000| 47.21 | 56.28 | |30 000| 195.27 | 307.80 | By operations/ receipts (for 5000): | | action_assign | button_validate | total | |--------|--------|--------|--------| | Before patch | 5.38 | 82.02 | 87.04 | | After patch | 3.82 | 43.39 | 47.21 | By operations/ deliveries (for 5000): | | action_assign | button_validate | total | |--------|--------|--------|--------| | Before patch | 180.06 | 62.50 | 242.56 | | After patch | 20.51 |35.77 | 56.28 | The main issues: - The constraint check on quant/stock.move.line are done one by one since there is nothing done in batch, same for computed field (Not fixed here) ![delivery-pre-patch](https://github.com/odoo/odoo/assets/5512395/8a7294f1-67b9-45aa-8aa9-8cf3cfc071be) - The put away takes an important amount of times without any putaways rules ![putaways](https://github.com/odoo/odoo/assets/5512395/43e63984-2724-409e-ad31-91d193ea3c0c) - The optimisation made in #116803 was a good idea but it was only use in action_assign. `_action_assign` use strict=False in `_gather` (mts case). It means a child_of operator is in the domain, and it will perform an extra query anyway - The lot_name matching to lot_id is made `stock.move.line` by `stock.move.line` on 30 000, half of the time is spent to find them. ![search_lot_name](https://github.com/odoo/odoo/assets/5512395/83a16210-f85e-4a48-bab8-7db269343b1c) After some testing. The quant_cache could contain too many items than needed by the current operation. Example receive 1 serial number (that will not have an existing quant) will use a quant_cache with all the serial number of the products. As a result, the group by will be super slow. Allow to add an extra domain, to limit the cache size. /!\ could be dangerous if it filter out too much ![extra_domain](https://github.com/odoo/odoo/assets/5512395/42921423-b38d-4686-897f-d2a2c16e9d97) Forward-Port-Of: odoo/odoo#170342 Forward-Port-Of: odoo/odoo#146494

Bug Fixes(6)

[FIX] website_sale: fix strikethrough price computation

[FIX] website: fix the history when sliding "Image Gallery"

[FIX] website: fix product ribbon shadow overlap on shop page

[FIX] bus: improve debug logs for WebSocket worker

[FIX] website_sale: make input placeholder translatable.

[FIX] appointment_account_payment: blacklist product service tracking

Other(25)

[FW][FIX] base: compare email_normalized for {email/smtp}_from

[FW][IMP] l10n_es: Add new tax grid for es

Bug Fixes(6)

[FIX] website_sale: fix strikethrough price computation

[FIX] website: fix the history when sliding "Image Gallery"

[FIX] website: fix product ribbon shadow overlap on shop page

[FIX] bus: improve debug logs for WebSocket worker

[FIX] website_sale: make input placeholder translatable.

[FIX] appointment_account_payment: blacklist product service tracking

Other(25)

[FW][FIX] base: compare email_normalized for {email/smtp}_from

[FW][IMP] l10n_es: Add new tax grid for es

[FW][FIX] hr_holidays_attendance: remove unnecessary view

[FW][FIX] stock: start SML from sub location

[FW][FIX] stock: don't rollback scheduler if it succeeeded

[FW][FIX] web: fix makeAsyncHandler and makeButtonHandler

[FW][IMP] web_editor: autoscroll latest response message in chatgpt

[FW][FIX] hr_timesheet, sale_timesheet: clear up project hours report

[FW][FIX] gamification: fix traceback when user deletes a module having gamification record

[FW][FIX] packaging: update windows installer logo

[FW][FIX] website_event_sale: check seats availability before payment

[FW][IMP] account: better error message when using inconsistent payment account on sale/purchase invoice

[FW][FIX] website: fix highlighted field update and synchronization conflict

[FW] 16.0 stock sn perf arm

[FW][FIX] payment_adyen: add idempotency key for customer-initiated payments

[FW][FIX] mail: public channel fetching and real-time messaging

[FW][FIX] web: remove invisible fields from default export fields

[FW][FIX] l10n_fr_facturx_chorus_pro: udpate PartyIdentification tag

[FW][FIX] payment_adyen: set holder name required

[FW][ADD] l10n_my_edi: Malaysian E-Invoicing

[FW][FIX] l10n_in_edi_ewaybill: fix the ewaybill name log

[FW][FIX] mrp_workorder: shop floor fixes

[FW][FIX] timesheet_grid: get working hours relative to calendar tz

[FW][FIX] delivery_ups_rest: correct shipper on return label

[FW][FIX] web_studio: add data-oe-demo support for t-out