Wednesday, October 30, 2024
3 changes · saas-17.4
Resolved issues and error corrections
Up-front payment setup in Appointments now allows valid service products that create project tasks, while still excluding event-related products that should not be used there. This helps businesses select the right products for appointment payments without exposing unsuitable event or booth products.
Original PR description
*product, event_product, event_booth_sale In the Appointment app, when trying to select an "Up-front payment product," products configured to create a task in a project are not available in the…
*product, event_product, event_booth_sale In the Appointment app, when trying to select an "Up-front payment product," products configured to create a task in a project are not available in the dropdown list. Cause of the issue: In the `appointment_type` model definition within the `appointment_account_payment` module, a domain was applied on the `product_id` field, restricting the selectable products. The domain filtered out products with the `service_tracking` field set to values other than `"no"`. As a result, products that create tasks in projects (which have `service_tracking` set to `"task_global_project"`) were excluded. The commit https://github.com/odoo/enterprise/commit/ff54ff6cbdf79b1c24c468b5238d8eeb91e85cb9 aim was to prevent `event` and `event_booth` product to be selectable. This commit allows other product whose `service_tracking != 'no'` to be selectable while not allowing `event` and `event_booth`. opw-4146731 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents some Mexican and Colombian online shoppers from being blocked at order confirmation with a missing shipping method error. Checkout now ensures customers are returned through the step where delivery is selected, helping reduce failed purchases and support issues.
Original PR description
In Mexican (or Colombian) e-commerce websites, a customer may face an issue where they are unable to confirm an order because no delivery method is selected. ### Steps to reproduce - Install…
In Mexican (or Colombian) e-commerce websites, a customer may face an issue where they are unable to confirm an order because no delivery method is selected. ### Steps to reproduce - Install `l10n_mx_edi_website_sale` - Ensure the website is configured with a Mexican company - Enable 'Automatic Invoice' in website settings - As a public user, proceed through checkout and try to confirm the order The issue occurs if the user is prompted to fill in delivery information and hasn't previously provided an address. This can be consistently reproduced using a new incognito session. Upon attempting to confirm the order, the following error is shown: "No shipping method is selected." ### Cause The delivery information form (`/shop/address/submit`) normally redirects to `/shop/checkout`, where the user selects a delivery method. However, the `_get_extra_billing_info_route` hook can alter the redirect, bypassing the checkout step and causing the delivery method to remain unset. opw-4205135 opw-4222398
Leaderboard rankings now respect each user's access rules when calculating timesheet results. This prevents employees from appearing incorrectly ranked when company or cross-company permissions affect what timesheets they are allowed to see or enter.
Original PR description
Currently, ir.rules are totally ignored in the leaderboard calculation, leading to wrong ranking in some cases (e.g. ir.rule allowing the user to timesheet across companies). This PR aims to make the leaderboard cognizant to ir.rules, by making sure all the ir.rules are applied to every query used in the leaderboard calculation. task-4040044