Thursday, October 31, 2024
24 changes · 18.0
Resolved issues and error corrections
This update adds missing internal labels to a website building block used in the numbers list section. It helps the website editor correctly identify and handle that element, reducing small editing inconsistencies without changing the visible page design.
Original PR description
This commit adds missing `data-snippet` and `data-name` attributes to the `s_hr` snippet used in the structure. task-4223179 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Odoo Community now automatically creates the needed payment accounting entry when a payment is recorded. This ensures invoices show the correct paid status and remaining amount without requiring bank reconciliation or Enterprise-only journal account setup.
Original PR description
In Odoo Community, bank reconciliation is not available. For that reason, when recording a Payment, this should be enough to fully recognize the payment of the invoice, as there is no second "reconciliation step". In this case, we always want a "behind-the-scene" entry to be created to compute the amount_residual and the status of the invoice accordingly. After the Payments rework, the problem is that by default, no Outstanding account is set up on basic Payment Methods, not triggering any entry and messing up the computation of the invoice status. On top of that, the user shouldn't even have to configure accounts on journals, as this is a pure Accounting work. task-4224553 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Links to uploaded web addresses are no longer treated like downloadable documents in the editor. This keeps the link options consistent, while real document links continue to open in a new window as intended.
Original PR description
Since [1] documents can be uploaded in links. All these attachments are considered as documents, even if they are URLs. The "Open in New Window" option is available for any link, while it should be forced to a new window for documents. This commit introduces the distinction between URL and non-URL attachments: only the non-URL attachments are now considered as documents. In order to make that information available when switching between links: - missing steps of `start` are now included when updating props - sequence of updating props is forced by putting it in a method The "Open in New Window" option is only visible for non-documents. Upon link update, documents are always open in new window and non-document are never download links. [1]: https://github.com/odoo/odoo/commit/cec6ee74de4b904b590d41140d99ae844ed1f15d task-4208243
This fix removes an editor option that could break the layout of the website numbers snippet when changing its column count. It helps website editors avoid accidentally creating a visually broken section.
Original PR description
Changing the amount of columns of this snippet from the dropdown in the editor makes the layout break. This commit prevent the user from doing that. task-4223179 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a flaky automated test for the website slides fullscreen editor by making it wait until the slide link is ready before clicking it. The change helps keep validation runs stable and reduces false failures during development.
Original PR description
The tour "full_screen_web_editor" is failing randomly on the runbot because the step that clicks on the "Home Gardening" slide doesn't open it in fullscreen (as seen in a screenshot of a failing runbot). It is very likely because the fullscreen parameter on the "Home Gardening" link is added afterward in javascript and is not yet present when it is clicked in the test (see function _updateHref of websiteSlidesCourseSlidesList widget). To solve the problem we change the selector that clicks on the "Home Gardening" link to ensure the fullscreen parameter is present in the link. Task-4222573
This fix prevents Point of Sale test tours from failing when a tour is not available in its specific asset bundle. It helps keep automated checks stable without changing day-to-day user behavior.
Original PR description
In Point of Sale module we didn't load all the javascript tour because this module use specific assets bundle. This commit fix the issue by verifying if the tour exist in the registry before trying to get it.
The combo product configurator has been adjusted to work better on mobile screens. This makes it easier for shoppers and sales users to view product options and adjust quantities without layout issues.
Original PR description
This commit fix usability issues related to the layout of the combo configurator on mobile. task-4243795 | Before | After | |--------|--------| | <img width="507" alt="Capture d’écran 2024-10-22 à 13 28 53" src="https://github.com/user-attachments/assets/cac3aa9b-165e-49e6-98e3-3dd1eb2d8d9b"> | <img width="489" alt="Capture d’écran 2024-10-22 à 13 30 14" src="https://github.com/user-attachments/assets/fc0da502-291f-4154-af5e-df1e74c8c61f"> | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Customer and contact lists can now be ordered alphabetically by name, making it easier for users to browse and find records. This fixes a limitation caused by sorting on a non-stored display field and improves day-to-day usability in customer management views.
Original PR description
Steps to reproduce: Go to Accounting > Customers > Customers. Current behavior: The contact list cannot be ordered alphabetically by name. The `Name` field is `display_name`, a computed field in `res.partner` that is not stored, preventing alphabetical sorting. In future versions (starting from saas-17.2), `display_name` will be replaced by `complete_name`, a stored field containing the full name of the customer, which supports alphabetical ordering. opw-4262464 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Manufacturing overview's Plan Orders button now opens the relevant work orders for the selected work center and its alternatives, instead of sending users to an unrelated manufacturing order or broad work order list. This helps planners find the right operational tasks faster and reduces confusion when managing work center capacity.
Original PR description
The 'PLAN ORDERS' button in the Manufacturing overview now leads to the list of all WOs regardless of workcenter and status. Task ID: [4154879](https://www.odoo.com/odoo/966/tasks/4154879)
Customers checking out on Argentina- or Brazil-localized websites can now edit their address without the checkout failing. The fix ensures the required local address fields are handled properly, reducing purchase interruptions for public web shop users.
Original PR description
- Change the company of the first website to the localized company - Open web shop as public user - Make a purchase - Checkout and fill the address - Edit the address - Confirm Issue: Traceback will raise because of the missing localization fields opw-4232531
This update fixes an internal automated checkout test for Ecuador website sales after a recent platform change made one test setting invalid. It helps keep quality checks running correctly without changing the customer-facing shopping experience.
Original PR description
After odoo/odoo@45b90b8b7ce252e1558728f4fc03e52459817565 `test: true` is not a valid tour key anymore Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When users add a link to an image while editing content inside a dialog, the link options now appear in front instead of being hidden behind the dialog. This prevents confusion and makes document layout editing smoother.
Original PR description
Problem: If a dialog is open and the link popover is triggered, it remains behind the dialog, creating further usability issues. Probem: The overlay items are displayed according to their `sequence` attribute, which determines their display order: https://github.com/odoo/odoo/blob/bb20a6d0b3c3a70edbc1f68f560be1f333379ede/addons/web/static/src/core/overlay/overlay_container.js#L65-L67 Solution: Increase the `sequence` value for the `LinkPopover` overlay, ensuring it appears on top of other overlays, including dialogs. Steps to reproduce: 1. Insert an image in the editor in Settings/Configure your document layout/Footer. 2. Click on the image and try to add a link. 3. Observe that the link popover is not visible. opw-4244308
Applying the stretch option to an image in the website editor no longer briefly shows an intermediate image. This creates a smoother editing experience and avoids visual distraction while content is being adjusted.
Original PR description
Before this PR: - An intermediate image was briefly visible when the stretch option was applied, causing a flickering effect. After this PR: - The intermediate image is no longer visible, eliminating the flickering issue. - A cloned image element is used during the processing of the actual image, ensuring that the intermediate image is hidden. task-4206947 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures sales orders with down payments show the correct remaining amount to invoice. It helps prevent billing mistakes and gives sales and accounting teams more reliable invoice information.
Original PR description
task-4213628 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Documents app now keeps a display-layering rule limited to Documents screens instead of letting it affect other areas of Odoo. This prevents visual overlap issues elsewhere while preserving the intended dropdown behavior in Documents.
Original PR description
This PR fixes an issue about a `z-index` CSS property defined in Documents that is affecting the whole back-end and front-end environment as it is not scoped within a Documents related selector. While this CSS is actually needed if you have a dropdown with a `+ X` item at the end to prevent the button from being rendered under the view, it needs to be scoped to Documents only. We also take that opportunity to use the `SCSS` variable related to that `z-index` value. | 18.0 | This PR | |--------|--------| |  |  | task-4270185
The payment form now hides the journal entry shortcut from invoicing-only users. This avoids showing a confusing option that leads to limited accounting details they are not meant to use, while keeping it available for accounting users.
Original PR description
Steps to reproduce: - Install invoicing enterprise (but not accounting) - Register a payment on an invoice - open the form view of the payment When opening the payment form view, if the payment is associated with a journal entry, which can be accessed with the smart button. However, with invoicing enterprise, this button doesn't make sense because the user will only see the "other info" tab of the journal entry. We therefore limit the access to the button only for accounting users. task-4224553
An unused invoice data field was removed from the invoice screen because it could trigger access errors for users with sales permissions but without invoice rights. This prevents those users from being blocked by a field that was not needed for the interface or related behavior.
Original PR description
The field extract_word_ids is in the account move view but raises an access error when someone without invoice rights open the invoice (rights you have when you have some sales rights). As this field is not used in the view or in the associated JS, we can remove it and fix the access rights issues.
New portal users can complete appointment bookings more easily when they do not yet have a phone number. The flow now encourages sign-in, updates missing phone details for logged-in users, and avoids carrying appointment form data into ecommerce in ways that could alter booking details.
Original PR description
As new portal users usually have no phone, let us ease their booking flow while ensuring correct data. Their phone will be updated if logged and not set. Encourage them to sign in with a new Sign In button. Also remove propagation to ecommerce flow so that we make sure appointment form data is kept as is and description remains correct. A test and pot files are adapted accordingly. Task-4207064
The Gantt view now displays the total row title centered as intended. This minor visual correction improves readability and gives users a more polished planning view.
Original PR description
This commit fixes a position issue with the total row title which should be center aligned. task-4251407
The Luxembourg payroll screens now better distinguish which employee information can be edited and which cannot. Contract index values are also shown correctly as non-monetary amounts, reducing confusion during payroll administration.
Original PR description
On the employee, we should clarify the view to tell what is editable or not. On the contract, the index is monetary but shouldn't.
This fixes an appointment payment flow where paid invoices did not always create the related meeting because payments were no longer consistently linked to accounting entries. Meetings are now created when the invoice is posted, whether that happens automatically after payment processing or manually by staff.
Original PR description
ISSUE Introduced in odoo/odoo@01b87f1230beac0568f4e3b1b76e547909506892 the payments are not always linked to account moves. As the invoicing + appointment flow was creating the meeting on reconciliation between the invoice account move line and the payment account move line, using the _invoice_paid_hook method, the flow does not work out of the box anymore. FIX Let us align ourselves to what we do with eCommerce. As the only time we create a link between the invoice and the booking is using the flow, we are creating the invoice in draft at that time, we can consider that posting the invoice is either a manual action, either done automatically when post processing transactions, which would restore the previous flow, and also give more flexibility in the backend, as manually posting the invoice will also create the meeting. Task-4251392
This update fixes user assignment in Quality Point kanban cards and adds clearer help text in the manufacturing planning wizard. It helps teams assign quality responsibilities correctly and better understand planning fields when adding products.
Original PR description
Draft for a mixed bag of MRP bugfixes for post-freeze 18.0. 1. Fixed the responsible assignment button for Quality Points in the kanban view. 2. Added tooltips to the BoM and indirect demand fields of MPS wizard. Task ID: [4154879](https://www.odoo.com/odoo/966/tasks/4154879)
This fixes an internal automated test for the German POS certification module after a related platform change made the old test setting invalid. It helps keep quality checks reliable without changing day-to-day user functionality.
Original PR description
After odoo/odoo@45b90b8b7ce252e1558728f4fc03e52459817565 `test: true` is not a valid tour key anymore
The personal documents section now displays the “Existing file” label correctly beneath the related upload field. This prevents the label from blocking required document uploads and makes the form clearer for employees completing salary contract paperwork.
Original PR description
Before this commit there was an overlap between the "Existing file" label in the "Personal documents" section. The user was not able to click on these required inputs to upload his documents. Visually there was also a problem: the label was aligned weirdly. By replacing the "px-10" and "py-10" by "form-text", there is no overlap anymore, the user can click on the input file field and the label is nicely displayed under the related field with a relevant style (as intended in Bootstrap). <img width="1701" alt="Screenshot 2024-10-18 at 09 46 12" src="https://github.com/user-attachments/assets/fb70f99f-5524-4642-895d-30d515a07405"> 