Thursday, October 31, 2024
28 changes · master
Miscellaneous changes
The SLA success rate was previously being computed using the entire history of closed tickets as the domain. This is contrary to the expected behavior, given the helper text on Odoo and the list view of tickets that opens up if you click the percentage. This commit changes the domain to only consider tickets that were closed in the last 7 days. To reproduce on Runbot, follow the steps laid out here, as the process involves forcing tickets to fail and be older than 7 days closed: htt
Original PR description
The SLA success rate was previously being computed using the entire history of closed tickets as the domain. This is contrary to the expected behavior, given the helper text on Odoo and the list view of tickets that opens up if you click the percentage. This commit changes the domain to only consider tickets that were closed in the last 7 days. To reproduce on Runbot, follow the steps laid out here, as the process involves forcing tickets to fail and be older than 7 days closed: https://www.odoo.com/odoo/49/tasks/4206255 opw-4206255 Forward-Port-Of: odoo/enterprise#71600
## Description Following a32825ee00f2b330d99113f4d8c1488903fe744e, the "Documents" menu-item is hidden when there are no documents in it. The presence of the field `document_count` in the view triggers `_compute_documents`, which is relatively slow for projects with a lot of tasks. It's not worth to incure the cost at each load of this view (which is a hot path) just for hiding a button in a sub-menu. ## Spec Change The menu-item "Documents" is present even if there are no document and you
Original PR description
## Description Following a32825ee00f2b330d99113f4d8c1488903fe744e, the "Documents" menu-item is hidden when there are no documents in it. The presence of the field `document_count` in the view triggers `_compute_documents`, which is relatively slow for projects with a lot of tasks. It's not worth to incure the cost at each load of this view (which is a hot path) just for hiding a button in a sub-menu. ## Spec Change The menu-item "Documents" is present even if there are no document and you have differnet than `'none'` permission on the folder. ## Benchmark Loading "Projects" kanban view with 5 favourite projects, one of which has 1M+ tasks on next.odoo.com | | Before | After | Speedup | |---------------|--------|-------|---------| | Timings (hot) | 10.2s | 790ms | 12.9x | Forward-Port-Of: odoo/enterprise#72394
Version: 17.0+ Issue: In the Deferred Expense Report, there is a missing check for if the `period_end` is before the `period_start` for when the deferred method is 'day'. If the `period_end` is in the same month as selected month of the report, the later column will compute the amount to be negative of the `amount_per_day` times the difference of days. For example, if the end date is 2024-11-04 and we look at the month of November, the later column will display the negative amount of 26
Original PR description
Version: 17.0+ Issue: In the Deferred Expense Report, there is a missing check for if the `period_end` is before the `period_start` for when the deferred method is 'day'. If the `period_end` is in the same month as selected month of the report, the later column will compute the amount to be negative of the `amount_per_day` times the difference of days. For example, if the end date is 2024-11-04 and we look at the month of November, the later column will display the negative amount of 26 days. In this example the amount is expected to be 0. Purpose of this PR: To add an additional condition, if the `period_end` is before the `period_start` then the amount should be 0. opw-4231549 Forward-Port-Of: odoo/enterprise#72644