Thursday, October 31, 2024
3 changes · saas-17.4
Resolved issues and error corrections
This fixes a navigation issue in Discuss where using breadcrumbs could send users back to the first mailbox or thread they opened instead of the one they were viewing. Users can now move between inboxes, channels, and related records with breadcrumbs and return to the expected conversation, reducing confusion and wasted time.
Original PR description
Before this PR, going back to discuss from the breadcrumbs would always redirect to the thread discuss first opened. Steps to reproduce: - Go to `http://localhost:8069/odoo/discuss?active_id=mail_box.inbox`. - Switch to the starred inbox. - Go to the form view of the general channel. - Click on the breadcrumb "Starred". - You are on the Inbox channel. This happens because the action service restores the action. Discuss only has one action: the one that opens the app. Then upon navigation, the current thread is added to the URL. However, the changes in the URL are not taken into account by the action service. This PR fixes the issue by updating the action when the thread changes so that it can be restored. task-4210141
This fix prevents an error when website editors adjust the width of columns in a steps snippet and then click the handle. Editors can now interact with the snippet reliably, avoiding interruptions while building or updating pages.
Original PR description
Steps to Reproduce : 1. Drag and drop a steps snippet 2. Increase the length of any column, in such a way that connector line between the columns in such a way that it overlay handle button. 3. Click on handle button -> A trace-back error occurs Description: When the method is called, it filters out all the overlay elements and finds the first element behind the overlay to apply the click function on it. The issue arises because the method filters out overlay elements and selects the first underlying element to apply a click function on it. However, when the selected element is an SVG or path, which do not support native JavaScript click methods or events, this causes error. This fix resolves the trace-back by filtering out elements that lack native JavaScript click methods or event bindings before calling click. This prevents the error, ensuring smooth interaction with overlay elements. task-3911780
Recurring project tasks now only prepare the next occurrence when one is actually needed. This prevents extra child tasks from being created unnecessarily, reducing clutter and avoiding wasted processing.
Original PR description
Currently, the _create_next_occurence_values method is always called, even if no next occurences need to be created. This is bad, because if the next condition in the code is falsy, we would have created child tasks for nothing since childs are created using copy() in the method to handle recursion. This PR will fix it by checking beforehand if any next occurence should be made, and call _create_next_occurrence_values only if so. task-4269547