Thursday, October 31, 2024
23 changes
1 change
Resolved issues and error corrections
Subscription pages no longer show an invoice amount field that was being used beyond its original purpose. This reduces confusion for users and helps ensure credit limit checks rely on clearer, more appropriate information.
Original PR description
When it was originally introduced on 'sale.order', the 'amount_to_invoice' field was only intended to be used to trigger the credit limit warnings on sale orders and invoices. With time, it came to be used for other unintended purposes, which created confusion regarding the computation method and ensuing fixes that did more harm than good. This is why it was decided to remove all unintended usaged of the field in the views, and rename it to further clarify its meaning. task-4213628
16 changes
Resolved issues and error corrections
This update adds missing internal labels to a website building block used in the numbers list section. It helps the website editor correctly identify and handle that element, reducing small editing inconsistencies without changing the visible page design.
Original PR description
This commit adds missing `data-snippet` and `data-name` attributes to the `s_hr` snippet used in the structure. task-4223179 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
6 changes
Resolved issues and error corrections
This update fixes an issue where the timer button on timesheet rows was hidden when users scrolled horizontally within the 'My Timesheets' grid view. Now, the timer button remains visible regardless of horizontal scrolling, ensuring consistent functionality for users managing their timesheets.
Original PR description
Before this commit, when the user horizontally scrolls in the grid view of `My Timesheets` menu, the grid timer button on each row is hidden, only the row title is kept. This commit keeps the grid timer button is kept when the user horizontally scroll in the grid view of `My Timesheets` menu as it is the case for the row title. task-3378510
Links to uploaded web addresses are no longer treated like downloadable documents in the editor. This keeps the link options consistent, while real document links continue to open in a new window as intended.
Original PR description
Since [1] documents can be uploaded in links. All these attachments are considered as documents, even if they are URLs. The "Open in New Window" option is available for any link, while it should be forced to a new window for documents. This commit introduces the distinction between URL and non-URL attachments: only the non-URL attachments are now considered as documents. In order to make that information available when switching between links: - missing steps of `start` are now included when updating props - sequence of updating props is forced by putting it in a method The "Open in New Window" option is only visible for non-documents. Upon link update, documents are always open in new window and non-document are never download links. [1]: https://github.com/odoo/odoo/commit/cec6ee74de4b904b590d41140d99ae844ed1f15d task-4208243
This fix removes an editor option that could break the layout of the website numbers snippet when changing its column count. It helps website editors avoid accidentally creating a visually broken section.
Original PR description
Changing the amount of columns of this snippet from the dropdown in the editor makes the layout break. This commit prevent the user from doing that. task-4223179 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a flaky automated test for the website slides fullscreen editor by making it wait until the slide link is ready before clicking it. The change helps keep validation runs stable and reduces false failures during development.
Original PR description
The tour "full_screen_web_editor" is failing randomly on the runbot because the step that clicks on the "Home Gardening" slide doesn't open it in fullscreen (as seen in a screenshot of a failing runbot). It is very likely because the fullscreen parameter on the "Home Gardening" link is added afterward in javascript and is not yet present when it is clicked in the test (see function _updateHref of websiteSlidesCourseSlidesList widget). To solve the problem we change the selector that clicks on the "Home Gardening" link to ensure the fullscreen parameter is present in the link. Task-4222573
This fix prevents Point of Sale test tours from failing when a tour is not available in its specific asset bundle. It helps keep automated checks stable without changing day-to-day user behavior.
Original PR description
In Point of Sale module we didn't load all the javascript tour because this module use specific assets bundle. This commit fix the issue by verifying if the tour exist in the registry before trying to get it.
This update fixes an internal automated checkout test for Ecuador website sales after a recent platform change made one test setting invalid. It helps keep quality checks running correctly without changing the customer-facing shopping experience.
Original PR description
After odoo/odoo@45b90b8b7ce252e1558728f4fc03e52459817565 `test: true` is not a valid tour key anymore Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
When users add a link to an image while editing content inside a dialog, the link options now appear in front instead of being hidden behind the dialog. This prevents confusion and makes document layout editing smoother.
Original PR description
Problem: If a dialog is open and the link popover is triggered, it remains behind the dialog, creating further usability issues. Probem: The overlay items are displayed according to their `sequence` attribute, which determines their display order: https://github.com/odoo/odoo/blob/bb20a6d0b3c3a70edbc1f68f560be1f333379ede/addons/web/static/src/core/overlay/overlay_container.js#L65-L67 Solution: Increase the `sequence` value for the `LinkPopover` overlay, ensuring it appears on top of other overlays, including dialogs. Steps to reproduce: 1. Insert an image in the editor in Settings/Configure your document layout/Footer. 2. Click on the image and try to add a link. 3. Observe that the link popover is not visible. opw-4244308
Applying the stretch option to an image in the website editor no longer briefly shows an intermediate image. This creates a smoother editing experience and avoids visual distraction while content is being adjusted.
Original PR description
Before this PR: - An intermediate image was briefly visible when the stretch option was applied, causing a flickering effect. After this PR: - The intermediate image is no longer visible, eliminating the flickering issue. - A cloned image element is used during the processing of the actual image, ensuring that the intermediate image is hidden. task-4206947 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Documents app now keeps a display-layering rule limited to Documents screens instead of letting it affect other areas of Odoo. This prevents visual overlap issues elsewhere while preserving the intended dropdown behavior in Documents.
Original PR description
This PR fixes an issue about a `z-index` CSS property defined in Documents that is affecting the whole back-end and front-end environment as it is not scoped within a Documents related selector. While this CSS is actually needed if you have a dropdown with a `+ X` item at the end to prevent the button from being rendered under the view, it needs to be scoped to Documents only. We also take that opportunity to use the `SCSS` variable related to that `z-index` value. | 18.0 | This PR | |--------|--------| |  |  | task-4270185
The payment form now hides the journal entry shortcut from invoicing-only users. This avoids showing a confusing option that leads to limited accounting details they are not meant to use, while keeping it available for accounting users.
Original PR description
Steps to reproduce: - Install invoicing enterprise (but not accounting) - Register a payment on an invoice - open the form view of the payment When opening the payment form view, if the payment is associated with a journal entry, which can be accessed with the smart button. However, with invoicing enterprise, this button doesn't make sense because the user will only see the "other info" tab of the journal entry. We therefore limit the access to the button only for accounting users. task-4224553
An unused invoice data field was removed from the invoice screen because it could trigger access errors for users with sales permissions but without invoice rights. This prevents those users from being blocked by a field that was not needed for the interface or related behavior.
Original PR description
The field extract_word_ids is in the account move view but raises an access error when someone without invoice rights open the invoice (rights you have when you have some sales rights). As this field is not used in the view or in the associated JS, we can remove it and fix the access rights issues.
The Gantt view now displays the total row title centered as intended. This minor visual correction improves readability and gives users a more polished planning view.
Original PR description
This commit fixes a position issue with the total row title which should be center aligned. task-4251407
The Luxembourg payroll screens now better distinguish which employee information can be edited and which cannot. Contract index values are also shown correctly as non-monetary amounts, reducing confusion during payroll administration.
Original PR description
On the employee, we should clarify the view to tell what is editable or not. On the contract, the index is monetary but shouldn't.
This update fixes user assignment in Quality Point kanban cards and adds clearer help text in the manufacturing planning wizard. It helps teams assign quality responsibilities correctly and better understand planning fields when adding products.
Original PR description
Draft for a mixed bag of MRP bugfixes for post-freeze 18.0. 1. Fixed the responsible assignment button for Quality Points in the kanban view. 2. Added tooltips to the BoM and indirect demand fields of MPS wizard. Task ID: [4154879](https://www.odoo.com/odoo/966/tasks/4154879)
This fixes an internal automated test for the German POS certification module after a related platform change made the old test setting invalid. It helps keep quality checks reliable without changing day-to-day user functionality.
Original PR description
After odoo/odoo@45b90b8b7ce252e1558728f4fc03e52459817565 `test: true` is not a valid tour key anymore
The personal documents section now displays the “Existing file” label correctly beneath the related upload field. This prevents the label from blocking required document uploads and makes the form clearer for employees completing salary contract paperwork.
Original PR description
Before this commit there was an overlap between the "Existing file" label in the "Personal documents" section. The user was not able to click on these required inputs to upload his documents. Visually there was also a problem: the label was aligned weirdly. By replacing the "px-10" and "py-10" by "form-text", there is no overlap anymore, the user can click on the input file field and the label is nicely displayed under the related field with a relevant style (as intended in Bootstrap). <img width="1701" alt="Screenshot 2024-10-18 at 09 46 12" src="https://github.com/user-attachments/assets/fb70f99f-5524-4642-895d-30d515a07405"> 
This update corrects a technical issue related to how sales order item data is processed within the Odoo Enterprise system. By using a lambda function, the system now correctly handles inheritance and returns the expected data format (a list), ensuring accurate sales order item calculations. This improves the reliability of sales reporting.
Original PR description
Since domain method for the Sales Order Item field is not harcoded anymore, the inheritance in this module is now considered, so it needs to be adapted to work correctly with the expected value, i.e. returning a list instead of a string. [FIX] helpdesk_sale_timesheet: unharcode domain method of SO line field Since domain method of the Sales Order Item field is set using the actual class method instead of a lambda, it is not possible to inherit that method when inheriting the model. This issue is fixed by using a lambda function to call the domain method. Forward-Port-Of: odoo/enterprise#72931
This update fixes a bug in the recruitment test that prevented accurate skill detection from OCR results. The changes ensure the test runs correctly after all modules are installed and improve the accuracy of skill matching by refining the search pattern. This enhances the reliability of candidate skill identification.
Original PR description
- Added 'post_install' and '-at_install' tags to ensure the test is executed after all modules are installed, necessary for `test_skill_search_on_ocr_results` to run fully. - Fixed the test to detect when no skills were being added to the applicant, even though some should have been. - Updated the skills search regex: replaced `\s` tags with `\b` tags to correctly detect the first and last words in `ocr_tokens`.
This update resolves a bug where certain fields in web studio reports weren't translating correctly when editing invoices. The issue stemmed from how the system handled indentation in the report XML, leading to a mismatch between the edited content and the translation keys. This ensures all reports, regardless of language, display accurate translations.
Original PR description
Steps to reproduce ================== - Install account_accountant,web_studio - Go to an invoice - Set the partner's language to French - Print the Invoice without Paiement PDF - Open studio - Edit that report - Add a new text below the invoice header - Save the report and exit studio - Print the same report => Some fields aren't translated Cause of the issue ================== When editing the report, ```xml <strong>Due Date:</strong><br/> ``` is converted to ```xml <strong>Due Date:</strong> <br/> ``` This no longer matches the translation key. opw-3730267
This update resolves a bug where the mass depreciation action incorrectly recalculated posted assets. The fix restricts the action to only draft assets, aligning with existing functionality and preventing unnecessary calculations. This ensures accurate depreciation reporting.
Original PR description
As of today, the action_account_asset_compute_depreciations server action allows to recompute the board on posted assets by calling compute_depreciation_board.
There is two issues with that:
- compute_depreciation_board shouldn't be called on assets that could already have moves without providing a date
- This action should reflect what can be done on the form view (only applies to draft)
The easy fix is to update the action to only affect draft entries.
Task id # 4297606This update resolves an issue where timesheet grids weren't correctly displaying times due to time zone discrepancies. This fix ensures accurate time representation for timesheet entries, improving data reliability. It's a follow-up to a previous bug fix.
Original PR description
small fix related to following bugfix: https://github.com/odoo/enterprise/pull/72526