Monday, November 4, 2024
6 changes · 18.0
Resolved issues and error corrections
The sales screens no longer show the internal “amount to invoice” field, which was only meant to support credit limit checks. This reduces confusion and prevents users from relying on a value that was not designed for day-to-day invoicing decisions.
Original PR description
When it was originally introduced on 'sale.order', the 'amount_to_invoice' field was only intended to be used to trigger the credit limit warnings on sale orders and invoices. With time, it came to be used for other unintended purposes, which created confusion regarding the computation method and ensuing fixes that did more harm than good. This is why, for the master version, it was decided to remove all unintended usages of the field in the views, and rename it to further clarify its meaning. Here, in version 18, we are simply making the fields invisible. task-4213628 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Refreshing the attendee selection screen in the event registration desk no longer triggers an error. This improves reliability for staff managing event check-ins and avoids interruptions during registration workflows.
Original PR description
**How to reproduce:** - Navigate to an event. - Click on 'Registration Desk'. - Click on 'Select Attendee'. - Refresh the browser window. Ref: https://tinyurl.com/y2hxjbew **Technical reason:** In the web, there's an if condition that checks if 'display_name' is in 'res', but it doesn't account for the possibility that 'res' might be undefined. **After this commit:** The traceback will be resolved. Task-4272942
This fixes an unreliable automated test for the Mail app's unread message banner. It helps keep quality checks stable by verifying the expected scrolling behavior directly instead of depending on timing-sensitive scroll events.
Original PR description
The `scroll to the first unread message (slow ref registration)` test checks that clicking the unread message banner scrolls to the first unread message, even with delayed message loading. Previously, the test expected three `scrollend` events: - Scroll to top - Scroll to unread message - Minor scroll from highlight effect However, the highlight scroll sometimes fails to trigger if it starts before the second scroll ends, causing a missing `scrollend`. This PR resolves the issue by enhancing the `isInViewportOf` helper to listen for scroll events and assert directly, without relying on specific steps. runbot-69429739
This fixes a visual issue in the Project form where an unwanted extra line appeared near the Share Project button when timesheet warnings were shown. The change improves the form's appearance without changing how projects or timesheets work.
Original PR description
Before this commit, an extra line is displayed between the `Share Project` button and the form sheet. This commit removes the extra line by altering the group tag contained the timesheet warning when the timesheet feature is enabled in the project and no active analytic account is set on the project. The `group` tag is only supported in the `sheet` tag and not outside, that's why the extra line is appeared. task-4286488
This fixes the placement of the dynamic placeholder and emoji buttons in mailing settings. The buttons now appear beside the preview field as expected, making the editing experience clearer and less confusing.
Original PR description
Steps to reproduce =============== 1. Go to Email Marketing and open any mailing. 2. Go to Settings of the mailing inside notebook. -> The dynamic placeholder button and emoji icon is next to the medium but it should be after preview field. Issue =============== We are using position absolute for the container of the button but as the nearest positioned ancestor is the sheet itself it is placed to the right of the sheet. After this commit =============== The buttons for the preview field will be next to the preview field. Task-4244780
The rental order status label now lines up correctly in the sales rental order view. This small visual fix improves readability and makes the order screen look more polished for users.
Original PR description
Issue: Rental order status label are not aligned Fix: Added align-item-end to footer for sale_renting