Monday, November 4, 2024
12 changes
6 changes
Resolved issues and error corrections
The sales screens no longer show the internal “amount to invoice” field, which was only meant to support credit limit checks. This reduces confusion and prevents users from relying on a value that was not designed for day-to-day invoicing decisions.
Original PR description
When it was originally introduced on 'sale.order', the 'amount_to_invoice' field was only intended to be used to trigger the credit limit warnings on sale orders and invoices. With time, it came to be used for other unintended purposes, which created confusion regarding the computation method and ensuing fixes that did more harm than good. This is why, for the master version, it was decided to remove all unintended usages of the field in the views, and rename it to further clarify its meaning. Here, in version 18, we are simply making the fields invisible. task-4213628 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Refreshing the attendee selection screen in the event registration desk no longer triggers an error. This improves reliability for staff managing event check-ins and avoids interruptions during registration workflows.
Original PR description
**How to reproduce:** - Navigate to an event. - Click on 'Registration Desk'. - Click on 'Select Attendee'. - Refresh the browser window. Ref: https://tinyurl.com/y2hxjbew **Technical reason:** In the web, there's an if condition that checks if 'display_name' is in 'res', but it doesn't account for the possibility that 'res' might be undefined. **After this commit:** The traceback will be resolved. Task-4272942
This fixes an unreliable automated test for the Mail app's unread message banner. It helps keep quality checks stable by verifying the expected scrolling behavior directly instead of depending on timing-sensitive scroll events.
Original PR description
The `scroll to the first unread message (slow ref registration)` test checks that clicking the unread message banner scrolls to the first unread message, even with delayed message loading. Previously, the test expected three `scrollend` events: - Scroll to top - Scroll to unread message - Minor scroll from highlight effect However, the highlight scroll sometimes fails to trigger if it starts before the second scroll ends, causing a missing `scrollend`. This PR resolves the issue by enhancing the `isInViewportOf` helper to listen for scroll events and assert directly, without relying on specific steps. runbot-69429739
This fixes a visual issue in the Project form where an unwanted extra line appeared near the Share Project button when timesheet warnings were shown. The change improves the form's appearance without changing how projects or timesheets work.
Original PR description
Before this commit, an extra line is displayed between the `Share Project` button and the form sheet. This commit removes the extra line by altering the group tag contained the timesheet warning when the timesheet feature is enabled in the project and no active analytic account is set on the project. The `group` tag is only supported in the `sheet` tag and not outside, that's why the extra line is appeared. task-4286488
This fixes the placement of the dynamic placeholder and emoji buttons in mailing settings. The buttons now appear beside the preview field as expected, making the editing experience clearer and less confusing.
Original PR description
Steps to reproduce =============== 1. Go to Email Marketing and open any mailing. 2. Go to Settings of the mailing inside notebook. -> The dynamic placeholder button and emoji icon is next to the medium but it should be after preview field. Issue =============== We are using position absolute for the container of the button but as the nearest positioned ancestor is the sheet itself it is placed to the right of the sheet. After this commit =============== The buttons for the preview field will be next to the preview field. Task-4244780
The rental order status label now lines up correctly in the sales rental order view. This small visual fix improves readability and makes the order screen look more polished for users.
Original PR description
Issue: Rental order status label are not aligned Fix: Added align-item-end to footer for sale_renting
6 changes
Resolved issues and error corrections
This update resolves an issue where the sign generation process would sometimes produce incorrect results after switching between drawing and auto-result modes. The fix ensures the dialog has sufficient time to load properly before mode changes, preventing this problem. This improves the reliability and user experience of the sign generation feature.
Original PR description
We wait for the next tick to leave the dialog enough time to load properly before changing the mode to draw, this way we avoid to have the canva with the auto result after changing to draw mode.
This update resolves a technical error that prevented users from confirming invoices when using the new loyalty program and Taxcloud integration. The issue stemmed from an incorrect field check within the invoice processing logic. This fix ensures smooth invoice confirmation for transactions utilizing these features.
Original PR description
Steps: - Install sales app. - Enable loyalty and taxclould. - Create a loyalty program and a rule for a product. - Enable Taxclould API on fiscal position. - Create SO and set that fiscal position on SO - Add that product with loyalty program and apply that promotion on so - Confirm delivery and Create Invoice. - Try to confirm invoice. Issue: - Traceback. Cause: - Wrong field check in condition on Invoice lines. Fix: - Update field to check right condition. opw-4180034 Forward-Port-Of: odoo/enterprise#72696
This update resolves an issue where Avalara was returning generic error messages due to a reason field being too short. By ensuring the reason field has the correct length, we prevent these errors and improve the reliability of invoice processing for Brazilian e-commerce.
Original PR description
The error Avalara returns for this is too generic to be useful: Rejeição: Evento não atende o Schema XML específico We found out by contacting Avalara support that the error in this case was a reason that was too short. Let's prevent this from re-occuring. opw-4298175
This update resolves a crash within Odoo's Studio application when navigating to edit one-to-many records. The fix prevents the system from incorrectly interpreting a default value as an invalid record ID, eliminating the error and ensuring Studio functions smoothly. The change ensures Studio users can reliably edit forms with related records.
Original PR description
…anys Have a ir.default that sets one line into a one2many on some models. In studio, edit the form view of the main model, then navigate to edit the one2many, with the ir.default having been triggered (there is one virual line in the one2many). Before this commit there was a crash because "false" is not a valid id for the staticlist. After this commit, there is no crash, and the virtual record doesn't appear. opw-4289233
This update resolves a display error in the map view that incorrectly prompted users to set up their Mapbox token, even when it was already configured. The issue stemmed from a filtering problem when tasks lacked customer data, causing an error during routing. Adding a 'partner' filter ensures accurate routing calculations.
Original PR description
When fetching the Routing in project->task, the map view shows the error "To get routing on your map, you first need to set up your Mapbox token. -> Set up token" even if they already have the token…
When fetching the Routing in project->task, the map view shows the error "To get routing on your map, you first need to set up your Mapbox token. -> Set up token" even if they already have the token set up. This happens when, for example: if you have 3 tasks where 2 of them have the customer field filled and one doesn't. The function _fetchRoute tried to filter out the records that don't have the latitude/longitude. But, here, since one of the records doesn't have a partner, when it's trying to look into partner.partner_latitude, it throws an error. After the error, mapBoxToken is set to '' in _partnerFetching, and called _openStreetMapAPI() resulting in displaying the error, "to get routing on your map, you first need to set up your Mapbox token." So, adding record.partner in the filter will help filter out the records that don't have partner. To Reproduce on Runbot: 1. Set up Mapbox token 2. Go to Project->Task 3. Create 3 Tasks ( 2 with customer and 1 without customer ) 4. Go to the map view and it'll display the error. opw-3682829 Forward-Port-Of: odoo/enterprise#69047 Forward-Port-Of: odoo/enterprise#55580
This update resolves a technical error that prevented users from successfully exporting XAF reports (like the General Ledger) when using the 'Export' function. The fix ensures the report content is correctly saved as a file attachment, resolving a 'TypeError' that was blocking the export process.
Original PR description
With NL Company Open "General Ledger" Hit Save > Select XAF > Click 'Export' Issue: "TypeError: argument should be a bytes-like object or ASCII string, not 'generator'" This occurs because when calling `export_report` we save the attachment and we need the actual file content. opw-3820739 Forward-Port-Of: odoo/enterprise#72294