Tuesday, November 5, 2024
10 changes · 17.0
Resolved issues and error corrections
This update fixes an issue where renewed subscriptions were incorrectly forecasting stock decreases. Now, the stock forecast accurately reflects only the new subscription created during the renewal process, ensuring more precise inventory management. This change improves forecast accuracy and reduces potential overstocking.
Original PR description
Steps to reproduce: - New product > Storable; Recurring; Edit 'On Hand Quantity' to 10 - New subscription > Add your product > Confirm - Create Invoice > Confirm > Back to sub - View forecast on order line > 1 reserved; 1 forecasted for next period (This is correct, the subscription is ongoing) - Renew > Confirm > View forecast - 1 reserved for original sub (OK); 2 forecasted for next period This is wrong because renewed subscriptions should no longer have recurring invoices, meaning there is no reason to forecast a stock decrease for them. i.e here it should only forecast 1 unit for the next period corresponding to our new subscription (Created by renew). Prior to 17.0 a storable product cannot also be recurring, so this issue is irrelevant there. opw-4239989
This update resolves a confusing issue in the Odoo Web Studio where users weren't correctly controlling the visibility of certain fields based on group membership. Previously, toggling a group visibility setting had no effect. Now, the system properly handles 'not' group attributes, ensuring accurate field visibility and a consistent user experience.
Original PR description
Have a node that goes: ```xml <div groups="!module.some_group" /> ``` Before this commit, this case was not handled and that not-group was just ignored. This created confusion as the node, when the user was part of the group, would be invisible, the checkbox invisible would be ticked, and uniticking it had no effect. After this commit, we handle the case, with a second selector in the studio sidebar. opw-4273853
This update fixes an issue where the 'Last Evaluation' button in the employee module incorrectly displayed the current date instead of the last appraisal date. Now, the button accurately shows the date of the most recent completed appraisal or indicates an ongoing appraisal if one exists, ensuring accurate appraisal tracking.
Original PR description
The issue: When accessing the record of any employee in the employee module, we have the smart button "Last evaluation", and that button is considering the current date instead of the evaluation date of the most recent evaluation. How to reproduce the issue: -In the app employee on any employee, clic on the Request Appraisal button. -Confirm the appraisal. -Go back on the employee page. Explanation: The behavior of this smartbutton was changed in 17.2 (https://github.com/odoo/enterprise/commit/ab01d6cbb4e2add8b6736f92c036a537bea57005). After this fix for version 17.0, the behavior will be as follows: -If there is an ongoing appraisal, the smartbutton display "Ongoing Appraisal" with the number of ongoing appraisals. -If there is no ongoing appraisal, the smart button will display the date of the most recent completed appraisal, which corresponds to the date when that last appraisal was completed. opw-4180982
This update corrects a small bug in the way the system compares financial amounts within the asset management module. The previous logic incorrectly used '1' as the threshold for comparison, leading to inaccurate calculations. This fix ensures that amount comparisons are accurate, improving the reliability of asset tracking.
Original PR description
To check that an amount is greater than another one, compare_amounts need to be bigger than 0 not 1 Forward-Port-Of: odoo/enterprise#73159
This update fixes a bug preventing filter options in the Partner Ledger report (Kontoudtog) from being translated into Danish. The fix ensures that all report labels, including filter selections, are correctly localized for international users. This improves the user experience for Danish-speaking customers.
Original PR description
The problem: In the accounting reports, filter options were not being translated. Steps to reproduce: Install and change to the Danish language. Navigate to Accounting > Reporting > Partner ledger (Kontoudtog) Activate the filter "Only Show Unreconciled Entries" (Vis kun ikke udlignede posteringer) Generate the PDF report. Why it was happening: The array `extra_options` was built dynamically by concatenating raw python strings to it. Those raw strings will not be translated. The fix: Now, we create local variables for each string, using the syntax `<t t-set="label_raw_string">Raw String</t>` which makes the string label_raw_string translatable, then we append it to `extra_options`. opw-4213562
This update resolves a technical issue that prevented users from correctly calculating payslips when adding new worked days to draft payslips. The fix ensures that the system properly recomputes payslip amounts when editing, preventing a traceback error. This ensures accurate payroll processing for all employees.
Original PR description
Steps --- * Create a payslip for an Employee with a contract (e.g. Anita Oliver) (*Payroll > Payslips > All Payslips > New*) * From the *Edit Payslip Lines* action, try to add a new worked day line (first list) with a non 0 amount * *Validate Edition* => Traceback Cause --- When saving new worked days lines, we try to recompute the amount of the *Basic Salary* payslip line, but if the payslip is still a **draft** it was never computed, and so the action we are calling does not exist. task-4191349 Forward-Port-Of: odoo/enterprise#71373
This update resolves an issue where the preparation display showed all orders, even after closing and reopening the session, leading to potential performance problems. Now, the display only shows currently active orders, improving the system's responsiveness and stability.
Original PR description
Before this commit, if a user didn't remove the prepared orders from the preparation display, all orders would be displayed even after closing and opening a new session. This could cause rendering issues due to the large number of orders. opw-4295258
This update fixes a potential issue where POS order tax information wasn't consistently matched, leading to inaccuracies in GST reports. By sorting tax IDs before comparison, the system now ensures accurate matching regardless of the original order, improving report reliability.
Original PR description
Before this PR: - POS order lines were matched without sorting `tax_ids`, which could cause mismatches when the tax IDs were in a different order between `details_pos_line` and `account_move_line`. After this PR: - POS order lines are matched by comparing `tax_ids` in sorted order, ensuring consistent matching regardless of the order of tax IDs.
This update fixes an issue where rental order descriptions didn't automatically update when the rental start and end dates were changed in the cart. The system now recomputes the description after date modifications, ensuring accurate order details are displayed to the customer. This improves the user experience for rental orders.
Original PR description
Problem: When rental dates are changed in the cart, the update occurs via an API call, which doesn't trigger the `_onchange_rental_start_date` and `_onchange_rental_return_date` methods. Additionally, we cannot add `rental_return_date` and `rental_start_date` as dependencies for `_compute_name` as outlined in this [commit](https://github.com/odoo/enterprise/commit/de5f3c7521d839e7549f5d44c7832e610fad7f29). Solution: Recompute the description after changing the dates in `_cart_update_renting_period` Steps to reproduce: - Add any rental product to the cart. - On the cart page, modify the rental start and end dates. - The order description does not update to reflect the new dates. opw-4259443
This update fixes an error in the Pakistani Profit and Loss report that incorrectly displayed 'Other Income' as a negative value. The fix ensures that 'Other Income' is correctly added to the 'Gross Profit' section, accurately reflecting the company's financial performance. This resolves a discrepancy between the PK-specific report and the standard Profit & Loss report.
Original PR description
**Steps to reproduce:** - Install l10n_pk_reports - Switch to a Pakistani company (e.g. PK Company) - Create a Journal entry crediting an account of "Other Income" type (e.g. 3112003 Misc Income) - Post the journal entry - Go to "Accounting / Reporting / Statement Reports / Profit and Loss" - Select "Profit and Loss (PK)" report **Issue:** The created journal entry is negative in the "Other Income" section and its value is subtracted from "Gross Profit" section, reducing "Profit of the Year" section, which is not correct. On the other hand, if the normal "Profit and Loss" report is selected, the created journal entry is positive and its value is added to "Gross Profit" section, increasing "Net Profit" section, which is correct. opw-4185212 Forward-Port-Of: odoo/enterprise#72378