Tuesday, November 5, 2024
1 change · 18.0
Code cleanup and technical improvements
This update reorganizes how automated guided tours report success or failure, making the underlying code easier to maintain and reason about. It also removes an obsolete cleanup step, reducing the chance of minor technical errors during tour execution.
Original PR description
In this commit, we move the tour_automatic callback in the tour_service to the tour_automatic class. This allows for clearer handling of tour error or success messages. We take advantage of this commit to remove a small error (clearTimeout(this._timeout)) in the tour_step_automatic where this._timeout no longer exists. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr