Tuesday, November 12, 2024
3 changes · saas-17.4
Resolved issues and error corrections
Global discounts in Point of Sale now correctly account for tax-included tax groups when calculating the discount base. This prevents under-discounting orders where product prices already include multiple taxes, improving pricing accuracy at checkout.
Original PR description
When applying a global discount on an order that contains lines using tax group, the tax amount was always ignored by the discount. Steps to reproduce: ------------------- * Create a tax group with 2 taxes included in price (e.g 15% and 5%) * Create a product with a price of 120€, the price without tax should be 99.38€ * Open PoS and add the product * Add a global discount of 10% > Observation: As all the taxes are included in price the discount should be 12€ (10% of 120) but it is not Why the fix: ------------ We now get the base by getting the total with tax of the line and substracting the tax amount that comes from that that are not included in price opw-4289157
This update brings the spreadsheet engine to its latest version and fixes several issues affecting chart display, pivot tables, and Excel exports. Users should see more accurate pie charts, clearer chart settings, and better handling of broken spreadsheet references when working with or exporting spreadsheets.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/2eb3f1cf2 [REL] 17.4.11 Task: 0 https://github.com/odoo/o-spreadsheet/commit/26a46e9c1 [FIX] charts: do not show zero…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/2eb3f1cf2 [REL] 17.4.11 Task: 0 https://github.com/odoo/o-spreadsheet/commit/26a46e9c1 [FIX] charts: do not show zero values in pie charts Task: 4277144 https://github.com/odoo/o-spreadsheet/commit/360550579 [FIX] pivot: skip cells on manipulated pivot array formulas Task: 4292134 https://github.com/odoo/o-spreadsheet/commit/595963de3 [FIX] xlsx: convert #REF at export to xlsx Task: 4207052 https://github.com/odoo/o-spreadsheet/commit/c6a75e60c [FIX] parser: inconsistent handling of #REF Task: 4207052 https://github.com/odoo/o-spreadsheet/commit/1aa1b2c99 [FIX] charts: correct stacked checkbox label Task: 4251670 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Fixed an issue that caused the Production Analysis report to crash when work order features were not installed. Businesses can now open manufacturing reporting without needing extra optional modules, improving reliability for standard manufacturing setups.
Original PR description
Currently, An error occurs while opening a 'Production Analysis' report, and the module name `mrp_workorder` is not installed. Steps To Reproduced: - Install ```mrp_account_enterprise```. - Uninstall…
Currently, An error occurs while opening a 'Production Analysis' report, and the module name `mrp_workorder` is not installed. Steps To Reproduced: - Install ```mrp_account_enterprise```. - Uninstall ```mrp_workorder```. - Open Manufacturing / Reporting / Production Analysis and an error is generated. ``` UndefinedColumn: column wc.employee_costs_hour does not exist LINE 248: * wc.employee_costs_hour * op.employee_ratio ``` An error occurs when the system tries to access fields like `employee_cost`, and `employee_costs_hour` at [1]. but it is unavailable as the module `mrp_workorder` has not been installed. These fields are defined in it. Link [1]: https://github.com/odoo/enterprise/blob/baba978bca701c589eb0d45527275b6275eec5c5/mrp_account_enterprise/reports/mrp_report.py#L206 To resolve this issue, Move the `_join_expected_component_cost_unit` method into bridge module `mrp_workorder_hr_account`, Additionally, Create dummy methods to provide a default value for fields([2]) that are not working and override these methods in the bridge module to return the correct values. Link [2]: https://github.com/odoo/enterprise/blob/baba978bca701c589eb0d45527275b6275eec5c5/mrp_account_enterprise/reports/mrp_report.py#L64-L78 Sentry-5794503324