Wednesday, November 13, 2024
6 changes · master
Code cleanup and technical improvements
This pull request reorganizes the underlying engine used to run automated guided flows and tests across several Odoo apps. The change should make these flows easier to maintain and more reliable over time, without introducing a direct visible change for everyday users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update renames internal unit-of-measure fields so sales, purchasing, pricing, and reporting records use consistent naming. The change reduces custom workarounds and makes future shared processes, such as EDI handling, easier to build and maintain without changing day-to-day business workflows.
This update reorganizes internal test helper tools and clarifies their naming so development teams can write and maintain automated tests more reliably. It also fixes timing and service-mocking issues that could cause small inconsistencies in test results, reducing noise and improving confidence in quality checks.
Original PR description
This PR moves some helper functions away from the main 'web_test_helpers' file and rename the `step` and `assertStep` functions to reduce confusion. Enterprise: https://github.com/odoo/enterprise/pull/73569 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update aligns enterprise modules with a broader naming cleanup by changing product unit references to a clearer, consistent field name. It reduces technical inconsistency across sales, rental, subscription, delivery, field service, purchasing, stock, and accounting-related workflows without changing business functionality.
Original PR description
This update reorganizes and renames internal testing helper functions so automated tests are easier to understand and maintain. It affects test code only, helping developers reduce confusion without changing business workflows or user-facing behavior.
Original PR description
This PR moves some helper functions away from the main 'web_test_helpers' file and rename the step and assertStep functions to reduce confusion. Community: https://github.com/odoo/odoo/pull/186636
This draft change appears to reorganize internal code and automated walkthroughs for field service reporting, external tax sales flows, and document signing. It is not expected to change day-to-day behavior for users, but should help keep these areas easier to maintain and test.
Original PR description
Purpose of this PR to have name of field according to guidelines so it can be consistent with other models and we don't have to add some hacks if they are not like in invoice lines `product_uom_id`…
Purpose of this PR to have name of field according to guidelines so it
can be consistent with other models and we don't have to add some hacks
if they are not like in invoice lines `product_uom_id` is properly named
according to guidelines and in other modules it's not so if we want to
add generic method which will work for invoice lines and sale order lines
then we have to remove `product_uom_id` from data and add `product_uom`
and it can get ugly if we want to do more complex operations.
This commit rename field `product_uom` on SOL to `product_uom_id` to be
consistent with other models specifically with `account.move.line` in order
to properly extract common logic from EDI for invoice and have consistent
name across file so it'll make future code simpler.
We also have to change purchase line `product_uom` field to `product_uom_id`
because in generic accounting code they create sale or purchase order
depending on condition so Sale order line and Purchase order line should
have same field names also there is task to add EDI import for purchase
order 4286172 so it can be useful for that task also
Following uom field names updated to follow guideline and proper naming:
(Related to SOL and POL `product_uom` field)
- Rename `product_uom` to `product_uom_id` in {`sale.order.line`,
`purchase.order.line`, `sale.report`, `purchase.report` , `project.milestone` ,
`product.supplierinfo`} models.
- Rename `product.pricelist.item` model's field `product_uom` to
`product_uom_name` as it was related to product's `uom_name` field and
it was char type field.
task-4206350
See also:
https://github.com/odoo/enterprise/pull/73293
https://github.com/odoo/upgrade/pull/6732This commit adept changes done in community PR to rename `product_uom` field to `product_uom_id` also rename related fields in following models: - sale.subscription.report - sale.rental.schedule - sale.rental.report task-4206350 See also: https://github.com/odoo/odoo/pull/186250 https://github.com/odoo/upgrade/pull/6732