Odoo Changelog — 2024-11-13

Wednesday, November 13, 2024

3 changes · saas-17.4

Bug Fixes(3)

Resolved issues and error corrections

[FIX] website_sale: fix discount display

Coresaas-17.4website_saleMedium

The online shop now shows the original crossed-out price at checkout whenever a pricelist rule changes the final product price. This makes discounts clearer for shoppers and keeps the cart display consistent with the product page.

Original PR description

Steps:
- Install Ecom.
- Add a product in pricelist with fomula type.
- Go to Ecom.
- Product old and new price displaying with old in strike out.
- Go to check out.

Issue:
- Only new product price is displaying as formula and fixed type rule directly change value of product on SOL and discount type add discount on SOL.

Cause:
- Only checked discount on SOL to display old price.

Fix:
- Check price before discount and after discount to display old price if both are not same.

opw-4277128

#ecommerce#discounts#pricing#checkout

[FIX] mail: enable push notifications in iOS PWA

PR #187038

Coresaas-17.4mailMedium

This fix adjusts when Odoo shows the option to enable push notifications on iPhones and iPads. It prevents confusing or persistent notification prompts in Safari while still allowing users who installed the Odoo web app to enable notifications properly.

Original PR description

Follow-up of https://github.com/odoo/odoo/pull/178057

PR above fixed an issue of persistent notification in messaging menu in iOS, due to push notifications being only available through PWA.

At the time of the fix, installing PWA apps on iOS had necessarily push notification enabled. However this no longer seems to be the case: PWA apps on iOS must now explicitly asks for enabling push notifications. This is also a necessary step in order for the PWA apps to be shown in iOS Settings > Notifications.

This commit fixes the issue by not showing button to enable push notifications specifically on iOS outside of app. That way there's no persistent notification on Safari while push notifications can still be enabled.

Extra notes:
- iOS requests for push notifications seem to require HTTPS, otherwise they are necessarily blocked.
- iOS 17 does not show the dialog to accept or deny push notifications. This is likely an iOS bug that has apparently been fixed with iOS 18.

#ios#pwa#push-notifications#notifications

[FIX] CRM: Assign leads manually

PR #185529

Coresaas-17.4crmMedium

Sales teams can now manually assign all available leads, even if those leads were created more than seven days ago. This prevents older leads from being skipped and helps avoid missed sales follow-ups.

Original PR description

When manually assigning leads to salespeople in a team, only leads created in the past 7 days were being assigned. If all leads were created more than 7 days ago, they would not be assigned, causing missed assignments.

To fix this, the parameter `creation_delta_days` is now set to 0 during manual assignment, bypassing the 7-day creation filter. This ensures that all leads, regardless of creation date, are assignable manually. https://github.com/odoo/odoo/blob/saas-17.4/addons/crm/models/crm_team.py#L441#L445

Steps to reproduce:
1. Go to CRM settings and activate `Rule-Based Assignment` and `Leads`.
2. Navigate to CRM Configuration > Sales Teams.
3. Create a new sales team with `Leads` active.
4. Add a member to the team, save, and try to assign leads.

Expected behavior:
All leads, regardless of creation date, should be assignable when manually assigned.

opw-4217088

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#lead assignment#sales teams#CRM

Steps: - Install Ecom. - Add a product in pricelist with fomula type. - Go to Ecom. - Product old and new price displaying with old in strike out. - Go to check out. Issue: - Only new product price is displaying as formula and fixed type rule directly change value of product on SOL and discount type add discount on SOL. Cause: - Only checked discount on SOL to display old price. Fix: - Check price before discount and after discount to display old price if both are not same. opw-4277128

Follow-up of https://github.com/odoo/odoo/pull/178057 PR above fixed an issue of persistent notification in messaging menu in iOS, due to push notifications being only available through PWA. At the time of the fix, installing PWA apps on iOS had necessarily push notification enabled. However this no longer seems to be the case: PWA apps on iOS must now explicitly asks for enabling push notifications. This is also a necessary step in order for the PWA apps to be shown in iOS Settings > Notifications. This commit fixes the issue by not showing button to enable push notifications specifically on iOS outside of app. That way there's no persistent notification on Safari while push notifications can still be enabled. Extra notes: - iOS requests for push notifications seem to require HTTPS, otherwise they are necessarily blocked. - iOS 17 does not show the dialog to accept or deny push notifications. This is likely an iOS bug that has apparently been fixed with iOS 18.

When manually assigning leads to salespeople in a team, only leads created in the past 7 days were being assigned. If all leads were created more than 7 days ago, they would not be assigned, causing missed assignments. To fix this, the parameter `creation_delta_days` is now set to 0 during manual assignment, bypassing the 7-day creation filter. This ensures that all leads, regardless of creation date, are assignable manually. https://github.com/odoo/odoo/blob/saas-17.4/addons/crm/models/crm_team.py#L441#L445 Steps to reproduce: 1. Go to CRM settings and activate `Rule-Based Assignment` and `Leads`. 2. Navigate to CRM Configuration > Sales Teams. 3. Create a new sales team with `Leads` active. 4. Add a member to the team, save, and try to assign leads. Expected behavior: All leads, regardless of creation date, should be assignable when manually assigned. opw-4217088 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr