Friday, November 15, 2024
20 changes · 17.0
Resolved issues and error corrections
This fixes an error that appeared when users tried to insert media while editing a text block on a website page. The website editor now handles cases where no existing media is selected, allowing users to open the media dialog without interruption.
Original PR description
Steps to reproduce: - In Website edit mode. - Drag and drop a "Text" block into the page. - Click on the first paragaph of the "Text" block. - click the "Insert media" button of the text toolbar. - A traceback occurs. The bug was introduced in commit [1], where we checked that "this.props.media" was not undefined before calling the "closest" function on it. However, this was incorrect because, in cases where "this.props.media" was false, the "closest" function was still called, causing the traceback. With this fix, the "closest" function is not called if "this.props.media" is false. [1]: https://github.com/odoo/odoo/commit/625c1aa71e17882848dd827f3be6162e49cbc8ca opw-4335833 opw-4328280 opw-4334279 opw-4328490 opw-4334012 opw-4332500 opw-4332028 opw-4332684 opw-4329687 opw-4331635 opw-4331371 opw-4331287 opw-4332437 opw-4331144 opw-4329646 opw-4328364 opw-4323197 opw-4325959 opw-4322945
This fix ensures the test product is set to invoice at order time before a sales order is created. It prevents automated test failures when the Kenyan stock e-invoicing module is installed, improving reliability without changing normal business workflows.
Original PR description
The issue: Before this commit, the product was intended to be set as 'invoice on order', but this wasn't applied. The status was overridden due to the '_compute_invoice_policy' function override in the 'l10n_ke_edi_oscu_stock' module, which caused the test to fail on runbot when this module is installed. The fix: Put the product to 'invoice on order' before creating the sale order runbot-70731
The work center blocking wizard now shows the Block button in lowercase for consistent wording. This is a small interface polish that improves presentation without changing functionality.
Original PR description
`BLOCK` button in the workcenter blocking wizard should be in lowercase --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Invoices created from many sales orders now keep the TicketBAI invoice description within the required length limit. This helps avoid Spanish electronic invoicing validation issues when many orders are combined into one invoice.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: ---17.0-esoriginlength-jco I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The cart page now reserves consistent space for product images while they load. This prevents page content from jumping around and improves alignment when products have differently shaped images.
Original PR description
Product images are lazy-loaded on the cart page, causing them to be displayed later than the rest of the page. As a result, some parts of the page were shifted once the image was loaded (since the image had no size before loading). This change wraps the image in a fixed-size container to avoid the layout shift. Incidentally, this change also fixes some alignment issues when the cart contains images with various aspect ratios. opw-4029017
Malaysian electronic invoice files will no longer include linked sales or purchase order information. This prevents validation errors on the MyInvois platform, helping invoices submit successfully when they are connected to orders.
Original PR description
The UBL file could contain SO or PO information if the invoice is linked to one. The MyInvois platform does not support this information and return a validation error if it is provided. This fix will update the template in order to remove this information from the file. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update resolves an issue where nested lines within account reports were not fully unfolding, preventing users from seeing all related financial data. The fix ensures that all child lines are correctly expanded, providing a more complete and accurate view of financial reports. This improves data visibility and reporting accuracy.
This update ensures that images taken during quality checks linked to Manufacturing Orders (MOs) or Work Orders (WOs) are now correctly displayed within the quality check wizard. Previously, picture-type quality checks didn't show the associated image, which is now resolved to improve the visual clarity of quality control processes.
Original PR description
When opening a validated quality check from a MO/WO, if the type of the quality check is 'picture', the QC wizard should show the image taken.
This update corrects a discrepancy in how medical assistance work entries are handled within the payroll system. Previously, they didn't align with standard credit-time entries, leading to potential reporting inconsistencies. This fix ensures medical assistance entries now use the same DMFA code, improving accuracy and compliance.
Original PR description
The medical assistance work entry should be behaving like the credit-time and should have the same DMFA code. Task: 4247631 Forward-Port-Of: odoo/enterprise#71872
This update ensures that only the necessary Electronic Data Interchange (EDI) fields related to Mexican tax regulations are displayed for Odoo companies with a Mexican fiscal country. This improves data accuracy and reduces clutter for users working with Mexican businesses, streamlining reporting and compliance.
Original PR description
We only need to shown MX EDI fields for move/invoices related to a company where fiscal country is Mexico, hide it for other companies. Forward-Port-Of: odoo/enterprise#73623
A technical issue causing a traceback when managing addresses on the Odoo website for Colombian businesses has been resolved. The fix ensures consistent data access, preventing errors related to how address information is handled, improving the user experience for our Colombian customers.
Original PR description
Steps to Reproduce: - Set up a website for a Colombian company. - Go to the shop section. - Purchase any product. Issue: - Traceback occurs when opening the address form for an existing or new address. Cause: - The error occurs because the form data for state_id, city_id, and other field is not consistently accessible, depending on whether values is a object or a dictionary. Fix: - Added checks to ensure fields like state_id and city_id are accessed only if they exist within values. opw-4314031
Miscellaneous changes
opw-4325300 Forward-Port-Of: odoo/odoo#187285
Original PR description
opw-4325300 Forward-Port-Of: odoo/odoo#187285
When we try to print multiple invoice who have multiple pages and have H2 title in the comments, the system treats the document as separate files, resulting in error: `AttributeError: 'NoneType' object has no attribute 'getValue'`. Steps to reproduce: - Create an invoice without any attachment. - Create another invoice, ensuring that its printout spans multiple pages, and add an H2 title in the comments (narration). - In the list view, attempt to print both invoices. - Ensure that the r
Original PR description
When we try to print multiple invoice who have multiple pages and have H2 title in the comments, the system treats the document as separate files, resulting in error: `AttributeError: 'NoneType' object has no attribute 'getValue'`. Steps to reproduce: - Create an invoice without any attachment. - Create another invoice, ensuring that its printout spans multiple pages, and add an H2 title in the comments (narration). - In the list view, attempt to print both invoices. - Ensure that the report being printed contains a value in the "Save as attachment prefix" field. The issue arises because the presence of multiple H2 headings causes the system to treat the document as separate files. Consequently, the condition `if has_same_number_of_outlines and has_top_level_heading:` is not satisfied, which results in a stream to be None. opw-4247013 Forward-Port-Of: odoo/odoo#183881
Versions -------- - 16.0+ Steps (17.0+) ------------- 1. Create a Sale Order for a new contact without phone number; 2. disable online signature; 3. add a deliverable product to the SO; 4. hit "Send by Email"; 5. open the sent mail (e.g. via Mailhog); 6. copy the payment link; 7. open in Safari on iOS; 8. pay the sales order. Issue ----- > ``` >TypeError: Attempted to assign to readonly property. > extractFilteredSchemaValuesFromMicroData@https... > extractSchemaValuesF
Original PR description
Versions -------- - 16.0+ Steps (17.0+) ------------- 1. Create a Sale Order for a new contact without phone number; 2. disable online signature; 3. add a deliverable product to the SO; 4. hit "Send…
Versions -------- - 16.0+ Steps (17.0+) ------------- 1. Create a Sale Order for a new contact without phone number; 2. disable online signature; 3. add a deliverable product to the SO; 4. hit "Send by Email"; 5. open the sent mail (e.g. via Mailhog); 6. copy the payment link; 7. open in Safari on iOS; 8. pay the sales order. Issue ----- > ``` >TypeError: Attempted to assign to readonly property. > extractFilteredSchemaValuesFromMicroData@https... > extractSchemaValuesFromSchemaOrg@https... > global code@https... > ``` Cause ----- `extractFilteredSchemaValuesFromMicroData` is a function internal to iOS Safari. It is bugged in that it tries to reassign a `const` in some scenarios where no elements with `itemprop="telephone"` attributes are found. More details in this comment: https://github.com/odoo/odoo/pull/187143#issuecomment-2475934797 Solution -------- If the contact doesn't have a mobile or phone number, add an empty `div` with `itemprop="telephone"`. > [!note] > I've also reported the bug to Apple, but who knows when/if they'll fix it. Related issue: https://github.com/odoo/odoo/issues/162145 opw-4072838 Forward-Port-Of: odoo/odoo#187143
Steps to reproduce: - Enable Analytic Accounting and Anglo-Saxon Accounting in the settings - Create a storable product - Set inventory valuation to Automated on the product's category - Add a cost to the product - Create an invoice with the product and add an analytic distribution - When the invoice is confirmed, the distribution is also applied to the CoGS line. For example, in an invoice where the product’s sale price equals its cost, the account plan will show a balance
Original PR description
Steps to reproduce:
- Enable Analytic Accounting and Anglo-Saxon Accounting in the settings
- Create a storable product
- Set inventory valuation to Automated on the product's category
- Add a cost to the product
- Create an invoice with the product and add an analytic distribution
- When the invoice is confirmed, the distribution is also applied to the CoGS line.
For example, in an invoice where the product’s sale price equals its cost, the account plan will show a balance of 0 (debit = credit).
After this fix, the account plan will show a balance of 10.
Task 2008567 led to the commit https://github.com/odoo/odoo/commit/3590efa47849be09e694e7755ec640f41cb14313, which removed the analytic distribution from the stock interim account. However, the expense line was not modified accordingly.
opw-4177695
Forward-Port-Of: odoo/odoo#183066I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186968
Original PR description
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186968
Description of the issue this PR addresses: Current behavior before PR: I. Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or `pre` elements. II. When pasting the clipboard content as plain text (CTRL+SHIFT+V) inside a `PRE` element would convert each line break into a new paragraph. III. When text with a url is pasted within a pre tag the text is converted to a link. Desired behavior after PR is merged: I. `bl
Original PR description
Description of the issue this PR addresses: Current behavior before PR: I. Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or…
Description of the issue this PR addresses: Current behavior before PR: I. Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or `pre` elements. II. When pasting the clipboard content as plain text (CTRL+SHIFT+V) inside a `PRE` element would convert each line break into a new paragraph. III. When text with a url is pasted within a pre tag the text is converted to a link. Desired behavior after PR is merged: I. `blockquote` and `pre` should be considered like wrappers, allowing paragraph-related elements to be pasted inside them. II. When pasting the clipboard content as plain text within `pre`, every new line should be pasted within the `pre` tag. III. When text with a url is pasted within a pre tag it should not convert it to a link. IV. The `pre` tag does not have automatic word-wrapping or line-breaks as it is intended to keep the formatting of the text. This commit ensures that long text within `pre` tags does not overflow. task-4154465 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178965
The Turkish National Identification Number (NIN) consists of 11 digits in the format NNNNNNNNNNN where the last two digits are check digits. The Vergi Kimlik Numarasi (VKN) is a 10-digit number in the format NNNNNNNNNN. The Vergi Kimlik Numaras is the Turkish tax identification number used for businesses and certain foreign individuals. task: 4282883 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185884
Original PR description
The Turkish National Identification Number (NIN) consists of 11 digits in the format NNNNNNNNNNN where the last two digits are check digits. The Vergi Kimlik Numarasi (VKN) is a 10-digit number in the format NNNNNNNNNN. The Vergi Kimlik Numaras is the Turkish tax identification number used for businesses and certain foreign individuals. task: 4282883 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185884
When reversing a move of type 'in/out refund', we create a move of type 'entry' instead of 'in/out invoice' opw-4247643 Forward-Port-Of: odoo/odoo#184909
Original PR description
When reversing a move of type 'in/out refund', we create a move of type 'entry' instead of 'in/out invoice' opw-4247643 Forward-Port-Of: odoo/odoo#184909
When a user visits a product page, the product gets marked as "recently viewed" after 8 seconds. This delay is too long, as a user can realistically view the product and navigate away before the 8 seconds have passed (in which case the product isn't marked as recently viewed). In particular, this is problematic when the website contains a "recently viewed products" carousel, where the user expects to see all products they recently viewed (even if they didn't stay on the product page f
Original PR description
When a user visits a product page, the product gets marked as "recently viewed" after 8 seconds. This delay is too long, as a user can realistically view the product and navigate away before the 8 seconds have passed (in which case the product isn't marked as recently viewed). In particular, this is problematic when the website contains a "recently viewed products" carousel, where the user expects to see all products they recently viewed (even if they didn't stay on the product page for 8 seconds). We decided to reduce the delay to 0.5 seconds, which is long enough to prevent the product from being marked as "recently viewed" if the user visits a product page by mistake and immediately navigates away, but short enough to prevent problematic behaviors such as the one mentioned above. opw-4114364 Forward-Port-Of: odoo/odoo#187025