Monday, November 18, 2024
8 changes · 18.0
Resolved issues and error corrections
This update prevents a restaurant point-of-sale automated test from failing when a failed-printing pop-up appears. By closing that pop-up before continuing, the test flow becomes more stable and reduces false failures during quality checks.
Original PR description
In this commit, we ensure to close modal (failed printing) before continue the tour or it can cause failures in tour. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail GIF picker now handles duplicate category names from external GIF data, which could previously cause a crash in some languages such as Portuguese. This improves reliability for users adding GIFs in discussions without changing the visible feature set.
Original PR description
Before this commit, opening of GIF picker in some languages like Portuguese could lead to following crash: ``` OwlError: Got duplicate key in t-foreach: #irritado ``` This happens because GIF picker categories come from Tenor data and there might be duplicated categories. However in code we use `category.name` for `t-key`, thus there was a crash when 2 categories had the same name. This commit fixes the issue by using `category_index` instead, which is the index of category in the global list of categories, which is necessarily unique for each GIF category. opw-4319241
This change updates documentation links across Odoo so they point to the correct 18.0 documentation instead of older or generic versions. It helps users and administrators reach the right guidance for their current Odoo version, reducing confusion when following help links.
The Trial Balance report now correctly displays ending balance amounts when the "Blank if Zero" option is enabled. This prevents non-zero ending balances from being hidden on lines that only have debit or only have credit activity, improving report accuracy for finance users.
Original PR description
To reproduce: - Edit 'Trial Balance' report and enable the "Blank if Zero" option for both debit and credit lines - Open a 'Trial Balance', observe there is no 'End Balance' values for line where there are only debit or only credit amounts. This commit also update the `is_zero` option for end balance columns value to ensure there are correctly shown when "Blank if Zero" option is enabled.
This fixes an error in Colombian online checkout when customers edit a delivery address that is also used for billing. The checkout now shows the required obligation type information in that case, helping customers complete purchases without interruption.
Original PR description
Steps to reproduce: 1. Create a store with Colombian localization. 2. Go to the shop and select any product. 3. Proceed to checkout and try to edit the delivery address. An error occurs when editing the delivery address because the `obligation_types` field is NULL. The issue is caused by the condition in the template ([link to the condition]), which checks only if `address_type` is 'billing'. However, the address type can be 'delivery' when using the delivery address as the billing address, resulting in a null reference in the DOM for the obligation types element. I Updated the condition to check for `(address_type == 'billing' or use_delivery_as_billing)`, ensuring that the obligation types element is displayed correctly when the delivery address is used as the billing address. opw-4309448
This update prevents an error during checkout for Colombian online stores when customers edit a delivery address that is also used for billing. It ensures the required tax obligation information appears in the right situation, helping customers complete purchases without interruption.
Original PR description
Steps to reproduce: 1. Create a store with Colombian localization. 2. Go to the shop and select any product. 3. Proceed to checkout and try to edit the delivery address. An error occurs when editing the delivery address because the `obligation_types` field is NULL. The issue is caused by the condition in the template ([link to the condition]), which checks only if `address_type` is 'billing'. However, the address type can be 'delivery' when using the delivery address as the billing address, resulting in a null reference in the DOM for the obligation types element. Solution: Updated the condition to check for `(address_type == 'billing' or use_delivery_as_billing)`, ensuring that the obligation types element is displayed correctly when the delivery address is used as the billing address. opw-4309448
This change fixes an automated check for the restaurant preparation display by preventing an unrelated printer error message from appearing during the test. It helps keep quality checks stable so future updates can be validated with fewer false failures.
Original PR description
Fix tour test_03_preparation_display_skip_change by unlink printer config to avoid the appear of modal "printing failed".
This update adjusts an automated restaurant preparation display test so it no longer triggers an unrelated printing failure message. This helps keep quality checks stable and reduces false alarms during development.
Original PR description
Fix tour test_03_preparation_display_skip_change by unlink printer config to avoid the appear of modal "printing failed".
Original PR description
same like https://github.com/odoo/odoo/pull/141406 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr