Monday, November 18, 2024
3 changes · saas-17.4
Resolved issues and error corrections
Customers using the Argentina ecommerce localization could encounter an error when opening their account details in the portal. This fix ensures the needed customer information is available, so the account details page opens correctly.
Original PR description
Currently, an exception was generated when the user tries to open their account details in the portal (url: my/account) error: `KeyError: 'partner_sudo'` This error was generated because when the…
Currently, an exception was generated when the user tries to open their account details in the portal (url: my/account) error: `KeyError: 'partner_sudo'` This error was generated because when the user tries to open their account detail in the portal, we do not have 'partner_sudo'. Recentley refacto code with https://github.com/odoo/odoo/commit/453cfab758505ae15135703fb7be8bdb54981444 replaced `partner` with `partner_sudo` for the getting partner in the website sale address (`shop/address`) and we have the new key because the template 'partner_info' called from template 'address' see [1] and `partner_sudo` set from [2] for address. But when we call the 'partner_info' from template 'portal_my_details_fields' at [3], we do not have `partner_sudo` This commit will fix the above issue by passing `partner_sudo` in the template at the time prepare value for opening account detail in portal. [1] - https://github.com/odoo/odoo/blob/3ea0c936c01a7c55ee8fa6ee64fd8e89b2a04f5f/addons/l10n_ar_website_sale/views/templates.xml#L60 [2] - https://github.com/odoo/odoo/blob/3ea0c936c01a7c55ee8fa6ee64fd8e89b2a04f5f/addons/website_sale/controllers/main.py#L1119 [3] - https://github.com/odoo/odoo/blob/3ea0c936c01a7c55ee8fa6ee64fd8e89b2a04f5f/addons/l10n_ar_website_sale/views/templates.xml#L68 sentry-5725856236
Express checkout now correctly reflects free shipping coupon discounts when customers switch delivery methods. This prevents customers from seeing or paying an incorrect delivery amount during Stripe express checkout.
Original PR description
Versions -------- - 17.4+ Steps ----- 1. Create a discount code with a free shipping reward with a max amount; 3. Create one or more shipping methods with a price higher than the max amount previously set; 4. in eCommerce, add a product to the cart, and go to checkout; 5. apply coupon; 6. open the express checkout form using Stripe 7. switch between shipping methods. Issue ----- The free shipping discount is not considered in the Express Checkout form. Cause ----- Commit 8e2b6ce accidentally removed `delivery_discount_minor_amount` from `_order_summary_values` (previously called `_update_website_sale_delivery_return`) introduced by commit c047cc8, preventing the express checkout to get the up to date value. Solution -------- Add `delivery_discount_minor_amount` back to `_order_summary_values`. opw-4204901
Budget committed and achieved amounts are now flagged correctly when either value exceeds the planned budget. Budget calculations also exclude draft supplier bills, giving teams a more reliable view of actual spending commitments.
Original PR description
task-4246523