Daily updates from Odoo
Wednesday, November 20, 2024
8 changes · 17.0
Resolved issues and error corrections
This update resolves an issue where duplicate keyboard shortcuts were preventing users from accessing key actions within the Subscription module. The fix ensures that different actions have unique shortcuts, improving usability and preventing workflow disruptions. This change focuses on the 'Upsell' and 'Close' buttons.
Original PR description
**Issue:** Two different actions have the same shortcut making one action impossible to reach. **Expected:** Different actions should have different keyboard shortcuts. **Steps to reproduce:** - Activate Subscription app; - Open an existing subscription; - Press `ALT` (`CTRL` on MacOS) to display all shortcuts and look at the `UPSELL` and `CLOSE` buttons. **Cause:** The same `data-hotkey` has been used for both buttons. **Fix:** Change the `UPSELL` button shortcut to `ALT+E` (`CTRL+E` on MacOS) as for Odoo 17. opw-4306179 Forward-Port-Of: odoo/enterprise#73548
This update addresses a test failure within the Web Studio module, which is a key component of Odoo's website customization tools. The fix was triggered by a recent change from the Odoo community, ensuring continued stability and functionality for users building and managing their online storefronts.
Original PR description
This is a fix for failing test after the change introduced in the corrosponding community [PR] task-4240730 [PR]: https://github.com/odoo/odoo/pull/183129
This update fixes a rounding issue in the Mexican CFDI invoice generation process. The change ensures that the subtotal and discount values are calculated accurately, aligning with Mexican tax regulations. This improves the reliability of invoices for Mexican customers.
Original PR description
### Steps to reproduce the issue: 1. Activate Mexican Localization 2. With a Mexican Company, create an Invoice and add a Product with a valid UNSPSC code 3. On the Invoice Line, set Price to 1030.17…
### Steps to reproduce the issue:
1. Activate Mexican Localization
2. With a Mexican Company, create an Invoice and add a Product with a valid UNSPSC code
3. On the Invoice Line, set Price to 1030.17 and add a 3% Discount
4. Confirm then Send & Print (with CFDI checked)
5. In the generated XML, the following values are off:
- In node "Comprobante, SubTotal="1030.16" Descuento="30.90"
- In node "Concepto", ValorUnitario="1030.16" Importe="1030.16" Descuento="30.90"
- Expected are 1030.17 and 30.91
### Explanation:
During the calculation of the values for the CFDI, `gross_price_subtotal_before_discount` is calculated using `price_subtotal` in every case where `discount` is not 100%. This is due to other values affecting `price_subtotal` (e.g.: taxes with `price_include=True`), in which case calculating a value related to `price_subtotal` with `price_unit` would give the wrong result.
This calculation method causes rounding issues such as above because `price_subtotal` is rounded before calculating `gross_price_subtotal_before_discount`.
### Fix reasoning:
We need to account for any value that could affect `price_subtotal` and make it different from `price_unit * quantity` except for `discount`, which will be included when comparing both values.
The case `discount == 100.0` is covered by this new condition as well, since `discount_factor` would equal to 0 and `price_subtotal` too.
opw-4183556This update resolves an issue where a key test failed when the 'pos_preparation_display' module wasn't present. The test has been moved to the correct module, ensuring consistent and reliable testing of the self-order POS functionality. This improves the overall stability of the system.
Original PR description
The test `test_self_order_preparation_disabling_preparation_display` in `test_self_order_common` does not work when the `pos_preparation_display` module is not installed. This is because there is no warning message when `pos_preparation_display` is absent. This commit changes the test location to the module `pos_self_order_preparation_display`.
This update resolves an issue where new states were incorrectly created for Amazon orders, leading to data inconsistencies and confusion. The change now creates an activity for the sales representative to manually set the correct state, ensuring data accuracy and preventing disruptions to related workflows.
Original PR description
Before this commit contact created from amazon order create new state if it does not find matching state in odoo and it was causing issues like having record multiple record for same state and user don't know which one is right with proper code in data. This commit stop creating new state instead create activity on contact for amazon sale person to set proper state on the related contact to not break flows that are related to contact's state. Backport of b327ea1897fca34164a9bbea59a23d34b97e65a2 task-3865454 Forward-Port-Of: odoo/enterprise#74099
This update resolves a technical issue that could cause errors in the generation of financial reports for Belgium. Specifically, it avoids division-by-zero errors when dealing with entries that have zero balances and currency amounts. The fix ensures reports are generated accurately and reliably.
Original PR description
## [FIX] l10n_be_reports: 281.50 and exchange diff The aim of this commit is to prevent a Zero devision error by excluding irrelevant 'zeroed' exchange difference. Context: Some misc entry with a 0 balance and some amount_currency might be present and taken into account for the computation. Such moves have an `amount_total_signed` equal to 0 leading to the zeroDivisionError issue in the query computation. Before the commit: When having such entry considered by the query, creating the 325.50 form leads to a traceback. After the commit: Those irrelevant moves are ignored and the process carry on smoothly. task-id: None - Issue spotted on next ## [FIX] l10n_be_reports: 281.50, no 0-0-0-0-0 form The aim of this commit is to avoid generating a 281.50 form if there isn't any amounts to fill in the form. task-id: None - Dicussed with TSB Forward-Port-Of: odoo/enterprise#73842
This update fixes a technical error that prevented users from configuring TaxCloud within the invoicing system. The issue stemmed from a problem accessing data related to CartItemsResponse, which has now been resolved. This ensures TaxCloud functionality is reliably available for US customers.
Original PR description
**Steps to reproduce:** - Edit \__init__.py file of account_taxcloud module to allow its installation - Install sale_account_taxcloud and industry_fsm_stock - In Invoicing settings, configure TaxCloud credentials - Configure TaxCloud fiscal position: * Country: United States * Detect Automatically: [enabled] - Go to "Field Service" - Create a new Task: * Title: [anything] * Customer: [a US customer] (e.g. Deco Addict) - Click on "Products" smart button - Add a product - Click on the task name in the breadcrumb to go back to the task **Issue:** A traceback is raised while trying to access CartItemResponse property of the None value of CartItemsResponse. opw-4199902
This update adjusts the color contrast of primary buttons in the Odoo Enterprise application. Previously, the focus state wasn't visually distinct enough, making it harder for users to easily identify which buttons were active. This change ensures better usability and accessibility by providing clear visual feedback when buttons receive focus.
Original PR description
This PR aims to increase the contrast between the default and the `focus` state of our `btn-primary`. | 17.0 | This PR | |--------|--------| | <img width="729" alt="image" src="https://github.com/user-attachments/assets/19c29432-4467-46bf-b240-41017d435c09"> | <img width="717" alt="image" src="https://github.com/user-attachments/assets/1efc15cc-6e10-460b-9040-4088cf3a98e0"> | Prior to this PR, the color was not dark enough to grant enough visual feedback on focus. This can be solve quickly by tweaking the value directly. task-3382308