Wednesday, November 20, 2024
17 changes · 18.0
Resolved issues and error corrections
This fixes a small visual alignment issue in the visitor live chat window. The avatar and conversation name now line up more cleanly, making the chat header look more polished and consistent.
Original PR description
In the backend, the avatar and conversation name is a clickable button to show more thread actions. When this is clickable, there's some spacing to align avatar nicely. In livechat from visitor perspective, however, the avatar was not spaced properly. This come from avatar and conversation name not being clickable to show more actions, because all actions are available in quick on the right side of header. This commit adds some spacing at beginning of header content of chat window when there's no actions menu, to compensate with the padding of the actions menu button. Before / After <img width="361" alt="Screenshot 2024-11-20 at 15 07 07" src="https://github.com/user-attachments/assets/0cbf75af-df85-4509-8ec3-31ed0893025b"> <img width="363" alt="Screenshot 2024-11-20 at 15 06 49" src="https://github.com/user-attachments/assets/2197a159-a64e-4b80-a5df-cd1b8fe3d578">
Task records will no longer show duplicate update messages when a linked customer name changes. This keeps project communication logs clearer and avoids unnecessary noise for users reviewing task activity.
Original PR description
Before this commit, the `partner_name` was tracked in `project.task` model because `name` of `res.partner` model is tracked and so the related setup will keep the value set on `name` field of `res.partner` to also make the related field tracked. This commit removes the tracking on the related field in task since it was not expected. Moreover, we will get a duplicated tracking message with `partner_id` field which is also tracked in `project.task` model.
The Discuss sidebar counter bubbles now keep their rounded shape even when channel or conversation names are long. This prevents the notification count from looking squeezed, improving readability and polish in the messaging interface.
Original PR description
This commit sets the `flex-shrink` of the counter element to `0` so it won't be reduced when a sidebar item has a long name. We can also remove the `min-width` from `o-discuss-badge` as all `.o-discuss-badge` cases use `.badge` which has a `min-width: 2.7ch`.
Worldline payments can now correctly recognize additional statuses returned during validation. This prevents valid in-progress or declined payments from being misclassified, reducing payment follow-up issues for customers and staff.
Original PR description
Adding missing payment statuses: 'REDIRECTED', 'PENDING_CAPTURE' and 'CAPTURE_REQUESTED' as 'pending' states, 'REJECTED_CAPTURE' as 'declined' state as those statuses can effectively be received from Worldline.
The website's rounded box header now keeps proper spacing on mobile screens. This prevents header content from touching the border, improving the appearance and readability of mobile pages.
Original PR description
This PR aims to fix a spacing issue within the `rounded box` header template, which has no spacing in mobile, making the first and last element stick to the border of the header. To fix that behavior, we simply need to set a `padding` utility class on Mobile as well. - task-3608124 - extracted from https://github.com/odoo/odoo/pull/171050 | 18.0 | This PR | |--------|--------| |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Mentions in Odoo Discuss now display correctly on Safari when messages span multiple lines. This prevents overlapping text, making conversations easier to read and improving the visual reliability of the messaging interface.
Original PR description
Before this commit, rendering of `@`mentions in Discuss on Safari was bigger than line height, which results in unintended UI overlap. This is mostly visible and problematic when 2 successive text…
Before this commit, rendering of `@`mentions in Discuss on Safari was bigger than line height, which results in unintended UI overlap. This is mostly visible and problematic when 2 successive text lines have mentions in the same horizontal range. This happens because discuss mentions are `<a>` and anchor links have `display: inline`. As a reminder, `inline` does not respect top/bottom padding and margin of element in its container so this is very likely prone to overlap vertically with sibling nodes. `inline-block`, on the other hand, take vertical padding and margin into account so it doesn't overlap. If the element takes more space, then siblings are pushed accordingly. This commit fixes the issue by setting `display: inline-block` to all discuss mentions, so that there's no risk of overlap in multi-line especially on Safari. Before / After <img width="520" alt="Screenshot 2024-11-20 at 12 54 31" src="https://github.com/user-attachments/assets/c1888680-e579-4573-930b-69bdf400f8e8"> <img width="523" alt="Screenshot 2024-11-20 at 12 54 12" src="https://github.com/user-attachments/assets/acfdfe8c-b6ef-49cc-8baf-816cf3058516">
This fix prevents an error when collaboration details for another editor are unavailable. It helps keep the HTML editor stable during shared editing sessions instead of interrupting users with a crash.
Original PR description
The `getPeerMetadata` function can return a falsy value and that was not taken into account.
This fixes an issue where users working in right-to-left languages could not see the table picker in Firefox. It restores access to table insertion in the HTML editor, improving reliability for affected language users.
Original PR description
Issue: ====== Table picker doesn't appear in rtl language in firefox Steps to reproduce the issue: ============================= - Make sure you use rtl lang - Create a new todo - Try to add table -…
Issue: ====== Table picker doesn't appear in rtl language in firefox Steps to reproduce the issue: ============================= - Make sure you use rtl lang - Create a new todo - Try to add table - Table picker doesn't appear Origin of the issue: ==================== The case of `left < 0` was handled wrong. They can both be handled by the sane formule. When left > 0 it will be like this: `|---left---||---width---||---right---|` `|-----------------window-------------|` So here `right = window-left-width` And when left < 0 it will be like this `|---width-----||---right------------------------ |` `|---left---| |` ` |-----------------window--------------|` And here `right = window - left - width` (left here is < 0) task-4282549 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The accounting screen now shows the secured entry status only when an entry is already secured or its journal is configured to secure posted entries with a hash. This prevents users from seeing a misleading status indicator just because they have access to inalterability features.
Original PR description
Before this **PR**: Since the visibility of the status bar for secured entries was controlled by the security group 'Show Inalterability Features', once assigned to a user, it would make the status bar visible indefinitely, regardless of whether the "Secure Posted Entries with Hash" option was activated or not. After this **PR**: The status bar for secured entries is now displayed only for entries that are already secured or belong to journals where the "Secure Posted Entries with Hash" option is enabled. **task**-4314073
The Unfollow action in messages now uses the correct icon setup, preventing a broken or incorrect icon from appearing. This keeps the messaging interface visually consistent and easier for users to understand.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/184552 Commit above fixed an issue with `.oi` icon not showing correctly. To fix the issue, it puts the appropriate prefix `.fa` and `.oi` in the icon of the message action. The "Unfollow" message action was not properly adapted, which results in buggy icon due to missing `.fa`. This commit adds `.fa` in its icon definition similarly to how all message actions that use a font awesome icon should do.
Translation has been forgotten in the forward port of the following PR: https://github.com/odoo/odoo/pull/187686 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
Translation has been forgotten in the forward port of the following PR: https://github.com/odoo/odoo/pull/187686 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The UK CIS reporting module no longer loads test code during regular startup. This keeps testing logic separate from normal business use, reducing unnecessary processing and avoiding potential setup issues.
Original PR description
Tests should not be imported in module init. The import is done when tests are enabled.
Uninstalling the Sign app after signing a document now also removes related activity reminders that would otherwise point to deleted records. This prevents users from seeing confusing missing-record errors after removing the app.
Original PR description
The issue: When uploading and signing a document, then uninstalling the Sign module, the following error message appears: `Missing Record Record does not exist or has been deleted. (Record: documents.document(42,), User: 2)` How to reproduce the issue: - Install Sign and Documents modules - Upload a PDF document and click on sign - Go to Apps and uninstall Sign When signing a document from `documents.document`, its `res_model` is set to `sign.template`, and a `mail.activity` is created for validation. On uninstalling Sign, all records with `res_model = 'sign.template'` are removed, but not in `mail.activity`. This happens because deletion occurs via cascade (`sign.template` -> `attachment.id` -> `documents.document`), meaning that`unlink` from `documents.document`is not called. opw-4283568
When an appointment creates a CRM lead, the lead now keeps the attendee-provided description. This helps sales teams see important appointment answers directly on the lead, where they are easier to use during follow-up.
Original PR description
commit [1] removes the hard-coded description on appointment calendar events. We still want to use the "attendee description" on crm leads as questions are not easily accessible from there. [1] 8b9a1a4462453bf64e7bc1307ededd0d127a27fa task-4347415
The Belgian payroll process now skips freelancers when allocating paid time off. This prevents incorrect leave allocations for workers who should not receive employee time off entitlements.
This fix prevents document updates or upgrades from failing when certain document tags are missing. It makes the Documents module more reliable during setup and migration by avoiding errors from optional setup records.
Original PR description
The server actions refer to document tags added in this version. Since the records have the `forcecreate=0` flag, the might not exist, triggering an error. To reproduce: - Create a fresh db in 18. - Delete any referenced tag in the file (eg `documents.documents_tag_inbox`) - Update documents This error will also happen during upgrades from previous versions if the old record to be renamed is missing. ``` ValueError: External ID not found in the system: documents.documents_tag_inbox ```
This change ensures manufacturing work orders are marked as started before they are completed. It prevents an incorrect date sequence that could block users with an error when finishing work orders immediately.
Original PR description
As we immediatly call button_done on the wworkorder, the start_date is greater than the end_date which raises a user error. So we start the workorder before setting it to done