Thursday, November 21, 2024
18 changes · 17.0
Resolved issues and error corrections
Scroll-based animations in eLearning article content now trigger correctly when learners switch to fullscreen mode. This keeps interactive course pages behaving consistently and avoids broken visual effects during fullscreen viewing.
Original PR description
Current behaviour: --- When you make content of type article in eLearning, then add an animation on scroll on an element, when you put the article in fullscreen, the animations do not trigger. Steps…
Current behaviour: --- When you make content of type article in eLearning, then add an animation on scroll on an element, when you put the article in fullscreen, the animations do not trigger. Steps to reproduce: --- 1. Go to eLearning 2. Select a course with articles 3. Click on Go to website 4. Go on the article content 5. Open the editor 6. Drag and drop the columns block at the end 7. Select "feature one" and add an animation on scroll 8. After saving, scroll, the animation works 9. Click on "Fullscreen" 10. Scroll again, animation doesn't trigger Cause of the issue: --- In website_slide, fullscreen mode, the right scrollable element is not `#wrapwrap`, but `.o_wslide_fs_article_content` Note: --- If the animation is not complete, but the page is scrolled at maximum, animation intensity can be lowered in the editor panel, so that the animation can finish earlier. opw-4151770 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Proforma invoice titles now use complete phrases so translators can place words in the right order for each language. This improves invoice wording accuracy, especially for businesses using Odoo in multiple languages.
Original PR description
Currently the word "PROFORMA" was put before any invoice type title without considering the order of the total title, e.g. "PROFORMA Draft Invoice" instead of "Draft Proforma Invoice". Also this is a problem for translations, since other languages cannot change the order of the full title either. This commit makes the titles with "Proforma" as full terms that can be translated as a whole and reordered accordingly. It might break the translation of the title in case of proforma invoices when people would update the translations without updating the `account` module. Since it's an edge case and the "Proforma" titles shouldn't be used often, it's an acceptable limitation.
Push notifications for group chats now correctly show guest names instead of displaying 'False' in the conversation or sender name. This makes chat notifications clearer for users when external guests participate in conversations.
Original PR description
Follow-up of https://github.com/odoo/odoo/pull/186756 PR above improves push notification title in group chat without a name. The fix assumed that all members are partners, which is not necessarily the case. As a result, title contains `False` in conversation name and author when new message comes from a guest. This commit takes guests into account in push notification from new messages in channels as author. Group chat default name also uses guest names for the conversation name.
Voice message recording now releases the microphone if the recorder is no longer active by the time access is granted. This prevents the microphone from staying on unnecessarily, improving privacy expectations and avoiding wasted device resources.
Original PR description
Before this commit, there was no check to see if the microphone was still needed when starting recording, which could leave the stream active with no reference to it. This commit fixes this issue by checking if the component is destroyed when the microphone promise is resolved.
This fixes a Point of Sale IoT setup issue where the wireless access point script could continue before receiving an IP address. The correction helps POS hardware network setup complete more reliably after configuration changes.
Original PR description
In #173866, the IoT configuration files were merged into one file. However, a logic check in `wireless_ap.sh` was inverted in the process, causing it not to wait for an IP. This PR simply restores the `!` to fix the check. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Google Calendar events with incomplete conference information are now handled safely instead of causing an error. This helps keep calendar synchronization reliable when Google sends meeting details without all expected fields.
Original PR description
Before this commit, a KeyError would occur if 'entryPointType' was missing in the entryPoints dictionary. opw-4009884 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
WhatsApp sales order messages now respect the configured currency rounding, including trailing zeros. This ensures customers see monetary amounts in the same format expected by the business and avoids confusion in order communications.
Original PR description
Reproduce --- - install whatsapp,sale_management - have "approved" Sales order whatsapp template - have a sale order with an total amount with trailing zero - have currency rounding configured to show that trailing zero - send a whatsapp message about the sales order - bug: observe that trailing zero isn't shown opw-4135458
This update fixes an issue preventing users from duplicating resource bookings (like tennis courts) within the Appointments module. Previously, a validation error would occur, blocking the duplication process. This change ensures users can now successfully duplicate existing bookings, streamlining appointment scheduling.
Original PR description
Current behaviour: --- When trying to duplicate a resource booking containing a resource, you get a Validation Error for a missing field. Expected behaviour: --- Ability to duplicate a resource…
Current behaviour: --- When trying to duplicate a resource booking containing a resource, you get a Validation Error for a missing field. Expected behaviour: --- Ability to duplicate a resource booking Steps to reproduce: --- 1. Go to Appointments 2. Select a resource appointments (ie. Tennis Court) 3. Click on new (To make a new resource booking) 4. Set a name, attendee, AND resource (ie. Court 1) 5. Go to list view, and open newly made booking 6. Click on the cog > Duplicate 7. Validation Error Cause of the issue: --- Caused by: https://github.com/odoo/enterprise/commit/064e0da976edd7ef501e4fb33d4d579eaab85a3d When duplicating a calendar.event, at the field appointment_resource_ids, the relation table appointment_booking_line is used on the fields calendar_event_id and appointment_resource_id. However, the model appointment_booking_line has another required field capacity_reserved. So when inserting into the table: https://github.com/odoo/odoo/blob/b64a507697381fd7bb205f4a2b2217322d31811a/odoo/fields.py#L4945 Only the two specified columns/fields are set, but not the third required field capacity_reserved. Which causes a SQL error "violates not-null constraint" opw-4187159
This update corrects a dependency issue within the Odoo Enterprise HR Payroll module. A previous error was discovered regarding the connection between payroll and attendance modules, leading to problems during automated testing (runbot). This change ensures accurate payroll calculations and test results.
Original PR description
Introduced in https://github.com/odoo/enterprise/pull/73469 I made a mistake when checking module dependencies, `work_entry_source` attendance is not available in `hr_payroll`, the attendance module is separate. This move is needed to fix errors in runbot. opw-4266880
This update reduces the size of spreadsheet thumbnails, resulting in faster loading times and reduced storage usage. While image quality was slightly decreased, the thumbnails are so small that the visual impact is negligible. This change focuses on optimizing performance and resource efficiency.
Original PR description
This commit drastically reduces the spreadsheet thumbnails size. Go to CRM lead and insert the pivot in a spreadsheet: The size of the thumbnail: | Description | Size | |-----------------------|--------| | Before | 107Kb | | After quality=0.5 | 7.8Kb | | After quality=0 | 2.9Kb | Image quality is indeed reduced, but the thumbnails are always displayed so small that it doesn't really make any difference to the naked eye. Note: I'm not backporting this fix to 16.0 because the code changed and webp was not supported at the time (even though we could use jpeg) Task: 4337496
This update adds the picking name as a reference number to UPS shipments. This enhancement allows for more precise tracking of deliveries within Odoo, aligning with shipping best practices and providing better visibility for our customers. It resolves an internal task (opw-3930816) to improve the accuracy of UPS shipment data.
Original PR description
Add the picking name as a reference number on ups shipment. [opw-3930816](https://www.odoo.com/odoo/project/49/tasks/3930816) Forward-Port-Of: odoo/enterprise#67303
This update fixes a bug that prevented users from editing locked sales orders with automatic tax calculations (AvaTax). The system attempted to recompute taxes after confirmation, leading to an error. This change ensures users can correctly preview and manage these orders without encountering this issue.
Original PR description
An error will raise when users try to open a locked SO where taxes are automatically computed Set up Avatax on the current company In Settings > Sales > Quotations& Orders active 'Lock Confirmed Sales' Create a SO with fiscal position 'Automatic Tax Mapping (AvaTax)' Add a partner and product having avatax category defined Compute taxes Confirm order, it will be automatically locked - With only sale_external_tax installed: Click "Preview" - With sale_subscription_external_tax installed: Click "Confirm" Issue: Action will be blocked by User Error ``` It is forbidden to modify the following fields in a locked order ``` This occurs because the system attempt to recompute external taxes after confirming the sale order, which has been locked, so the action will be blocked opw-4261396
Miscellaneous changes
Before this commit, it was possible for the same order to be created multiple times if the order was sent to the server concurrently. While the order button has a guard to prevent duplicate clicks, the `sendDraftToServer` function can be called from different places, some of which lack this guard. For example, the `setTable` function triggers order syncing but does not have the duplicate protection. Steps to reproduce: 1. Create an order in a table 2. Block the internet connection to preven
Original PR description
Before this commit, it was possible for the same order to be created multiple times if the order was sent to the server concurrently. While the order button has a guard to prevent duplicate clicks,…
Before this commit, it was possible for the same order to be created multiple times if the order was sent to the server concurrently. While the order button has a guard to prevent duplicate clicks, the `sendDraftToServer` function can be called from different places, some of which lack this guard. For example, the `setTable` function triggers order syncing but does not have the duplicate protection. Steps to reproduce: 1. Create an order in a table 2. Block the internet connection to prevent the order from syncing 2. Go to the floor screen 3. Re-enable a slow internet connection 4. Quickly click on two different tables without orders This behavior results in duplicate order creation. Since it's not possible to enforce uniqueness on the server side via a constraint, this commit introduces a debouncing mechanism in the `_save_to_server` function. This ensures that an order cannot be sent to the server more than once concurrently, preventing duplicate creation. opw-4282324 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#185229
Before this PR, one-letter domain (like https://x.com) would not be linkified. This PR allows one-letter domain. Task-4344826 Forward-Port-Of: odoo/odoo#187899
Original PR description
Before this PR, one-letter domain (like https://x.com) would not be linkified. This PR allows one-letter domain. Task-4344826 Forward-Port-Of: odoo/odoo#187899
This commit fixes the direction of the arrows in the stock rules diagram if the user languange is right-to-left. opw-4302429 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187921
Original PR description
This commit fixes the direction of the arrows in the stock rules diagram if the user languange is right-to-left. opw-4302429 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187921
**Steps to reproduce:** - Go to the `Todo` app. - Open a task. - Write any text. - Select the text. - Type `/command` - Hit Enter. **Description of the issue/feature this PR addresses:** The command is correctly added, but the issue is that the selected text is also re-added after the command is applied. **Desired behavior after PR is merged:** Selected text from before the `/command` will be removed and commands will still be executed. The process now involves clearing the c
Original PR description
**Steps to reproduce:** - Go to the `Todo` app. - Open a task. - Write any text. - Select the text. - Type `/command` - Hit Enter. **Description of the issue/feature this PR addresses:** The command is correctly added, but the issue is that the selected text is also re-added after the command is applied. **Desired behavior after PR is merged:** Selected text from before the `/command` will be removed and commands will still be executed. The process now involves clearing the content first and then launching the command. task-3487792 Forward-Port-Of: odoo/odoo#175808
Since odoo/odoo@4d2aa271 we cannot add any manual field to `res.users`. We are always faced with the error: ``` ... fields used for ordering must be present on the model and stored. ``` The reason is that the `res.users.name` field is a related stored field, via inherits. Similarly if we install base_automation we cannot add any field to `base.automation` model, because they are ordered by `sequence`, another stored related field. In this patch we propose to extend the check for field
Original PR description
Since odoo/odoo@4d2aa271 we cannot add any manual field to `res.users`. We are always faced with the error: ``` ... fields used for ordering must be present on the model and stored. ``` The reason is that the `res.users.name` field is a related stored field, via inherits. Similarly if we install base_automation we cannot add any field to `base.automation` model, because they are ordered by `sequence`, another stored related field. In this patch we propose to extend the check for field used in `_order` to related fields. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187629
Description of the issue/feature this PR addresses: Commit [1] made sure that when pasting within blockquote and pre the pasted tag are not unwrapped. But the commit did not change the title as well as the describe of the test cases. This PR places the test cases at correct place. [1]: https://github.com/odoo/odoo/commit/460d88a20a908182e7e9aaf607816c0419a1c6bc --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187724
Original PR description
Description of the issue/feature this PR addresses: Commit [1] made sure that when pasting within blockquote and pre the pasted tag are not unwrapped. But the commit did not change the title as well as the describe of the test cases. This PR places the test cases at correct place. [1]: https://github.com/odoo/odoo/commit/460d88a20a908182e7e9aaf607816c0419a1c6bc --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187724