Thursday, November 21, 2024
3 changes · saas-17.4
Resolved issues and error corrections
This fix makes visibility controls behave correctly when editing nested website elements such as popups and inner blocks. Business users can now show or hide a selected block and have the related parent or child elements update as expected, reducing editing confusion and broken page layouts.
Original PR description
Steps to reproduce: 1.Drag & drop a popup 2.Click on its inner block 3.Set the visibility hidden on desktop 4.Save & enter edit mode (not really needed) 5. Click "Block" to show, popup remains hidden Issue: Nested elements do not toggle visibility correctly. Clicking "Block" fails to show the popup. Clicking the popup first, then the block, will make it visible. Key changes: Previously, only parent-child paths were stored, limiting navigation from parent to child. Now, paths from parent to children are connected and stored. Solution: Ensure clicking a child element makes itself and its parents visible. Conversely, clicking on a parent element should hide itself and all its children. This PR aims to resolve the visibility toggle bug by creating proper parent-to-child connectivity. Clicking on an invisible element now toggles all its parents visible. Similarly, clicking on a visible element toggles all its descendants invisible. task-3806730
This fix prevents an error when customers edit their information in the portal for Argentina and related localized website sales flows. It improves reliability of the self-service profile page so users can update their details without interruption.
Original PR description
Version: ----------- - saas-17.4 Steps to reproduce: --------------------------- - Install module l10n_ar_website_sale - go to portal - click on edit information Issue: -------- - it is giving traceback when clicking on edit information Cause: ---------- - value of 'partner_sudo' is not available when calling 'partner_info' template from 'portal_my_details_fields' template Solution: ------------ - change partner to partner_sudo while calling 'portal_my_details_fields' template to ensure consistency in value of partner in 'partner_info' template. task-4169074
Fixed an issue where customers could be charged or assigned the wrong subscription plan when choosing a non-default product variant on the eCommerce page. The cart now uses the pricing plan that matches the variant the customer selected, reducing order errors and support follow-up.
Original PR description
Steps - Have a subscription product with two variants, each having one different possible pricing. - Go to the eCommerce page of this product and add to cart the second variant (the one which is not selected by default). ** The variant is added to the cart with the wrong plan ** Cause When only 1 pricing is possible for a combination, there's no select element on the page to select a plan and we fallback on the data attribute of the `add_to_cart` button. https://github.com/odoo/enterprise/blob/e9f74bce15e564695733577c181ce3f6d6d063a8/website_sale_subscription/static/src/js/website_sale_subscription.js#L15 However, this element is only rendered once for the initial product combination and never updated when changing to a new combination. https://github.com/odoo/enterprise/blob/e9f74bce15e564695733577c181ce3f6d6d063a8/website_sale_subscription/views/templates.xml#L90-L94 opw-4197528