Thursday, November 21, 2024
20 changes
1 change
Resolved issues and error corrections
The accounting demo setup now ensures a country is defined for the company. This prevents failures in automated checks that depend on country-specific accounting configuration, improving reliability for test and demo environments.
Original PR description
Fix for 1c5cc23b5eb3b59da10926688fc350b56397b550 Generic CoA sets the country on the company. Without one many tests fail. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
This fix ensures planning schedule template calculations work correctly when several records are processed at once. It helps avoid incorrect or incomplete planning data in batch operations, improving reliability for teams managing schedules.
Original PR description
Template compute methods do not support properly recordsets and work for a single record. The goal here is to handle more than one record at a time.
13 changes
Resolved issues and error corrections
This fixes a problem where a test retry check could fail after an earlier test failure, creating misleading logs. The change helps keep automated test results clearer and more reliable for teams monitoring product quality.
Original PR description
Since auto retry was disabled after the first failure (see #162990), the test_retry test suite will systematically fail if another test fails before, adding confusing logs. Fix the way the retry count is detected to solve the issue.
5 changes
Resolved issues and error corrections
This update fixes an issue preventing users from duplicating resource bookings (like tennis courts) within the Appointments module. Previously, a validation error would occur, blocking the duplication process. This change ensures users can now successfully duplicate existing bookings, streamlining appointment scheduling.
Original PR description
Current behaviour: --- When trying to duplicate a resource booking containing a resource, you get a Validation Error for a missing field. Expected behaviour: --- Ability to duplicate a resource…
A website test step related to hiding the header while scrolling was corrected after it broke in no-demo builds. This helps keep automated quality checks reliable without changing the customer-facing website experience.
Original PR description
in commit https://github.com/odoo/odoo/pull/182289/commits/b18e284da99ff3ae10ef03f12fdcb13efc3acbd1 one of the steps of dropdowns_and_header_hide_on_scroll tour got broken. This commit aims to fix that error. [runbot errors](https://runbot.odoo.com/web#id=105122&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures company-specific numeric and yes/no fields handle empty default values correctly when saving updates. It prevents incorrect stored values and keeps company-dependent settings consistent across records.
Original PR description
The problem is caused by https://github.com/odoo/odoo/pull/184275 For company dependent Boolean/Integer/Float fields, if fallback is unset or falsy, the value filled to cache can be `None` after fetch. When `_flush` `None` in cache for these fields should be converted to the logical equivalent `False`/`0`/`0.0` to allow SQL to compare with the fallback value and drop them when UPDATE opw-4313425 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where selecting text across chatter messages in Firefox could trigger an error. The editor now ignores selections outside its own area, improving reliability when users interact with messages around editable fields.
Original PR description
**Problem**: When selecting nodes outside the editor in chatter, attempting to set the selection results in a traceback. This issue occurs because the `setSelection` logic does not properly handle cases where the selected node falls outside the editor's context. **Solution**: Add a check to ensure that the `setSelection` logic does not execute if the selection is outside the editor. same as what we have in 17.0: https://github.com/odoo/odoo/blob/288f815382f6d4f857c233c4627774f1992af5ba/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js#L2608-L2610 **Steps to reproduce**: 1. Open any form with chatter in Firefox. 2. Select text across multiple messages in the chatter. 3. A traceback occurs due to improper handling of selections outside the editor. opw-4345728 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix restores the ability for shoppers to select pickup point locations during checkout when using website sale collection with Sendcloud. It prevents the selection button from being incorrectly disabled when optional location details are missing.
Original PR description
Steps to reproduce: - install website_sale_collect - setup a sendcloud delivery method with pickup points - try to select a location Bug: The `Choose this location` button is disabled This is a tiny partial revert of https://github.com/odoo/odoo/pull/180754. The replacement of the chain of `and` cannot be replaced by the ?. operator, as they will return !False and thus disable the button even if `additionalData` (and the other following items of the ?. chain) is not present on the selected location. opw-4283739 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents the HTML editor from showing an error when users press Tab while working with nested lists. It makes list editing more reliable and avoids interruptions while formatting content.
Original PR description
Description of the issue/feature this PR addresses: The issue occurs when `mergeSimilarLists` is triggered, leading to a call to `compareListTypes`. If `a.firstElementChild` or `b.firstElementChild` is null, attempting to access their `tagName` causes an error. Desired behavior after PR is merged: The traceback no longer occurs.
This fix makes Odoo's code upgrade command clearer and more reliable when run directly or through odoo-bin. It now requires the needed add-ons path information, uses sensible defaults where appropriate, and avoids a crash when no files match the requested pattern.
Original PR description
* Requires --addons-path and prints the correct usage when used standalone. * Ensure --addons-path is populated with the default paths when used with odoo-bin. * Fixed 0/0 division by zero error when no file match the glob. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a typo that caused an incorrect value to appear in Spanish TicketBAI XML documents. The change helps ensure submitted electronic tax documents contain the expected information and reduces the risk of reporting errors.
Original PR description
Fix a typo in that led to wrong value in tbai xml document. opw-4331383
Salespeople can once again view invoices linked to their sales orders without needing Accounting or Billing permissions. This fixes an access error related to Indonesian e-Faktur data, helping sales teams follow up on customer invoices smoothly.
Original PR description
Salesman have access to see invoices (from orders) but when opening one, an access error it raised: `You are not allowed to access 'Available E-faktur range' (l10n_id_efaktur.efaktur.range) records.` This commit allow salesman without `Accounting / Billing` to see their invoices again. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mobile messaging menu and Discuss app now use less spacing between conversation items. This lets users see more conversations on screen while keeping each item easy to tap with a thumb.
Original PR description
There was too much spacing in the mobile messaging menu and mobile discuss app. This PR reduces is so more item are visible while still being easily clickable with a thumb tap. <img width="1236" alt="Screenshot 2024-11-20 at 17 09 06" src="https://github.com/user-attachments/assets/bccaef0e-150f-4365-a224-e405435afa26">
The partner form now shows the customer's follow-up status, making it easier for staff to see collection status at a glance. It also adds a direct link to the partner's overdue invoices, helping teams act faster on outstanding payments.
Original PR description
The followup status of the partner is added to the partner form view with an additional link to see the list of overdue invoices for the partner. task-4320967
Rental and subscription sales now carry over the unit of measure chosen on the sales line when creating products. This keeps these workflows aligned with standard sales behavior and helps avoid incorrect product setup or ordering details.
Original PR description
To ensure that products created from sale order lines correctly use the uom set on the line, a new `default_uom_id` has been added to the field `context`. This commit makes sure the same change is applied in rental & subscriptions, as both modules inherit from the base `sale` view and overwrite the `context` attribute to add their own keys. opw-4316426
Portal users can now cancel creating a new folder in Documents without seeing an error screen. This prevents an interruption in the Documents workflow and provides a smoother experience for external users.
Original PR description
**How to reproduce:** Login with portal. Click on New button. Click on Folder button. Click on Discard button. Traceback will be displayed. **After this PR:** Prevent traceback when portal users click the discard button. Task-4330910
Current behaviour: --- When trying to duplicate a resource booking containing a resource, you get a Validation Error for a missing field. Expected behaviour: --- Ability to duplicate a resource booking Steps to reproduce: --- 1. Go to Appointments 2. Select a resource appointments (ie. Tennis Court) 3. Click on new (To make a new resource booking) 4. Set a name, attendee, AND resource (ie. Court 1) 5. Go to list view, and open newly made booking 6. Click on the cog > Duplicate 7. Validation Error Cause of the issue: --- Caused by: https://github.com/odoo/enterprise/commit/064e0da976edd7ef501e4fb33d4d579eaab85a3d When duplicating a calendar.event, at the field appointment_resource_ids, the relation table appointment_booking_line is used on the fields calendar_event_id and appointment_resource_id. However, the model appointment_booking_line has another required field capacity_reserved. So when inserting into the table: https://github.com/odoo/odoo/blob/b64a507697381fd7bb205f4a2b2217322d31811a/odoo/fields.py#L4945 Only the two specified columns/fields are set, but not the third required field capacity_reserved. Which causes a SQL error "violates not-null constraint" opw-4187159
This update corrects a dependency issue within the Odoo Enterprise HR Payroll module. A previous error was discovered regarding the connection between payroll and attendance modules, leading to problems during automated testing (runbot). This change ensures accurate payroll calculations and test results.
Original PR description
Introduced in https://github.com/odoo/enterprise/pull/73469 I made a mistake when checking module dependencies, `work_entry_source` attendance is not available in `hr_payroll`, the attendance module is separate. This move is needed to fix errors in runbot. opw-4266880
This update reduces the size of spreadsheet thumbnails, resulting in faster loading times and reduced storage usage. While image quality was slightly decreased, the thumbnails are so small that the visual impact is negligible. This change focuses on optimizing performance and resource efficiency.
Original PR description
This commit drastically reduces the spreadsheet thumbnails size. Go to CRM lead and insert the pivot in a spreadsheet: The size of the thumbnail: | Description | Size | |-----------------------|--------| | Before | 107Kb | | After quality=0.5 | 7.8Kb | | After quality=0 | 2.9Kb | Image quality is indeed reduced, but the thumbnails are always displayed so small that it doesn't really make any difference to the naked eye. Note: I'm not backporting this fix to 16.0 because the code changed and webp was not supported at the time (even though we could use jpeg) Task: 4337496
This update adds the picking name as a reference number to UPS shipments. This enhancement allows for more precise tracking of deliveries within Odoo, aligning with shipping best practices and providing better visibility for our customers. It resolves an internal task (opw-3930816) to improve the accuracy of UPS shipment data.
Original PR description
Add the picking name as a reference number on ups shipment. [opw-3930816](https://www.odoo.com/odoo/project/49/tasks/3930816) Forward-Port-Of: odoo/enterprise#67303
This update fixes a bug that prevented users from editing locked sales orders with automatic tax calculations (AvaTax). The system attempted to recompute taxes after confirmation, leading to an error. This change ensures users can correctly preview and manage these orders without encountering this issue.
Original PR description
An error will raise when users try to open a locked SO where taxes are automatically computed Set up Avatax on the current company In Settings > Sales > Quotations& Orders active 'Lock Confirmed Sales' Create a SO with fiscal position 'Automatic Tax Mapping (AvaTax)' Add a partner and product having avatax category defined Compute taxes Confirm order, it will be automatically locked - With only sale_external_tax installed: Click "Preview" - With sale_subscription_external_tax installed: Click "Confirm" Issue: Action will be blocked by User Error ``` It is forbidden to modify the following fields in a locked order ``` This occurs because the system attempt to recompute external taxes after confirming the sale order, which has been locked, so the action will be blocked opw-4261396