Daily updates from Odoo
Friday, November 22, 2024
22 changes
3 changes
Resolved issues and error corrections
This fixes an internal website test so it no longer depends on optional demo data being available. It helps keep automated validation reliable and prevents false build failures, without changing the user-facing website experience.
Original PR description
[Runbot Error 107975](https://runbot.odoo.com/web#id=107975&model=runbot.build.error)
This fixes an issue in the self-ordering point of sale test setup where tax information could be missing when no company country was configured. It helps keep automated checks stable and reduces false failures during development validation.
Original PR description
tax_group_id was not set since company_id was didn't have any country and class wasn't extending from common class. runbot id: 105616
This fix makes avatar tag fields show the same background color as other invalid fields. It improves visual consistency in forms and helps users more clearly recognize validation issues.
Original PR description
Before this commit, the invalid `many2many_tags_avatar` input has two layers of transparent background-color so the two colors stack one uppon the other one and so we had a inconsitancy color with others invalid field.
This commit adds the `.o_field_many2many_tags_avatar` so the following CSS rules are also apply like on the `.o_field_many2many_tags`. And so the child input has `background-color: transparent` when the input is invalid.
```css
.o_input {
--o-input-background-color: transparent;
}
```
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr1 change
Resolved issues and error corrections
Long project names no longer overflow on timesheet Kanban cards. This keeps the timesheet view tidy and easier to read, reducing layout issues for users managing projects.
Original PR description
Before: The project name was overflowing in the Kanban card, causing layout issues. After: The project name now displays correctly within the Kanban card. Fix: Adjusted CSS classes to the Kanban card to properly handle long project names. Task:4198771
10 changes
Resolved issues and error corrections
This update refines the look and spacing of Odoo Discuss messages, replies, reactions, mentions, and messaging menu items in both light and dark themes. The changes make conversations easier to scan and improve visual consistency without changing functionality.
Original PR description
- message bubble more distinct from background with darkened border - messaging menu item have less horizontal spacing in desktop - messaging menu item preview has bigger emojis like messages -…
- message bubble more distinct from background with darkened border - messaging menu item have less horizontal spacing in desktop - messaging menu item preview has bigger emojis like messages - messaging menu dark theme spacing matches white theme (was missing border color) - message reactions have slightly smaller emoji size - discuss sidebar quick search is more aligned with other items - message in reply background matches original message color and has is more distinct from replied message - mention in dark theme is shinier, somewhat same contrast with regular text content than in white theme Before / After (white) <img width="2555" alt="0-before-white" src="https://github.com/user-attachments/assets/a99a0873-ae93-4c8d-a3f3-a1c30f232c29"> <img width="1280" alt="0-after-white" src="https://github.com/user-attachments/assets/c826f29c-ed2c-47fe-bac3-77c967aeb39b"> Before / After (dark) <img width="2558" alt="0-before-dark" src="https://github.com/user-attachments/assets/f523a131-8765-4d57-b167-d8f370ca33b5"> <img width="2556" alt="0-after-dark" src="https://github.com/user-attachments/assets/06cb3cf5-ed2e-4527-bd57-27b54fe89bea">
Sale order lines for products that initially calculate to a zero price now keep any manually entered price when the quantity or unit of measure changes. This prevents unintended price resets and helps sales teams preserve agreed custom pricing.
Original PR description
Recent commit c584a61697e4f4d196b4a485411135a96b0f6006 introduced a mechanism to avoid recomputing prices manually defined on sale order lines. Nevertheless, it didn't consider zero-priced products. If a product whose price was 0 (after pricelist computation) was set on the line, even if the price was manually changed to another amount, it was still recomputed when quantities or uom where changed. opw-4329474
The mail composer now keeps separate lines in chatter messages independent when applying formatting. This prevents a heading or similar style applied to one selected line from unintentionally changing the entire message.
Original PR description
Steps to reproduce the issue: ============================= - Go to chatter - Write content on 2 lines - Open composer - Select first line and change the heading - Both lines are changed Origin of the issue: ==================== The content of the textarea sent to the server is `abc<br>efg`. In 17.4: We don't sanitize the content so it stays the same and we put that content into the editor. The editor will create the `p` elements to wrap the inline elements at root. In 18.0: We sanitize the content and it will pass by `lxml.html.fromstring` and it will wrap the content in a `p` element. Now we put `<p> abc<br> efg</p>` in the editor which is valid but it's considered all as the same block. Applying block-level commands like list and heading will change the whole content. Solution: ========= Wrap the textarea content inside a div when we open the mail composer. opw-4350430 opw-4346348
This fix keeps website pages from unexpectedly jumping back to the top when a popup opens while animations are running. It improves the visitor experience by making animated pages and modal popups behave smoothly and reliably.
Original PR description
Since this commit [1], from which the scrolling element is no longer '#wrapwrap' but HTML, the test 'snippet_popup_and_animations' fails. This is because during animations, 'overflow-x: hidden' is added to the scrolling element (HTML). At the time a modal shows, an 'overflow: hidden' style is briefly added to the 'body' element, which causes the page to scroll to the top when a modal shows while an animation is playing on the page. To fix this unwanted behavior, we moved the 'overflow-x: hidden' rule added during animations from the HTML to the body." [1]: https://github.com/odoo/odoo/commit/189a7c96e6e26825dc05c0c6466576fe63aa091e task-4185877
This change adds missing identifiers to French accounting bank data so the records can be reliably loaded during installs, reloads, and upgrades. It prevents upgrade checks from failing and ensures missing bank records can be created when needed.
Original PR description
Records in csv files also need an id column to create a data entry, and to be able to load the file in a mode other than init. The file can be loaded on module installation and all the records would be created without an xmlid, but once the module is reloaded or upgraded the file fails to load. It is a non blocking error for the module but if someone is missing the records then they will not be created. This issue is also blocking the CI on upgrades. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change brings back previously removed website sales stock methods because some existing websites still depended on them. It helps prevent disruptions for online stores after upgrading or running on the stable version.
Original PR description
See #181383, some methods were removed as unused anymore, but existing websites did rely on those apparently. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures GST return period forms open with the correct active record context and prevents permission errors when checking e-invoicing settings. It helps users access Indian GST reporting workflows more reliably without unexpected access issues.
Original PR description
Before This Commit: - The `open_gst_return_period_form_view` method manually set context values for `active_id` and `active_model` instead of relying on the active context. - In `action_get_irn_data`, the logic directly accessed the configurations without using `sudo`, resulting in access errors in certain cases. After This Commit: - The `open_gst_return_period_form_view` method now uses the active context instead of manually setting context values. - The `action_get_irn_data` method has been updated to use `sudo` when checking `l10n_edi_production_env`, ensuring proper access rights and preventing permission issues.
The employee appraisal form now keeps the feedback section from covering the chatter area when feedback is unpublished. This makes the form easier to read and avoids confusion during appraisal reviews.
Original PR description
**Steps:** - Install the hr_appraisal module - Open the employee appraisal form view ---- **Description of the issue/feature this PR addresses:** In the appraisal form view, when feedback is unpublished, the feedback section overlaps with the chatter area. ---- **Cause:** This issue arises due to unhandled overflow in cases where feedback is unpublished. ---- **Fix:** This PR resolves the overlap by applying CSS overflow hidden, which hides the overflowing content and prevents overlap with the chatter section. task-4320069
Recruiters can now refuse an application without encountering a system error. This keeps the recruitment workflow running smoothly when the referrals and salary package modules are installed together.
Original PR description
Backport of https://github.com/odoo/enterprise/pull/70278 task-4345648
Closing a document preview now properly restores the page scrollbar. This prevents users from getting stuck without normal scrolling after viewing a file, improving day-to-day usability in Documents.
Original PR description
Purpose ======= Fix the view scrollbar which isn't restored when the file preview is closed. Specifications ============== When a file is previewed, the view scrollbar is hidden so that scrolling actions don't impact the view behind the file preview. However when the preview is closed, the scrollbar isn't restored. => Calling the documentList onDeleteCallback method to correctly restore the view and the scrollbar when closing the preview. Task-4296803
8 changes
Resolved issues and error corrections
This update resolves a confusion reported by some clients regarding shift copying after using the 'copy previous week' feature. Previously, if a project linked to a shift had zero allocated hours, the shift wouldn't copy. Now, the system allows the shift to be copied even with zero allocated hours to eliminate this confusion.
Original PR description
Some clients were confused about not knowing why their shifts were not copied after setting a project to them (using the copy previous week feature). The reason was that the project linked to their shifts had allocated hours equal to 0. After this commit, if 0 hours are allocated to the project, we allow to copy the shift anyway to avoid confusion (as some clients are clearly not using this field). task-4074736 version-17.0
This update addresses small technical issues within the FedEx delivery integration module. Specifically, it improves security by replacing a potentially unsafe coding practice and enhances translation support by adding a base translation file. These changes ensure smoother and more reliable operation of the FedEx delivery process.
Original PR description
- Add .pot base translation file. - Replace potentially unsafe `const_eval()` with a `json.loads()`. - Use the built-in methods for setting filename for received files.
This update resolves an issue where the Gantt chart was displaying outdated attendance records due to a miscalculation of date ranges. The fix ensures that records with missing end dates are excluded from the chart's view, preventing inaccurate data and improving chart performance. This update addresses a technical error that could impact the accuracy of attendance reporting.
Original PR description
Steps to reproduce ================== - Install hr_attendance_gantt,web_studio - Go to Attendences - Open studio - Enable "Display total row" in the sidebar - Exit studio - Create a new entry with no end date - Switch to the week view - Go to the previous week => `Cannot read properties of undefined (reading 'pills')` Cause of the issue ================== When records don't have a dateStop value, it is set as now(). The domain included record that start before now and have no stop (so converted to now). If the current window is between the 01 and 07 Nov, and today is 14 Nov, a record starting the 09 Nov that has no end date will be included. When finding the closest date, it will be out of bound (day 8 when we only have 7). Solution ======== Those records shouldn't be included at all as the are outside the current viewable range. opw-4160977
A recent update to the Swiss payroll localization module introduced a change that impacted a key test. This fix adjusts a test to accurately reflect the new module and its functionality, ensuring continued reliability of the Swiss payroll calculations. The change is a minor technical adjustment to improve test coverage.
Original PR description
[link to broken tests](https://runbot.odoo.com/web#id=68972&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form) since [this pr](https://github.com/odoo/enterprise/pull/62136), a lot of things changed in swiss payroll localization. One of the changes was introduction of new module, l10n_ch_hr_payroll_elm. This affected one of the assertQueryCount tests checking compute_sheet function, which is also overwriten in said module. Therefore, we need to increase the query count accordingly. Flamegraph of function _get_base_local_dict before above mentioned pr:  Flamegraph of same function after the pr: 
This update resolves an issue where commission calculations were failing when some invoices had incomplete start and end dates for subscriptions. The fix ensures that the system only considers valid dates for maximum and minimum calculations, preventing errors and ensuring accurate commission generation.
Original PR description
Following 81dce8461c7, when only some of the invoice lines have subscription start/end date, the commission generation crash when computing the maximum end date or minimal start start: ``` TypeError: '>' not supported between instances of 'bool' and 'datetime.date' ``` This commit ensure we only try to max/min non-falsy values. Forward-Port-Of: odoo/enterprise#74112
This update fixes an issue where Spanish translations for the l10n_co_reports module were accidentally deleted during a cleanup process. The translations have been restored, synced, and corrected, including a previously inaccurate sentence. This ensures accurate reporting in Spanish.
Original PR description
During the es_XX.po cleaning, the po file for l10n_co_reports was incorrectly not converted to es_419.po and only deleted. We now restore it + correctly rename it to es_419.po As part of this cleaning, the pot file has been re-exported and the po re-synced with it. Missing translations were also added it. A sentence that was obviously incorrect in the original Spanish was also translated to a correct sentence. opw-4336377 PR that deleted the original es_CO.po file: https://github.com/odoo/enterprise/pull/66317
This update resolves a technical issue within Odoo's Studio interface that prevented users from correctly configuring Sales Team settings. Specifically, the Studio was unable to recognize a key filter used in the Sales Team's configuration, leading to an error. This fix ensures Sales Team settings can be accurately adjusted through the Studio.
Original PR description
Steps to reproduce ================== - Install crm,web_studio - Enable leads - Go to CRM > Configuration > Sales Team - Open the first record - Uncheck Pipeline and Leads - Go to CRM > Sales > Teams - Open studio => Undefined graph model for Sales Team: Pre-Sales Cause of the issue ================== The window action uses the following domain `[["use_opportunities", "=", true]]` It is not used from within studio. opw-4285413
This update addresses a visual glitch in the timesheet grid view where columns would flicker during scrolling. The fix adjusts the first column's width to a fixed percentage, ensuring a smoother and more stable display of data. This improves the user experience when viewing large amounts of timesheet information.
Original PR description
Steps to reproduce: ------------------------------ - Install the timesheet module. - Open the module - Open all timesheets in grid view - Scroll the page - There is a flicker when scrolling Issue: -------------- When scrolling in grid view, there is a flicker in columns. Cause: ----------- The grid-template-columns property the first column is set to auto, meaning its width is determined by its content. However, as the content dynamically changes, such as during scrolling, the column width adjusts causing flickering.This occurs because the content size affects the column width. Solution : ----------------- The grid-template-columns property sets the width of the first column in the grid layout to 30% of the screen task-3743360