We disable the domain selection because most of the actions are only applied on visible records. Task-3754115 Forward-Port-Of: odoo/enterprise#71388

We disable the domain selection because most of the actions are only applied on visible records.

Task-3754115

Forward-Port-Of: odoo/enterprise#71388

Branches can access their parent companies' accounts, and generally will just use their parent companies' CoA. Therefore, it makes no sense to create an account `123456 Account Payslip Houserental` in a branch if it already exists in the parent company. Community PR: https://github.com/odoo/odoo/pull/188247 task-none Forward-Port-Of: odoo/enterprise#74409

Branches can access their parent companies' accounts, and generally will just use their parent companies' CoA. Therefore, it makes no sense to create an account `123456 Account Payslip Houserental` in a branch if it already exists in the parent company.

Community PR: https://github.com/odoo/odoo/pull/188247

task-none

Forward-Port-Of: odoo/enterprise#74409

### Steps to reproduce: - Install Data Cleaning and Helpdesk modules - Create 2 Helpdesk tickets with conditions: - at least 1 helpdesk ticket has an SLA policy and is in a stage excluded by the SLA policy - at least 1 helpdesk ticket doesn't have an SLA deadline and has an SLA policy and is also in a stage excluded by the SLA policy - Merge those 2 tickets - Notice a traceback pops-up ### Current behavior before PR: In this commit https://github.com/odoo/enterprise/pull/69352/

### Steps to reproduce:
	- Install Data Cleaning and Helpdesk modules
	- Create 2 Helpdesk tickets with conditions:
		- at least 1 helpdesk ticket has an SLA policy and is in a stage excluded by the SLA policy
		- at least 1 helpdesk ticket doesn't have an SLA deadline and has an SLA policy and is also in a stage excluded by the SLA policy
	- Merge those 2 tickets
	- Notice a traceback pops-up

### Current behavior before PR:
In this commit https://github.com/odoo/enterprise/pull/69352/commits/97e83104dad816a7a65345dea74a66e5dbea94cb a new merge method was introduced but in the new file we created we are importing datetime from datetime and then using datetime.datetime and since we are already importing the sepcific class we don't need to call it like module.class.method

### Desired behavior after PR is merged:
We are calling the method directly from the class without using the module before the call so it is only datetime.max

opw-4330793

Forward-Port-Of: odoo/enterprise#74383

Romania does not use the 3-column trial balance report, instead they use a 4-column and 5-column variant. This commit adds the 4/5-column report as variants to the standard trial balance. The standard trial balance implementation has been changed to be easier to override and add column groups. task: 3810685 Forward-Port-Of: odoo/enterprise#59115

Romania does not use the 3-column trial balance report, instead they use a 4-column and 5-column variant.

This commit adds the 4/5-column report as variants to the standard trial balance.

The standard trial balance implementation has been changed to be easier to override and add column groups.

task: 3810685

Forward-Port-Of: odoo/enterprise#59115

This commit reduces the number of read to a getter `editedRecord` which loops on all the record of the list to find the current one in edition. Forward-Port-Of: odoo/enterprise#74449

This commit reduces the number of read to a getter `editedRecord` which loops on all the record of the list to find the current one in edition.

Forward-Port-Of: odoo/enterprise#74449

### Steps to reproduce: - Install "l10n_cl_edi_pos" - Create a new company with the Chilian localization - Do not add a VAT number - Go to POS, create an order and validate - The date is not displayed on the ticket ### Cause: The localization is moving the date from the bottom of the receipt to the header but the conditions are not the same: - If the country of the company is Chile then date is removed from the bottom - If the company has a Chilian VAT the date is shown in the header

### Steps to reproduce:
- Install "l10n_cl_edi_pos"
- Create a new company with the Chilian localization
- Do not add a VAT number
- Go to POS, create an order and validate
- The date is not displayed on the ticket

### Cause:
The localization is moving the date from the bottom of the receipt to the header but the conditions are not the same:
- If the country of the company is Chile then date is removed from the bottom
- If the company has a Chilian VAT the date is shown in the header So there is a case where none of the conditions are True and the date does not show.

### Solution:
Add a condition on the VAT to delete the date from the bottom.

opw-4330252

Forward-Port-Of: odoo/enterprise#74245

Before this change the message was showing an out-of-date minimun amount to report info of the receptor. Also, the message is more clearly to the user: what are the cases and how to solve them Old Message  New Message  LATAM 1291 / Adhoc ticket 82478 Forward-Port-Of: odoo/enterprise#74314 F

Before this change the message was showing an out-of-date minimun amount to report info of the receptor. Also, the message is more clearly to the user: what are the cases and how to solve them

Old Message
![mensaje-antes](https://github.com/user-attachments/assets/465975ed-2288-4591-b18b-1dd1c4dde8b9)

New Message
![nuevo-mensaje](https://github.com/user-attachments/assets/09ee27a4-fc4b-4114-a8ad-c0f7fbbcdc4f)


LATAM 1291 /  Adhoc ticket 82478

Forward-Port-Of: odoo/enterprise#74314
Forward-Port-Of: odoo/enterprise#73203

related: https://github.com/odoo/odoo/pull/181870 task-4206895 Forward-Port-Of: odoo/enterprise#74363 Forward-Port-Of: odoo/enterprise#71080

related: https://github.com/odoo/odoo/pull/181870

task-4206895

Forward-Port-Of: odoo/enterprise#74363
Forward-Port-Of: odoo/enterprise#71080

In studio, click on Edit Menu in the main navbar. Add a menu or edit the name of a menu. Click Confirm Before this commit, the hierarchical list of the menu editor was not updated. This was due to the fact that studio's dialog service is altered to allow it to have the specific studio sub environment It is that way since 2ae63d9a43ba973d905232105201d88e423a8245 As a consequence, the "menu changed" event triggerd by the menu service on the main environment's bus was not forwarded to to studi

In studio, click on Edit Menu in the main navbar.
Add a menu or edit the name of a menu.
Click Confirm

Before this commit, the hierarchical list of the menu editor was not updated. This was due to the fact that studio's dialog service is altered to allow it to have the specific studio sub environment It is that way since 2ae63d9a43ba973d905232105201d88e423a8245 As a consequence, the "menu changed" event triggerd by the menu service on the main environment's bus was not forwarded to to studio's env's bus.

After this commit, the hierarchical list is updated correctly

task-4001101

Forward-Port-Of: odoo/enterprise#74354

### Steps to reproduce the issue: 1. Create an Invoice with "ODOO_BUG" as payment reference 2. Create a Bank Transaction with the same amount and customer as the Invoice and "ODOO_BUG" as Label 3. The Transaction and the Invoice are automatically matched 4. Create an Invoice with "ODOO BUG" as payment reference 5. Create a Bank Transaction with the same amount and customer as the Invoice and "ODOO BUG" as label 6. The Transaction and the Invoice are not automatically matched ### Expla

### Steps to reproduce the issue:

1. Create an Invoice with "ODOO_BUG" as payment reference
2. Create a Bank Transaction with the same amount and customer as the Invoice and "ODOO_BUG" as Label
3. The Transaction and the Invoice are automatically matched
4. Create an Invoice with "ODOO BUG" as payment reference
5. Create a Bank Transaction with the same amount and customer as the Invoice and "ODOO BUG" as label
6. The Transaction and the Invoice are not automatically matched

### Explanation:

When evaluating `st_line_text_values` in `_get_invoice_matching_st_line_tokens`, the values are split at every whitespace. When trying to find `account.move.line` that match the tokens resulting from the operations, every `name`, `move_id.name` or `move_id.ref` with a whitespace in it will not be recognized due to the whitespaces being removed from the `account.bank.statement.line` side.

### Fix reasoning:

From a business perspective, no Invoice/Payment/Bill reference should have a space in it bar some already covered exceptions. To avoid performance heavy queries, the text value will simply be added to `exact_tokens` and treated as such, allowing for an automatical reconciliation between an `account.move.line` and an `account.bank.statement.line` if their refs match perfectly.

opw-4114296

Forward-Port-Of: odoo/enterprise#71431

The Indian government has revised the threshold limit for reporting inter-state invoices of unregistered customers in GSTR-1 from ₹250,000 to ₹100,000. With this PR, the threshold limits for unregistered customers (B2CL, B2CS, and CDNUR) are updated based on the invoice date: -For invoices dated before November 2024, the limit remains ₹250,000. -For invoices dated November 2024 or later, the limit is reduced to ₹100,000. task-4170878 Forward-Port-Of: odoo/enterprise#74411 Forward-Port-O

The Indian government has revised the threshold limit for reporting inter-state invoices of unregistered customers in GSTR-1 from ₹250,000 to ₹100,000.

With this PR, the threshold limits for unregistered customers (B2CL, B2CS, and CDNUR) are updated based on the invoice date:
-For invoices dated before November 2024, the limit remains ₹250,000.
-For invoices dated November 2024 or later, the limit is reduced to ₹100,000.

task-4170878

Forward-Port-Of: odoo/enterprise#74411
Forward-Port-Of: odoo/enterprise#72446

Steps to reproduce: - Install both hr_contract_salary and l10n_hk_Hr_payroll - Try to review a contract in recruitment Current behaviour: - Exception raised Expected behaviour: - No exception raised Explanation: - Internet allowance is based on employee actual work days. However, for candidate who hasn't join the company, they won't have any work days. Therefore the salary internet rules prorata_rate will be divided by zero, and raised exceptions. X-original-commit: f9e7

Steps to reproduce:

- Install both hr_contract_salary and l10n_hk_Hr_payroll
- Try to review a contract in recruitment

Current behaviour:

- Exception raised

Expected behaviour:

- No exception raised

Explanation:

- Internet allowance is based on employee actual work days. However, for candidate who hasn't join the company, they won't have any work days. Therefore the salary internet rules prorata_rate will be divided by zero, and raised exceptions.

X-original-commit: f9e7d39

Forward-Port-Of: odoo/enterprise#73630

Before this commit, if an invalid record existed in db, and it was open from a list, a notification was raised even if the user didn't modify the record. Also, if an invalid record is open, and the user click to create a new record, a notification is raised. Now, the notifications only raise if the user modifies the record. opw-3987849 Forward-Port-Of: odoo/odoo#187106

Before this commit, if an invalid record existed in db, and it was open
from a list, a notification was raised even if the user didn't modify
the record. Also, if an invalid record is open, and the user click to
create a new record, a notification is raised.

Now, the notifications only raise if the user modifies the record.

opw-3987849

Forward-Port-Of: odoo/odoo#187106

This commit will correct the fact that the siret and APE number must be displayed also when the country code is from the DOM-TOM task:4290323 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187800 Forward-Port-Of: odoo/odoo#185862

This commit will correct the fact that the siret and APE number must be displayed also when the country code is from the DOM-TOM

task:4290323




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#187800
Forward-Port-Of: odoo/odoo#185862

### Steps to Reproduce 1. Install i10n_il module 2. Go to Settings->Invoicing **Expected behavior:** Tax il_vat_inputs_17 (VAT inputs) is selected as default Purchase tax **Actual behavior:** Tax il_vat_self_inv_purchase (Self Invoice) is selected as default Purchase tax. This causes new Vendor Bills to be created without VAT Forward-Port-Of: odoo/odoo#186325

### Steps to Reproduce

1. Install i10n_il module
2. Go to Settings->Invoicing

**Expected behavior:**
Tax il_vat_inputs_17 (VAT inputs) is selected as default Purchase tax

**Actual behavior:**
Tax il_vat_self_inv_purchase (Self Invoice) is selected as default Purchase tax.
This causes new Vendor Bills to be created without VAT

Forward-Port-Of: odoo/odoo#186325

We fix a problem occuring in pivot and graph views. Have a property like properties.441515 used somewhere as groupby. If that property has not been added via the search bar menu, the corresponding (fake) field definition is not known (fillSearchViewItemsProperty has not been called). Thus in that case, a crash occurs because one tries to read info in the undefined field definition for instance. This can happen in several ways: - save a favorite with a property used somewhere (context.group

We fix a problem occuring in pivot and graph views. Have a property like properties.441515 used somewhere as groupby. If that property has not been added via the search bar menu, the corresponding (fake) field definition is not known (fillSearchViewItemsProperty has not been called). Thus in that case, a crash occurs because one tries to read info in the undefined field definition for instance.

This can happen in several ways:

- save a favorite with a property used somewhere (context.group_by or context.pivot_row_groupby for example), reload, apply the favorite -> crash.
- add the pivot or graph view to dashboard or to spreadsheet, (re)Load the dashboard or the spreadsheet -> crash.

We fix the problem by adding on the fly a fake field definition when the groupbys used by the views are known (i.e. when the view models are about to fetch the data).

Task ID: 4141824

Forward-Port-Of: odoo/odoo#187287

This commit reduces the number of read to a getter `editedRecord` which loops on all the record of the list to find the current one in edition. Forward-Port-Of: odoo/odoo#188384

This commit reduces the number of read to a getter `editedRecord` which loops on all the record of the list to find the current one in edition.

Forward-Port-Of: odoo/odoo#188384

In this commit https://github.com/odoo/odoo/pull/155339/commits/ca2d54a81ebb2611c14b0fc06784bd5d285856e3, in the task form, we changed the sol field to make it editable even when the user has no sale access. Trying to edit this field in such conditions produces an Access Error, so we revert this commit. task-4207245 related-https://github.com/odoo/odoo/pull/155339 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188431 F

In this commit https://github.com/odoo/odoo/pull/155339/commits/ca2d54a81ebb2611c14b0fc06784bd5d285856e3, in the task form, we changed the sol field to make it editable even when the user has no sale access. Trying to edit this field in such conditions produces an Access Error, so we revert this commit.

task-4207245
related-https://github.com/odoo/odoo/pull/155339

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#188431
Forward-Port-Of: odoo/odoo#182158

Using fiscal_country_codes in the invisible condition can result in the field being displayed multiple times, as multiple countries may meet the condition. Instead, we are using country_code, as it is more logical for the field to be visible only if the company is located in that specific country. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188099

Using fiscal_country_codes in the invisible condition can result in the field being displayed multiple times, as multiple countries may meet the condition. Instead, we are using country_code, as it is more logical for the field to be visible only if the company is located in that specific country.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#188099

The chart template loading process involves loading demo data for branches [^1], but at the moment this is not tested and broken. This commit fixes the flow and adds a test. [^1]: https://github.com/odoo/odoo/blob/b79bcb0574354a17a2aa64e2fe8d05da95535257/addons/account/models/chart_template.py#L232 Enterprise PR: https://github.com/odoo/enterprise/pull/74409 task-none Forward-Port-Of: odoo/odoo#188247

The chart template loading process involves loading demo data for branches [^1], but at the moment this is not tested and broken.

This commit fixes the flow and adds a test.

[^1]: https://github.com/odoo/odoo/blob/b79bcb0574354a17a2aa64e2fe8d05da95535257/addons/account/models/chart_template.py#L232

Enterprise PR: https://github.com/odoo/enterprise/pull/74409

task-none

Forward-Port-Of: odoo/odoo#188247

**Current behavior:** With a product that is invoiced based on ordered qty, has avg costing, and real time valuation: it is possible to invoice and received quantity in such an order that, when there is a landed cost associated with an invoice instance of the product, the standard price of the product may be updated with an incorrect value. **Expected behavior:** Product cost follows 'average' selection logically. **Steps to reproduce:** *Enable anglo-saxon accounting* 1. Create

**Current behavior:**
With a product that is invoiced based on ordered qty, has avg
costing, and real time valuation: it is possible to invoice and
received quantity in such an order that, when there is a landed
cost associated with an invoice instance of the product, the
standard price of the product may be updated with an incorrect
value.

**Expected behavior:**
Product cost follows 'average' selection logically.

**Steps to reproduce:**
*Enable anglo-saxon accounting*

1. Create a product with:
* real time property valuation
* average cost method
* on ordered quantities control policy

2. Create a purchase order for the product, for 100 000 units of
the product at 1.35 each -> confirm the order

3. Create an invoice for 23 000 units, receive 23 000 units and
backorder the rest

4. Create a landed cost on the invoice for 23 000 in the company
currency units

5. Post the invoice

6. Create a second invoice for 27 000 units and post it

7. Receive 27 000 more units from the receipt

8. See that the product standard price is not the expected value
of 1.81

**Cause of the issue:**
The landed cost on the invoice is not taken into account. Since
the price unit for the moves informing the new price value are
obtained with `_get_price_unit()`, we end up only taking into
account the sum value of the invoice lines linked to the move.
So the landed cost does not get included in the subsequent price
unit calculation here:
https://github.com/odoo/odoo/blob/22e7bfb591c43e849c554eb4c128279d76ad31f9/addons/stock_account/models/stock_move.py#L328

**Fix:**
Extract a method which returns invoice lines to the
`_get_price_unit()` method of purchase_stock so that we may
return line records that represent landed costs that will
otherwise be omitted.

opw-4048396

Forward-Port-Of: odoo/odoo#188131
Forward-Port-Of: odoo/odoo#185889

When adding a custom filter, we can produce a domain of the form ["id", "in", [ 1415T215, 1545481, ... ]] with a very long list of ids. In this commit we make the domain description contain only the 20 first ids of the list. If we don't do that we obtain a (unscrollable) search bar facet that is not fully visible when confirming the domain. Forward-Port-Of: odoo/odoo#188438

When adding a custom filter, we can produce a domain of the form

["id", "in", [
    1415T215,
    1545481,
    ...
]]

with a very long list of ids. In this commit we make the domain description contain only the 20 first ids of the list. If we don't do that we obtain a (unscrollable) search bar facet that is not fully visible when confirming the domain.

Forward-Port-Of: odoo/odoo#188438

Current: Users go to Elearning > Certificates to create a test and do not fill in a description for the test. After the employee finishes the test, they are given a certificate and it is displayed in the employee profile but it is displayed as "False" as shown in the image. This PR fixes that error and fills it back as '' so that it does not display 'False' if the test does not have a description. ![Screenshot from 2024-11-07 10-42-28](https://github.com/user-attachments/assets/a26851e4-4

Current: Users go to Elearning > Certificates to create a test and do not fill in a description for the test.

After the employee finishes the test, they are given a certificate and it is displayed in the employee profile but it is displayed as "False" as shown in the image.

This PR fixes that error and fills it back as '' so that it does not display 'False' if the test does not have a description.
![Screenshot from 2024-11-07 10-42-28](https://github.com/user-attachments/assets/a26851e4-4fbc-46ea-849b-473f13866d6f)




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186531

Problem --------- Additional attachments linked to an Email Template used in the Send & Print are completely ignored. They should not, and it's especially useful for Timesheets. Steps --------- 1. Install Accouting, Timesheet and Sales 2. In debug, access mail templates 3. Go to the 'Invoice: Sending' record > Setting tab 4. In Dynamic Reports, add 'Timesheet' 5. Go to sale 6. Create an SO with 'Junior Architect' product for 10 units 7. Confirm the SO 8. Click the Timesheet widget

Problem
---------
Additional attachments linked to an Email Template used in the Send & Print are completely ignored. They should not, and it's especially useful for Timesheets.

Steps
---------
1. Install Accouting, Timesheet and Sales
2. In debug, access mail templates
3. Go to the 'Invoice: Sending' record > Setting tab
4. In Dynamic Reports, add 'Timesheet'
5. Go to sale
6. Create an SO with 'Junior Architect' product for 10 units
7. Confirm the SO
8. Click the Timesheet widget on the SO form view
9. Register some hours for today (for example 3 hours)
10. On the SO Form view, click 'Create Invoice'
11. Select the option to invoice timesheeted hours and select from today to today as the date range
12. Create the Invoice and post
13. Send & Print -> The timesheet report appears in the send and print widget, when you click send, the timesheet report is actually not sent.

Solution
---------
1. Add a placeholder in the send&print widget, the placeholders are stored in the `mail_attachments_widget` used for such purposes. The dynamic reports are defined with an new key: `dynamic_report` to differenciate them from the `manual` attachments and the invoice PDF. This new key eases the complexity to retreive and create the attachments fom the placeholders list.
2. Add a method when sending the mails to generate the dynamic reports only if the reports have not been removed in the S&P widget (`skip != False`). Since the attachments placed in the mails are a collection of elements from `mail_attachments_widget` that possess a valid attachment ID. We add the relevant attachment data in the mail_attachments_widget of the invoice.

task-4283972

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#187381

Since this commit [1], where the "media dialog insert media" was added, the runbot sometimes fails because the tour contacts the "media-api.odoo.com" API, which is not allowed in a tour. This commit fixes the issue by inserting an icon instead of an image, as the icon does not require any API call. [1]: https://github.com/odoo/odoo/commit/2231148db55cfc6fa3f3f5b2b5c5250b74f2feac runbot-107920 Forward-Port-Of: odoo/odoo#188480

Since this commit [1], where the "media dialog insert media" was added, the runbot sometimes fails because the tour contacts the "media-api.odoo.com" API, which is not allowed in a tour.

This commit fixes the issue by inserting an icon instead of an image, as the icon does not require any API call.

[1]: https://github.com/odoo/odoo/commit/2231148db55cfc6fa3f3f5b2b5c5250b74f2feac

runbot-107920

Forward-Port-Of: odoo/odoo#188480

**task-4280164 opw-3985404** --- **[FIX] web_editor: removes figure parent of removed image** Steps to reproduce the issue: - In website, edit mode. - Drag and drop a "Picture" snippet onto the page. - Click the image in the "Picture" snippet. - Delete the image by clicking the "Remove" button in the image options. - Inspect the DOM of the "Picture" snippet. - Bug: The figure element which wrapped the image is still there. After this commit, when an image wrapped by a figure e

**task-4280164
opw-3985404**

---
**[FIX] web_editor: removes figure parent of removed image**

Steps to reproduce the issue:

- In website, edit mode.
- Drag and drop a "Picture" snippet onto the page.
- Click the image in the "Picture" snippet.
- Delete the image by clicking the "Remove" button in the image options.
- Inspect the DOM of the "Picture" snippet.
- Bug: The figure element which wrapped the image is still there.

After this commit, when an image wrapped by a figure element is removed,
the figure is also removed.

---
**[FIX] web_editor: allows to edit events sidebar photos link**

Before this commit, it was not possible to edit the link of the events
sidebar photos.

This occurred for 2 reasons:

A - The image link option didn't work with images wrapped in a figure
element.
B - After fixing point A, the "href" attribute modification was ignored
when saving the "/event" page.

Steps to reproduce A:

- Go to the "/event" page in edit mode.
- Click on the 'Customize' tab and enable the sidebar.
- Click a photo in the sidebar.
- Bug: the URL input for setting the link is not available in the
"Image" options.

Steps to reproduce B (after fixing A):

- Go to the "/event" page in edit mode.
- Click on the 'Customize' tab and enable the sidebar.
- Click a photo in the sidebar.
- Edit the "Your URL" input. (e.g. [www.odoo.com](http://www.odoo.com/))
- Save the page.
- Click the image with the modified link.
- Bug: the new link was not saved.

To fix issue B, we added the "href" attribute to the list of allowed
root attributes.

---
**[FIX] website_event: prevents removing sidebar photos**

Steps to reproduce the issue:

- Go to the "/event" page in edit mode.
- Enable the sidebar.
- Click a photo in the sidebar.
- Click the "Delete" button in the image options.
- The image is removed even though it shouldn't be allowed to remove it.

This commit hide the "Delete" button for these sidebar images.

---
**[FIX] website_event: fix editing of figcaption for event sidebar photos**

Steps to reproduce the bug (only on Chrome):

- Go to the "/event" page.
- Enter edit mode.
- Click the "Customize" tab and enable the "Sidebar".
- Try to add a character at the end of the figcaption of the second
photo in the sidebar.
- Bug: it's not possible to add a new character.

This requires further investigation, but the issue comes from how Chrome
handles editing elements inside links. The fact that the <a> element was
set to display inline caused the issue.

This commit fixes the issue by setting the <a> element to display block,
which is more appropriate anyway.

Forward-Port-Of: odoo/odoo#186278

Steps to reproduce: - Create a product having the following attributes: - Color, which has `create_variant`: 'always' - Custom, which has `create_variant`: 'no_variant' - For each attribute, add a few values - Create a sale order for that product, using a combination of both attributes - Go to Inventory/Operation/Procurement/Replenishment - On the corresponding product, click on 'Order Once' - On the created Purchase Order, try to edit the product through the configurator Issue:

Steps to reproduce:
- Create a product having the following attributes:
  - Color, which has `create_variant`: 'always'
  - Custom, which has `create_variant`: 'no_variant'
- For each attribute, add a few values
- Create a sale order for that product, using a combination of both attributes
- Go to Inventory/Operation/Procurement/Replenishment
- On the corresponding product, click on 'Order Once'
- On the created Purchase Order, try to edit the product through the configurator

Issue:
A traceback will appear, as the generated matrix for this product will be a collection of pairs from [Color,Custom] values. But as the moves have no `product_no_variant_attribute_value_ids` to store that information, that part of the information will be lost and the generated orderpoint from which the PO is made will only be using an existing product.product.

While this does not solve the issue, it at least allows to open the product configurator even though the line is faulty.

Note: Same issue appear through a MTO flow, although in this case the product description will be correct. But trying to open the configurator would still lead to a traceback anyway.

opw-4197302

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#188031

In case the quantity of a purchase order line is negative the generated picking will be a delivery but not a return. Meaning validating this delivery will not update quantity received on the purchase order line. This commit makes sur the `to_refund` key on stock move impact the value of `qty_received` only if the stock move is actually a return. opw: 4259022 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -

In case the quantity of a purchase order line is negative the generated picking will be a delivery but not a return. Meaning validating this delivery will not update quantity received on the purchase order line. This commit makes sur the `to_refund` key on stock move impact the value of `qty_received` only if the stock move is actually a return.

opw: 4259022

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#187946

If we only use the community module, there is no interface to activate the automated stock accounting feature on the accounting page. Instead, we have to manually assign group_stock_accounting_automatic to each user. However, from PR odoo/odoo#133254, any setting changes will change all of the property_valuations to 'manual_periodic'. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187826

If we only use the community module, there is no interface to activate the automated stock accounting feature on the accounting page. Instead, we have to manually assign group_stock_accounting_automatic to each user.
However, from PR odoo/odoo#133254, any setting changes will change all of the property_valuations to
'manual_periodic'.




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#187826

For an expense report paid by an employee, the bank account should be set on the employee form and be used to create the Journal Entry and in Register Payment Wizard. enterprise: https://github.com/odoo/enterprise/pull/71080 task-4206895 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188210 Forward-Port-Of: odoo/odoo#181870

For an expense report paid by an employee, the bank account should be set on the employee form and be used to create the Journal Entry and in Register Payment Wizard.

enterprise: https://github.com/odoo/enterprise/pull/71080

task-4206895

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#188210
Forward-Port-Of: odoo/odoo#181870

Since we moved away from activity_schedule in odoo/odoo#107804, the mail_activity_automation_skip context doesn't work anymore and activities get created regardless We add a check at the beginning of the function to make the context flag work again --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186898

Since we moved away from activity_schedule in odoo/odoo#107804, the mail_activity_automation_skip context doesn't work anymore and activities get created regardless

We add a check at the beginning of the function to make the context flag work again


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#186898