Odoo Changelog — 2024-11-26

Tuesday, November 26, 2024

44 changes · saas-17.4

Bug Fixes(7)

Resolved issues and error corrections

[FIX] point_of_sale: show internal reference for products

Coresaas-17.4point_of_salepos_restaurant

Point of Sale now shows a product's internal reference in product details and variant selection screens. This helps staff identify the correct item more quickly, especially when products have similar names or variants.

Original PR description

Before this commit, the internal reference was not displayed. With this commit, the internal reference will be shown in the product info popup and for products with variants in the product configurator.

opw-4334505

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point of sale#product references#product variants

[FIX] point_of_sale: respect user language when loading product

PR #188607

Coresaas-17.4point_of_sale

Products loaded into Point of Sale by scanning a barcode now use the language selected by the user. This prevents product information from appearing in the wrong language during checkout, improving clarity for staff and customers.

Original PR description

Before this commit, loading a product with a barcode into the PoS did not respect the user language. This was due to overriding the context when reading the product from the server.

opw-4346227

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point of sale#language#barcode#products

[FIX] mail: fix race condition in scroll to unread test

PR #188399

Coresaas-17.4mail

This fix makes the mail test for jumping to the first unread message more reliable by waiting for scrolling to finish before making further checks. It reduces false test failures during heavy system load, helping keep development and release validation stable.

Original PR description

This PR resolves an issue with the `scroll to the first unread message` test, which occasionally failed due to race conditions.

Several issues were identified with this test:
- We do not wait for the initial scroll to complete, which can lead to race conditions.
- Under high CPU load, the message highlight can be shorter than the scroll. We should wait for the scroll to complete before allowing adjustments to be made.

runbot-103421

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#mail#testing#reliability

[FIX] point_of_sale: prevent showing delete button for paid orders

PR #188286

Coresaas-17.4point_of_sale

The point of sale ticket screen no longer shows the delete button when viewing paid orders. This removes a confusing action that could not be usefully applied, making the order review experience clearer for users.

Original PR description

Before this commit, in the ticket screen, when you filtered paid orders, you could press the delete button, which was useless and confusing.

opw-4339996

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point of sale#paid orders#ticket screen#user interface

[FIX] bus: resolve non-deterministic rate limit test

PR #188461

Coresaas-17.4bus

This update makes an automated test more reliable by adding a small timing buffer so it no longer fails unpredictably. It helps keep quality checks stable and confirms the messaging connection remains active as expected.

Original PR description

The `test_rate_limiting_base_ok` ensures that rate limiting does not activate when requests are made within the accepted delay.

However, the test only waits for the exact delay duration, whereas the rate limiter expects the delay to be strictly greater than the threshold.

This PR introduces a small additional wait time before each request to ensure it falls within the accepted range. It also verifies that the WebSocket (WS) remains connected at the end of the test.

runbot-73027

#tests#rate limiting#websocket

[FIX] web: display buttons correctly in pdf

PR #186907

Coresaas-17.4web

Buttons added to sales quotation terms and conditions now display correctly when printed as PDF. This fixes missing button styling in generated reports, improving document appearance and consistency for customers.

Original PR description

Steps to reproduce the issue:
=============================
- Add a button in terms and conditions in an sale quotation
- Print it as PDF
- The button styles are missing

Origin of the issue:
====================
After [1] the buttons are defined using css variables which are not supported by wkhtmltopdf.

Solution:
=========
Redefine the button styles for reports using scss variables in the same way they are done in `bootstrap_review_backend.scss`

opw-4311049

[1]: https://github.com/odoo/odoo/commit/058212e12b5079eba870bde9775fe98f27928935

#pdf#reports#buttons#styling

[FIX] hr_work_entry_contract_enterprise: add year scale

PR #73820

Enterprisesaas-17.4hr_work_entry_contract_enterprise

Selecting the "This year" filter in Payroll work entries no longer triggers an error. The work entries Gantt view now supports the yearly scale, so users can create entries from that view with dates set to the relevant month boundaries.

Original PR description

Steps
- install hr_work_entry_contract_enterprise
- Payroll > Work Entries > Select "This year" filter
- ** UncaughtPromiseError > OwlError **

Cause
With the addition of variable time ranges in Gantt, a new `year` scale is selectable but is missing from the view.

Change
Add year scale. When clicking on a cell or clicking on the "New" button, the start and end date of the work entries to create will be the beginning and end of the month.

opw-4321645

#payroll#work entries#gantt#year filter

Other(37)

Miscellaneous changes

[FW][FIX] web: prevent crash when DnD property without group

PR #188266

Coresaas-17.4web

Original PR description

Steps to reproduce
==================

- Install crm
- Add a single property
- Drag and drop it to the second group

=> TypeError: Cannot read properties of undefined (reading 'elements')

Cause of the issue
==================

A properties field is composed of a list of property stored in a JSON
object.

A property can either be a separator, or any other type, char, bool, ...

The properties field has a columns props.

If we either have no separator, or we have only one and it is at the
first position, we enter the split mode. This means that properties are
displayed across the available columns.

If we move a property in a group, it means we wan't that property to
stay in that group. When we're in split mode, we need to add the least
amount of new separators so that we get the expected layout.

In some cases, it wasn't possible to get the actual group where we dropped
a property.

This can happen for example when the target was inside an empty group
with a default invisible separator (it has no name).

In some cases also, the behavior wasn't simply what was expected.

opw-3961445

Forward-Port-Of: odoo/odoo#169056

Before this commit, the internal reference was not displayed. With this commit, the internal reference will be shown in the product info popup and for products with variants in the product configurator. opw-4334505 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Before this commit, loading a product with a barcode into the PoS did not respect the user language. This was due to overriding the context when reading the product from the server. opw-4346227 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This PR resolves an issue with the `scroll to the first unread message` test, which occasionally failed due to race conditions. Several issues were identified with this test: - We do not wait for the initial scroll to complete, which can lead to race conditions. - Under high CPU load, the message highlight can be shorter than the scroll. We should wait for the scroll to complete before allowing adjustments to be made. runbot-103421 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Before this commit, in the ticket screen, when you filtered paid orders, you could press the delete button, which was useless and confusing. opw-4339996 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The `test_rate_limiting_base_ok` ensures that rate limiting does not activate when requests are made within the accepted delay. However, the test only waits for the exact delay duration, whereas the rate limiter expects the delay to be strictly greater than the threshold. This PR introduces a small additional wait time before each request to ensure it falls within the accepted range. It also verifies that the WebSocket (WS) remains connected at the end of the test. runbot-73027

Steps to reproduce the issue: ============================= - Add a button in terms and conditions in an sale quotation - Print it as PDF - The button styles are missing Origin of the issue: ==================== After [1] the buttons are defined using css variables which are not supported by wkhtmltopdf. Solution: ========= Redefine the button styles for reports using scss variables in the same way they are done in `bootstrap_review_backend.scss` opw-4311049 [1]: https://github.com/odoo/odoo/commit/058212e12b5079eba870bde9775fe98f27928935

Steps - install hr_work_entry_contract_enterprise - Payroll > Work Entries > Select "This year" filter - ** UncaughtPromiseError > OwlError ** Cause With the addition of variable time ranges in Gantt, a new `year` scale is selectable but is missing from the view. Change Add year scale. When clicking on a cell or clicking on the "New" button, the start and end date of the work entries to create will be the beginning and end of the month. opw-4321645

Steps to reproduce ================== - Install crm - Add a single property - Drag and drop it to the second group => TypeError: Cannot read properties of undefined (reading 'elements') Cause of the issue ================== A properties field is composed of a list of property stored in a JSON object. A property can either be a separator, or any other type, char, bool, ... The properties field has a columns props. If we either have no separator, or we have only one and it is at the first position, we enter the split mode. This means that properties are displayed across the available columns. If we move a property in a group, it means we wan't that property to stay in that group. When we're in split mode, we need to add the least amount of new separators so that we get the expected layout. In some cases, it wasn't possible to get the actual group where we dropped a property. This can happen for example when the target was inside an empty group with a default invisible separator (it has no name). In some cases also, the behavior wasn't simply what was expected. opw-3961445 Forward-Port-Of: odoo/odoo#169056

Steps to reproduce: - Create a product having the following attributes: - Color, which has `create_variant`: 'always' - Custom, which has `create_variant`: 'no_variant' - For each attribute, add a few values - Create a sale order for that product, using a combination of both attributes - Go to Inventory/Operation/Procurement/Replenishment - On the corresponding product, click on 'Order Once' - On the created Purchase Order, try to edit the product through the configurator Issue: A traceback will appear, as the generated matrix for this product will be a collection of pairs from [Color,Custom] values. But as the moves have no `product_no_variant_attribute_value_ids` to store that information, that part of the information will be lost and the generated orderpoint from which the PO is made will only be using an existing product.product. While this does not solve the issue, it at least allows to open the product configurator even though the line is faulty. Note: Same issue appear through a MTO flow, although in this case the product description will be correct. But trying to open the configurator would still lead to a traceback anyway. opw-4197302 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188031

Problem --------- Additional attachments linked to an Email Template used in the Send & Print are completely ignored. They should not, and it's especially useful for Timesheets. Steps --------- 1. Install Accouting, Timesheet and Sales 2. In debug, access mail templates 3. Go to the 'Invoice: Sending' record > Setting tab 4. In Dynamic Reports, add 'Timesheet' 5. Go to sale 6. Create an SO with 'Junior Architect' product for 10 units 7. Confirm the SO 8. Click the Timesheet widget on the SO form view 9. Register some hours for today (for example 3 hours) 10. On the SO Form view, click 'Create Invoice' 11. Select the option to invoice timesheeted hours and select from today to today as the date range 12. Create the Invoice and post 13. Send & Print -> The timesheet report appears in the send and print widget, when you click send, the timesheet report is actually not sent. Solution --------- 1. Add a placeholder in the send&print widget, the placeholders are stored in the `mail_attachments_widget` used for such purposes. The dynamic reports are defined with an new key: `dynamic_report` to differenciate them from the `manual` attachments and the invoice PDF. This new key eases the complexity to retreive and create the attachments fom the placeholders list. 2. Add a method when sending the mails to generate the dynamic reports only if the reports have not been removed in the S&P widget (`skip != False`). Since the attachments placed in the mails are a collection of elements from `mail_attachments_widget` that possess a valid attachment ID. We add the relevant attachment data in the mail_attachments_widget of the invoice. task-4283972 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#187381

**task-4280164 opw-3985404** --- **[FIX] web_editor: removes figure parent of removed image** Steps to reproduce the issue: - In website, edit mode. - Drag and drop a "Picture" snippet onto the page. - Click the image in the "Picture" snippet. - Delete the image by clicking the "Remove" button in the image options. - Inspect the DOM of the "Picture" snippet. - Bug: The figure element which wrapped the image is still there. After this commit, when an image wrapped by a figure element is removed, the figure is also removed. --- **[FIX] web_editor: allows to edit events sidebar photos link** Before this commit, it was not possible to edit the link of the events sidebar photos. This occurred for 2 reasons: A - The image link option didn't work with images wrapped in a figure element. B - After fixing point A, the "href" attribute modification was ignored when saving the "/event" page. Steps to reproduce A: - Go to the "/event" page in edit mode. - Click on the 'Customize' tab and enable the sidebar. - Click a photo in the sidebar. - Bug: the URL input for setting the link is not available in the "Image" options. Steps to reproduce B (after fixing A): - Go to the "/event" page in edit mode. - Click on the 'Customize' tab and enable the sidebar. - Click a photo in the sidebar. - Edit the "Your URL" input. (e.g. [www.odoo.com](http://www.odoo.com/)) - Save the page. - Click the image with the modified link. - Bug: the new link was not saved. To fix issue B, we added the "href" attribute to the list of allowed root attributes. --- **[FIX] website_event: prevents removing sidebar photos** Steps to reproduce the issue: - Go to the "/event" page in edit mode. - Enable the sidebar. - Click a photo in the sidebar. - Click the "Delete" button in the image options. - The image is removed even though it shouldn't be allowed to remove it. This commit hide the "Delete" button for these sidebar images. --- **[FIX] website_event: fix editing of figcaption for event sidebar photos** Steps to reproduce the bug (only on Chrome): - Go to the "/event" page. - Enter edit mode. - Click the "Customize" tab and enable the "Sidebar". - Try to add a character at the end of the figcaption of the second photo in the sidebar. - Bug: it's not possible to add a new character. This requires further investigation, but the issue comes from how Chrome handles editing elements inside links. The fact that the <a> element was set to display inline caused the issue. This commit fixes the issue by setting the <a> element to display block, which is more appropriate anyway. Forward-Port-Of: odoo/odoo#186278

### Steps to reproduce the issue: 1. Create an Invoice with "ODOO_BUG" as payment reference 2. Create a Bank Transaction with the same amount and customer as the Invoice and "ODOO_BUG" as Label 3. The Transaction and the Invoice are automatically matched 4. Create an Invoice with "ODOO BUG" as payment reference 5. Create a Bank Transaction with the same amount and customer as the Invoice and "ODOO BUG" as label 6. The Transaction and the Invoice are not automatically matched ### Explanation: When evaluating `st_line_text_values` in `_get_invoice_matching_st_line_tokens`, the values are split at every whitespace. When trying to find `account.move.line` that match the tokens resulting from the operations, every `name`, `move_id.name` or `move_id.ref` with a whitespace in it will not be recognized due to the whitespaces being removed from the `account.bank.statement.line` side. ### Fix reasoning: From a business perspective, no Invoice/Payment/Bill reference should have a space in it bar some already covered exceptions. To avoid performance heavy queries, the text value will simply be added to `exact_tokens` and treated as such, allowing for an automatical reconciliation between an `account.move.line` and an `account.bank.statement.line` if their refs match perfectly. opw-4114296 Forward-Port-Of: odoo/enterprise#71431

Bug Fixes(7)

[FIX] point_of_sale: show internal reference for products

[FIX] point_of_sale: respect user language when loading product

[FIX] mail: fix race condition in scroll to unread test

[FIX] point_of_sale: prevent showing delete button for paid orders

[FIX] bus: resolve non-deterministic rate limit test

[FIX] web: display buttons correctly in pdf

[FIX] hr_work_entry_contract_enterprise: add year scale

Other(37)

[FW][FIX] web: prevent crash when DnD property without group

Bug Fixes(7)

[FIX] point_of_sale: show internal reference for products

[FIX] point_of_sale: respect user language when loading product

[FIX] mail: fix race condition in scroll to unread test

[FIX] point_of_sale: prevent showing delete button for paid orders

[FIX] bus: resolve non-deterministic rate limit test

[FIX] web: display buttons correctly in pdf

[FIX] hr_work_entry_contract_enterprise: add year scale

Other(37)

[FW][FIX] web: prevent crash when DnD property without group

[FW][FIX] hr_holidays: Add mail_activity_automation_skip check

[FW][FIX] web: DomainSelector: shorten descriptions of long lists

[FW][FIX] web: missing properties field definitions

[FW][FIX] stock_account: avoid changing property_val for any setting change

[FW][FIX] purchase_stock: decrease received quantity if no return

[FW][FIX] product_matrix: avoid crash on generated PO lines

[FW][FIX] web: improve a bit the perf of list view

[FW][FIX] hr: make civil status translatable.

[FW][IMP] account: Fix dynamic PDF reports generation on send & print

[FW][REV] sale_project: make sol field read-only if no sale access

[FW] 16.0 fix website event sidebar photos bvr

[FW][FIX] hr_skills_survey: fix False in employee certificate

[FW][FIX] account: Fix loading demo data for branches.

[FW][FIX] l10n_{cz,sk}: View company_registry based on country_code on res.partner view

[FW][FIX] discuss: ensure aspect ratio of call invitation avatars

[FW][FIX] web: avoid notification on unchanged invalid record

[FW][FIX] web_editor: fix toolbar appearing and disappearing

[FW][FIX] l10n_il: fix default purchase tax

[FW][FIX] l10n_mx_edi_extended: MX address formatting

[FW][FIX] web: improve a bit the perf of list view

[FW][FIX] l10n_ch_hr_payroll: make civil status translatable.

[FW][IMP] l10n_ar_edi: Error 10015 improve hint msg

[FW][IMP] l10n_us_hr_payroll: rename salary rule and category gross pay

[FW][FIX] hr_payroll_account: Don't create demo account 123456 in branches

[FW][FIX] documents: disable domain selection

[FW][FIX] data_merge_helpdesk : Avoid traceback when merging two helpdesk tickets

[FW][IMP] l10n_in_reports: revise threshold for unregistered customers

[FW][FIX] l10n_cl_edi_pos : show the date on receipt even without VAT

[FW][FIX] l10n_mx_reports: display partners infos on all DIOT lines

[FW][FIX] web_studio: pass active_ids when loading the current action int…

[FW][FIX] web_studio: no_address_format in context

[FW][FIX] web_grid: adapt Many2OneField to new URL format

[FW][FIX] web_studio: update menu editor dialog when modifying a menu

[FW][FIX] account_accountant: auto reconciliate moves with spaces in ref

[FW][FIX] l10n_hk_hr_payroll: fix internet allowance salary rules

[FW][FIX] timesheet_grid: check unit_amount encoded only for timesheets