Tuesday, November 26, 2024
2 changes · saas-17.4
Resolved issues and error corrections
Refunds in the Peruvian Point of Sale now keep the customer from the original sale instead of reverting to the generic final consumer. This helps staff process refunds with the correct customer details and avoids blocked or inaccurate refund flows.
Original PR description
### Steps to reproduce: - Install "l10n_pe_pos" - Switch to a Peruvian company and open a POS session - Sell a product with a partner specified (different from "Consumidor Final") - Try to refund the order - The partner is back to "Consumidor Final" and can't be changed ### Cause: The code supposed to put back the right partner is checking a wrong field (`this.pos.consumidorFinalAnonimoId` is undifined) so the partner is not correctly set. ### Solution: Use the correct field : `this.pos.session._consumidor_final_anonimo_id` opw-4282195
Colombian invoicing users can now send DIAN electronic invoices and reload DIAN journal settings without being blocked by administrator-only access rules. The change keeps sensitive certificate data protected while allowing normal billing workflows to complete.
Original PR description
### Steps to reproduce the issue: 1. In a Colombian Company, create an Invoice with a Product with UNSPSC 2. Confirm then Send & Print (check DIAN option in wizard) 3. Access Error: > You are not…
### Steps to reproduce the issue: 1. In a Colombian Company, create an Invoice with a Product with UNSPSC 2. Confirm then Send & Print (check DIAN option in wizard) 3. Access Error: > You are not allowed to access 'Colombian operation modes of DIAN used for different documents' (l10n_co_dian.operation_mode) records. > > This operation is allowed for the following groups: > - Administration/Settings ### Explanation: Access Rights for `l10n_co_dian.operation_mode` are reserved to `base.group_system`. During tests, discovered an Access Rights issue with `l10n_co_dian.certificate` as well when trying to "Reload DIAN configuration" of `account.journal`. ### Fix reasoning: Log note from MASI on the ticket: add Read Access for Invoicing / Billing on `l10n_co_dian.operation_mode` Since `l10n_co_dian.certificate` should not be openly accessible, we will use sudo to retrieve them while sending the request. Testing access rights for invoicing, sudo addition and journal flow at the same time. opw-4242695