Wednesday, November 27, 2024
3 changes · saas-17.4
Resolved issues and error corrections
Creating a sales order from a billable project now correctly shows a warning if the order has no service product. This prevents users from creating or confirming project-linked sales orders that cannot support timesheet billing.
Original PR description
Before this commit, when the user wants to create a SO via the stat button displayed in the project form view when the project is billable without any SO created. The SO to create should have at…
Before this commit, when the user wants to create a SO via the stat button displayed in the project form view when the project is billable without any SO created. The SO to create should have at least one service product to be able to timesheet on it inside the project. To make sure a service product will be in the lines of the newest SO, an user error should be displayed once no service product is inside lines of the SO created to avoid letting the user to create the SO until there is no service product. This commit makes sure the context is correctly passed to the action to be able to trigger the warning once it is needed. Steps to reproduce the issue: ============================ 1. install `sale_project` module 2. create new billable project 3. go to the form view of that new project 4. set a customer to that project 5. click on `0 Sales Order\nMake Billable` stat button to create a new SO linked to that project 6. Create/Confirm the SO without any service products in its lines Expected behavior ----------------- The user error should be displayed since no service product is inside the lines of new SO. Actual Behavior --------------- The SO is created/confirmed without any errors. task-4291437
The accounting journal dashboard now includes both invoices or bills and their related credit notes or refunds for sales and purchase journals. This makes dashboard totals and linked list views consistent, giving users a more complete and reliable picture of journal activity.
Original PR description
The informations displayed on journal dashboard on sale/purchase journals should include both invoices/bills and credit notes/refunds, as well as the moves shown in the list view when coming from the journal card hyperlinks. opw-4328137
Validating a delivery with Sendcloud could fail when a shipment contained products exceeding the carrier's maximum weight. This fix prevents the crash so users receive the intended handling instead of an error blocking delivery validation.
Original PR description
When the customer clicks on the validate button in delivery with Sendcloud carrier,
a traceback will appear.
Steps to reproduce the error:
- Enable Sendcloud Connecter
- Go to Inventory > Configuration > Delivery Methods > Create new Method >
Provider: SendCloud > Max Weight: 2 kg
- Create a new product A > Type: Goods > Weight: 10 kg
- Create a new Delivery > add Product A > Carrier: SendCloud > Validate
Traceback:
```
File "home/odoo/src/enterprise/18.0/delivery_sendcloud/models/sendcloud_service.py", line 389, in _prepare_parcel
product_moves = format_list(self.env, overweight_products.mapped('name'))
AttributeError: 'SendCloud' object has no attribute 'env'
```
https://github.com/odoo/enterprise/blob/5dd7022e079bbb45492356a66a60c98a249cec8a/delivery_sendcloud/models/sendcloud_service.py#L389
Here, ``self`` is used instead of ``picking``,
So, It will lead to the above traceback.
sentry-6086972478