Daily updates from Odoo
Friday, November 29, 2024
25 changes · 18.0
Resolved issues and error corrections
Purchase order reports now display tax descriptions correctly when they include formatting. This prevents confusing or incorrectly shown tax information on documents sent to vendors.
Original PR description
Changed the tax display in the purchase order template from `t-esc` to `t-out` to ensure proper HTML rendering of tax labels. This adjustment is necessary to display the tax descriptions correctly without escaping HTML content, which was causing display issues in the rendered document. This change addresses the need for accurate representation of tax information in purchase orders, improving the clarity and correctness of the document output. opw-4313981 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures Stripe payment forms can open properly from customer payment links by providing an initial amount. Customers can still choose installment or early payment options afterward, reducing failed payment starts.
Original PR description
Stripe (inline payment form) expect to have a default `amount` value because it need to initialize a payment "intent" when opening the payment form, so before the user will be able to choose between one of the different installment/epd payment options. This commit set that default amount to the total due amount, so that Stripe can successfully create the initial payment intent, the amount being then updated JS side when user choose any of the available option. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The HTML editor now keeps the displayed font name in sync when users undo or redo formatting changes. This prevents confusing toolbar information after editing formatted content, such as in todo notes.
Original PR description
Steps to reproduce the issue: ============================= - Create a new todo - Add some content - Select it and choose a font - Press `ctrl+z` - The display name doesn't get updated Origin of the issue: ==================== We don't update the state of the font_selector after redo/undo. Solution: ========= We need to lift the state from font_selector to the font_plugin so we can detect commands and events and upate the displayName accordingly task-4243952
Point of Sale now uses the same tax total calculation approach as accounting, improving consistency between receipts, orders, and financial records. This also fixes rounding issues for global tax rounding and improves support for cash rounding methods, reducing discrepancies at checkout and in reports.
Original PR description
Now we have an helper ensuring the consistency between the computation of the tax totals in both python & javascript, let's use it. Related: https://github.com/odoo/enterprise/pull/72597 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Worldline token payments now include a safeguard so repeated processing of the same payment request is recognized as the same transaction. This reduces the risk of customers being charged more than once when payment status updates happen at the same time.
Original PR description
[FIX] payment_worldline: add idempotence key for token payments Prevents a same 'request for payment' transaction to be considered as different by the provider. This avoids multiple payment for a same transaction when the webhook's response causes a concurrent update leading to a reprocess of the initial request. task-2894752
This update improves the reliability and clarity of Odoo's automated test tools, especially around timing, simulated user actions, form submissions, and reporting. It helps teams catch issues more consistently while reducing false failures and confusing test output, with little direct impact on day-to-day users.
Original PR description
## Pull Request HOOT (PRHOOT) - part 27 Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4:…
## Pull Request HOOT (PRHOOT) - part 27 Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4: https://github.com/odoo/odoo/pull/153203 Part 5: https://github.com/odoo/odoo/pull/153425 Part 6: https://github.com/odoo/odoo/pull/153700 Part 7: https://github.com/odoo/odoo/pull/154054 Part 8: https://github.com/odoo/odoo/pull/154579 Part 9: https://github.com/odoo/odoo/pull/155073 Part 10: https://github.com/odoo/odoo/pull/155639 Part 11: https://github.com/odoo/odoo/pull/156255 / https://github.com/odoo/enterprise/pull/58135 Part 12: https://github.com/odoo/odoo/pull/156869 Part 13: https://github.com/odoo/odoo/pull/158384 / https://github.com/odoo/enterprise/pull/59019 Part 14: https://github.com/odoo/odoo/pull/158916 Part 15: https://github.com/odoo/odoo/pull/160292 / https://github.com/odoo/enterprise/pull/59971 Part 15.5: https://github.com/odoo/odoo/pull/166463 Part 16: https://github.com/odoo/odoo/pull/166311 Part 17: https://github.com/odoo/odoo/pull/168328 Part 18: https://github.com/odoo/odoo/pull/171004 / https://github.com/odoo/enterprise/pull/65657 Part 19: https://github.com/odoo/odoo/pull/171242 / https://github.com/odoo/enterprise/pull/65767 Part 20: https://github.com/odoo/odoo/pull/173332 / https://github.com/odoo/enterprise/pull/66895 Part 21: https://github.com/odoo/odoo/pull/174337 Part 22: https://github.com/odoo/odoo/pull/176777 / https://github.com/odoo/enterprise/pull/68721 Part 23: https://github.com/odoo/odoo/pull/179660 / https://github.com/odoo/enterprise/pull/69728 Part 24: https://github.com/odoo/odoo/pull/181971 Part 25: https://github.com/odoo/odoo/pull/183358 Part 26: https://github.com/odoo/odoo/pull/186403 / https://github.com/odoo/enterprise/pull/73361 Enterprise: https://github.com/odoo/enterprise/pull/74093 This pull requests brings various improvements and fixes to Hoot and the Odoo unit test ecosystem. See the different commit messages for more details. Note: these changes are made in stable to avoid having to support multiple versions of the HOOT API. As such, these changes are intended to be strictly limited to unit tests as to not put the rest of the code base at risk. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where links and bold text in the email template editor could repeat or display incorrectly because some elements were written in a format browsers do not handle well. Users editing templates such as quotations should now see cleaner, more reliable content previews.
Original PR description
Issue: ====== Self-closing `a` and `strong` elements doesn't render properly. Steps to reproduce the issue: ============================= - Go to email templates - Open "Send Quotation" template - You will see the `a` element of the attachment is appearing a lot of times. Origin of the issue: ==================== Since the content of the template is in xml, using self closing `a` element is acceptable but it's not valid html so using the same content of xml into html will produce incorrect ui. Solution: ========= Change the self closing `a` and `strong` elements into opening and closing tags. opw-4322575
The point of sale cash move popup now keeps the confirm button disabled when the reason field contains only spaces. This prevents blank or meaningless cash movement reasons from being submitted, improving data quality for store operations.
Original PR description
Description of the issue/feature this PR addresses: In the cash move popup of the point of sale, the confirm button is currently enabled when the reason input field contains only whitespace, allowing submission with invalid input. Current behavior before PR: The confirm button is active even when the reason input field only contains empty spaces, which can lead to erroneous or empty reason entries. Desired behavior after PR is merged: The confirm button will only be enabled when the reason input field contains valid, non-whitespace characters, ensuring that only meaningful input allows confirmation. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The withholding wizard now automatically fills in the TDS journal configured in settings. This prevents users from having to manually select the journal and helps ensure Indian withholding tax entries are created with the correct accounting setup.
Original PR description
Before This Commit: - The TDS journal is set in the settings, but when opening the withhold wizard, the journal is not populated in the wizard. After This Commit: - The TDS journal now correctly populates in the withhold wizard. Reason: - The compute method `_compute_journal` depends on `company_id`. The compute method of `company_id` depends on `related_move_id` and `related_payment_id`, but these two fields are not defined in the view. As a result, `company_id` is not computed. Since `company_id` is not set, `_compute_journal` cannot retrieve the journal from the settings. - The fields `related_move_id` and `related_payment_id` were mistakenly removed in this PR: https://github.com/odoo/odoo/pull/178572 Task-4366374
This fix makes automated checks for the website editor's link popover behave consistently. It reduces random test failures, helping development teams validate changes with more confidence and less wasted investigation time.
Original PR description
Before this commit: Tests involving the opening and closing of the link popover by clicking the link button could fail unpredictably After this commit: They are updated to ensure deterministic behavior --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
OAuth login routes now avoid a read-only processing mode when they may need to create a user account or record a login. This prevents some OAuth sign-ins from failing and helps ensure login activity is saved correctly.
Original PR description
Follow-up of #186319 and #186786 These routes are auth=none but aren't technically read-only, as they can create the user record and need to record the login event anyway. The signin one even as a broad catch for Exception, which would prevent the readonly->read-write fallback to work, leading to a failed login.
This fixes an issue on Odoo IoT devices where restarting the Odoo service could also stop the remote debugging connection. The remote debugging tunnel now continues running independently, reducing interruptions during support and troubleshooting.
Original PR description
In IoT image 24.10, the Odoo service was changed to a systemd service (rather than init). A side effect of this change is that all subprocesses are killed when the service is stopped. This causes the `ngrok` to be killed while remote debugging if you restart the Odoo service. This PR changes `ngrok` to run as a service, which is then started by Odoo. This means it now keeps running when Odoo is stopped. task-4363825 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an editor issue where inserting a dynamic field next to existing text placed it on the next line. This keeps edited content formatted as expected and reduces manual cleanup for users.
Original PR description
**Current behavior before PR:** - When adding a dynamic field next to text nodes, the dynamic field would be inserted on the following line. **Desired behavior after PR is merged:** - The dynamic field is now added on the same line as the text. task:4220919
Fixes an issue in the HTML editor where a collaborator's avatar could disappear or move incorrectly after deleting content or adding new lines in a shared document. This keeps live collaboration indicators accurate, helping users see where others are working in real time.
Original PR description
Issue: ====== Collaborator avator disappears after delete Steps to reproduce the issue: ============================= - Open to do with 2 browsers - Write 2 lines - Put the selection of one in first…
Issue: ====== Collaborator avator disappears after delete Steps to reproduce the issue: ============================= - Open to do with 2 browsers - Write 2 lines - Put the selection of one in first line - Put the selection of the other in the second line - Select all the second line and delete - The avatar of the collaborator you delete with will disappear from the others view. Origin of the issue: ==================== `selectionchange` on document isn't triggered because : - The delete doesn't trigger it by default from the browser. - In `setSelection` in `selection_plugin` we only trigger the `selectionchange` by the line of `setBaseAndExtent` which is not triggered when the line is empty because the document selection is the `p` element and the given selection from the parameters is also the `p` element. In the other case where there is some text left, the document have the text node as anchor node while the given params have the p element so we change the selection and we trigger `selectionchange`. We need `selectionchange` to be triggered because it calls `onSelectionChange` which we use to notify the peers that our selection is changed and dispath the `oe_history_set_selection` command. So after this flow, the peer selection isn't changed and the avatar disappears because `oe_history_step` will call `onExternalHistorySteps` and then will call `refreshSelection` in the avatar plugin which will update the position and image of the collaborator. Since the text element is deleted and we don't have a new selection, `drawPeerAvatar` will find the node by its id but it's not connected to the dom so it will exit in the `anchorBlock` if condition. Solution: ========= We remove ranges and then we put selection again to force trigger the selectionchange. task-4166179w
Website forms will now treat blank required fields as missing values instead of saving them as empty text. This keeps website behavior consistent with regular forms and helps prevent incomplete records from being saved.
Original PR description
Prior to this commit, any empty field saved from the website would write an empty string as the value, thus bypassing the required constraints. Functionally, this is surprising because an empty required field on a form view would trigger an error but would save without issue in website. This commit fixes that issue by replacing the empty string by False which will trigger the required constraint.
The main Projects folder in Documents is now visible as read-only by default. This helps users find and access document folders for the projects they are already allowed to work on, without unintentionally granting edit access to the main folder.
Original PR description
The "Projects" folder is currently hidden for everyone by default. This doesn't make sense, as we want people to have access to the folders of projects they have access to. This PR makes the folder read-only by default.
The timesheet leaderboard now shows the billable time target for the employee in the currently selected company. This prevents users linked to employees in multiple companies from seeing the wrong target, improving accuracy in performance tracking.
Original PR description
Steps to reproduce: 1- Create 2 companies A and B 2- Create 2 employees (one for each company). 3- Assign 2 different values for billable_time_target to each employee. 4- Assign both employees to the same user 5- When the env company is A, the displayed value in leaderbord is the one from the user employee in company B instead of A (same as the env company) Source: - get_billable_time_target gets the values for all employees without filtering on the company, it returns a list and randomly, the js takes the first value. Fix: - get_billable_time_target filters on env.company - get_all_billable_time_targets was also fixed to filter with env.company instead of env.user.company task-4222875
The Italian point of sale now avoids automatically printing the same fiscal receipt again when a cashier returns to the receipt screen. This reduces accidental duplicate prints, saving time and preventing confusion during checkout.
Original PR description
before this PR, the fiscal printer would systematically reprint the last loaded order upon returning to the receipt screen. After this PR, the receipt is printed automatically only once. opw-4367156 opw-4338402 opw-4306960 opw-4328481 opw-4351925
Cancelled restaurant orders are now immediately communicated to the preparation display. This helps kitchen staff see cancellations right away without needing a refresh or waiting for another order update.
Original PR description
Currently, when cancelling an order, the notification is not sent to the preparation display. Steps to reproduce: ------------------- * Open both restaurant and preparation display * In the…
Currently, when cancelling an order, the notification is not sent to the preparation display.
Steps to reproduce:
-------------------
* Open both restaurant and preparation display
* In the restaurant place an order and send it to the kitchen
* Select Action > Cancel order
> Observation: The cancellation is not sent to the preparation display
Note: If you send a new order or refresh the preparation display then you can see that the order has been cancelled.
Why the fix:
------------
When cancelling order, data looks like this
`{'change': True, 'sound': False, 'category_ids': {}}`. Since `category_ids` is empty, `preparation_displays` will alsos be empty which explains why the preparation display does not receive the notification, it is simply not sent.
https://github.com/odoo/enterprise/blob/42b7b322d6c720de45661e3370397adaf74fe1f4/pos_preparation_display/models/preparation_display_order.py#L29-L40
Since all lines are canceled, we include all the different categories they cover. Now `preparation_displays` is not empty and all the displays it covers will receive a notification.
opw-4322600Customers can now make early subscription payments through the portal even when draft invoices already exist. The system cancels those draft invoices first, preventing payment failures and reducing friction in the checkout process.
Original PR description
Before this commit, when customer anticipated payment on portl, it would fail if there were already some draft invoices. This commit ensure the draft invoices are canceled before. In master, we should not create the invoice at all. taskid: 4368057
Fixes an issue where signing an employee contract could fail if the signing request was connected to more than one contract. The system now uses the newest related contract, helping users complete contract signing without interruption.
Original PR description
while signing a contract, it may happen that we end up with a sign request linked to multiple contracts. This will lead to an error when trying to call `_get_sign_request_folder` that has `ensure_one` on the contract. to avoid that we take the newest contract linked to the sign request. opw-4348211
Fixed an automated website rental shopping test that could fail after 11pm because the selected rental time accidentally rolled into the next day. The test now uses a stable future date, improving reliability of validation for the rental purchase flow.
Original PR description
The tour would fail after 11pm as the smallest rental interval for the item is 1 hours leading to default dates leaking into the next day leading to more hours than planned being encoded. By forcing the date to be the first day of the next month we can ensure the date is always valid. Runbot Error 108371
Copying a Knowledge article now correctly updates embedded views such as kanban, card, and list blocks so they point to the copied article's own items. This prevents users from accidentally seeing or working with items from the original article after using Create a Copy.
Original PR description
In the editor refactoring done in Odoo 18, we slightly changed the structure of the embedded props stored in the anchor node of the embedded views. Now, the view context is nested inside the…
In the editor refactoring done in Odoo 18, we slightly changed the structure of the embedded props stored in the anchor node of the embedded views. Now, the view context is nested inside the `viewProps` attribute of the embedded props. When the user creates a copy of an article using the "Create a Copy" button, we iterate over all the embedded views stored in the article and we update the context of the embedded views. This way if they list the article items of the original article, they must list the article items of the newly created article. This logic was introduced to allow people to start from a fresh and "ready-to-use" article. As the context has been moved in the embedded props, the check verifying if the embedded view has a context always fails and the references stored in the context are never updated. As a result, the newly created article has embedded views listing the article items of the original article which is not what we want. To fix the issue, we will read the context from the `viewProps` attribute of the embedded props and remove the last calls to `urllib` we made to encode/decode the embedded view props. Steps to reproduce: 1. Open Knowledge 2. Create an article 3. Insert an embedded view with `/kanban`, `/card` or `/list` 4. Create a few article items from the embedded view 5. Create a copy of the article you created at step 2 by clicking on the "Create a Copy" button from the kebab menu. => The embedded view in the new article lists the article items of the original article and not its own article items. TO BE: As it was the case before Odoo 18, the embedded views should list the article of the newly created article. see: https://github.com/odoo/enterprise/pull/42936 see: https://github.com/odoo/enterprise/pull/67083 task-4343222
Spreadsheet document imports no longer run a production data validation step that is no longer needed. This keeps the feature aligned with current usage while moving that validation responsibility into tests, reducing unnecessary processing in normal operations.
Original PR description
The data validation will be moved in the test modules as its use in production was diminished following https://github.com/odoo/odoo/pull/184846 Task: 4363803
Fixed a display issue in appraisal forms where placeholder text could overlap when users clicked into an input field. This improves readability and makes the form easier to complete.
Original PR description
Steps: - Open the appraisal form. - Click on the input field with the placeholder text. - The placeholder text was overlapping. Cause of the issue: - The input field was not displaying properly due to layout constraints. Fix: - Adjusted the layout to allow proper display of the input field and placeholder. task-4316840