Monday, December 2, 2024
5 changes · saas-17.4
Resolved issues and error corrections
Users now see a clear error if they try to request time off while their account has no employee record in the selected company. This prevents confusing failures and helps users understand what needs to be fixed before submitting leave.
Original PR description
Steps to reproduce: 1. Login as `Mitchell Admin`. 2. Select Indian Company (without selecting any other company). 1. Open `Time Off` app. 3. Click on any day on the calendar. 4. Confirm the time off. 5. An error will occur. In order take a time off from the dashboard, the logged in user must have an employee in the selected company. `Mitchell Admin` doesn't have an employee in the `Indian Company` which causes the bug. This problem is general and happens when any user tries to take a time off from the dashboard without having an employee in the selected company. To solve the issue, an error message will appear to the user if they try to take a time off without having an employee in the selected company. task-4034228
Fixed an issue where changing an employee's home-to-work distance during salary contract setup did not update the employee's private information. This ensures HR records stay consistent with the distance entered in the salary configurator, regardless of the distance unit setting.
Original PR description
To reproduce, sign a new contract in the salary configurator with a different home to work distance. Check the employee's private info and the distance is not updated. The issue happens because the salary configurator works on the field `km_home_work` while there is also `distance_home_work` that works with either miles or kilometers. An inverse was introduced in: https://github.com/odoo/odoo/pull/178160 but it used the wrong field when computing `distance_from_work`. task-4306551 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users can now click a pinned-message notification and be taken to the pinned message even if it has not loaded yet. This makes it easier to find referenced conversations and avoids a frustrating dead-end in channel navigation.
Original PR description
Before this PR, clicking on the "user pinned a message to the channel" notification linked to a not yet loaded message would not scroll to the pinned message. This issue arises because the `highlightMessage` function does nothing if the message's thread is different from the current one. However, when a message is unknown, the thread is also unknown, and the function does nothing. The notification is only displayed in the origin thread of the message, so we can safely pass this information, assuming the message thread and the notification thread are the same.
Customers using translated websites will now see the pickup point selection dialog fully translated, including the title, action button, and closed-day label. This improves the checkout experience for shoppers in non-English languages and avoids confusing mixed-language text.
Original PR description
When you try to ship your products to a pick-up point on the website, you encounter a dialog to choose the exact location of the pick-up point that has the following strings untranslated: "Choose a pick-up point", "Choose this location", and "Closed" (if the pick-up location is closed on someday). This happens because these strings are defined in `delivery` module, which is not a frontend module. This commit redefines those strings in `website_sale` module, which is a fronend module. Task-4328208 OPW-4326840
This update removes leftover customer display code from an earlier point of sale redesign. It helps keep the system cleaner and reduces the chance of confusion or unintended behavior without changing how users interact with the feature.
Original PR description
In acf78c27b12cf014cd80d20ea5853e63ab9ca03f we completely refactored the customer display into it's own owl app, but failed to remove part of the old code. In this commit we fix the issue. Task: 4367166 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr