Thursday, December 5, 2024
2 changes · saas-17.4
Resolved issues and error corrections
This fix prevents internal overlay settings from being treated as live reactive data. It helps avoid unnecessary screen refreshes and potential crashes, improving reliability in the Odoo web interface.
Original PR description
Commit [1] allowed to pass the env to overlays, as a prop. However, when doing so, the env was inserted in a reactive array (`overlays`) which thus made it reactive as well. That reactive env was then used as childEnv for the overlay items. Having a reactive env isn't a good idea, relying on this isn't either. Indeed, changes in the "non reactive" env wouldn't be taken into account. Moreover, it can lead to unexpected excessive re-renderings, or even to crashes (a reactive object is a proxy, and for instance, calling `difference` on a Set wrapped in a proxy crashes). [1] odoo/odoo@7851d85f26c525a90fdb1131c5e4d51a6b140c13 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
PDF pages that were originally rotated now display correctly when users split a document. This prevents confusing previews and helps users split scanned or rotated PDFs accurately in the Documents app.
Original PR description
To reproduce: ============= 1. Go to Documents app 2. Upload a PDF file (one of the attached on the opw) 3. Click on the file to open it 4. Click on the "Split" button the pages on the preview are not displayed correctly Problem: ======== these pdf files, the pages are rotated by 270 degrees so when splitting the pages, the rotation is not taken into account and set to 0 degrees Solution: ========= - set the rotation of the pages to the original rotation when splitting the pdf opw-4216158