Monday, December 9, 2024
10 changes · 17.0
Resolved issues and error corrections
Purchase order PDFs now include the discount information when a discount is configured on an order line. This ensures printed purchase documents match what users see in the purchase order and avoids confusion with vendors or internal approvals.
Original PR description
**Issue:** The discount column is not visible on Purchase Order PDF file. **Expected:** When a discount is configured, it should be displayed on the document. **Steps to reproduce:** - Activate Purchase app; - Go to Purchase > Orders > Request for Quotations; - Create a new RFQ with at least 1 product and a vendor; - Setup a discount (display the column using the options on the right of the table); - Confirm the order; - Using the action button `Print` > `Purchase order`, generate the PDF. **Cause:** The field isn't displayed on the template https://github.com/odoo/odoo/blob/a288317f303f8176e058d04b611064bb457534b3/addons/purchase/report/purchase_order_templates.xml#L51-L56 **Fix:** Backport the Odoo 18 fix (https://github.com/odoo/odoo/commit/6474797ee21c9547f9adb9e58bd9593870cacf6b) that adds the field to the document's XML. opw-4346390 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a typo in an error message shown when an email template cannot be rendered. It improves clarity for users or administrators troubleshooting template issues, with no change to business workflows.
Original PR description
This commit removes a typo in a UserError raised when the rendering of the template fails. Fixes #186447
Contact activity dates now use the date format configured for the current user's language instead of a fixed short format. This keeps dates consistent across Odoo and avoids confusion for users working with customized regional date preferences.
Original PR description
Previously (ref.1) introduced DATE_SHORT,
this commit uses custom format specified in the current language
Reproduce
---
- -i contacts,calendar
- change current language date format to something custom like %m/%b/%y
- open contacts -> activity view
- add some activity-> BUG: Custom date format not used
(Ref.1)
---
[IMP] {test_}mail: allow to keep done activities and improve activity view b6c236df54abb66b30d8643dea797f385d3036f1
opw-4151431
### note, debate
If user uses some long date_format it may not look too nice, however it will keep the date consistent across odoo, consulted with creator and PO.
code originally stems from here https://github.com/odoo/odoo/pull/138135This fix ensures copied databases using the Jordan electronic invoicing module are neutralized so they do not accidentally contact external production systems. It helps support teams investigate customer issues safely without causing real-world effects from test or duplicate databases.
Original PR description
This commit adds the missing neutralization necessary for the l10n_jo_edi module introduced in 18.0 in [1] and then backported to 17.0 in [2] The purpose of the standard neutralization framework is to allow us to create database copies that will not interact with external systems in ways that could impact the production database (or if it is not possible to prevent the interactions, make sure that they are benign or won't result in actual changes), or impact the customers of the operator of the production database. This is mainly useful to allow safe support investigation on database duplicates. [1] https://github.com/odoo/odoo/pull/182983 [2] https://github.com/odoo/odoo/pull/176625
Odoo now more reliably recognizes when Peppol electronic document exchange is running in demo mode, even if no proxy user has been created yet. This prevents demo setups from being treated like live configurations, reducing confusion during testing and setup.
Original PR description
Previously, when no EDI proxy user existed, in some case when the handle_demo ran, it was erronously deducing that the EDI mode was not demo, while it was. This commit fixes and simplifies the deduction of the EDI mode: We check the company in the env, if there is a related Peppol proxy user we take his mode, else we fallback on the dedicated system parameter. task-no
This fix prevents rare Peppol partner lookup failures from causing an unhandled error. It broadens error handling for network-related issues and adds logging so support teams can diagnose problems more easily.
Original PR description
In some rare case, the following call:https://github.com/odoo/odoo/blob/2b15cdecfacdc777b5db1ee151012681c3760899/addons/account_peppol/models/res_partner.py#L89 fails. The call is try-catched but we didn't handle all possible requests exception, only the Connection Error. We therefore instead catch the more general RequestException that will catch all ConnectionError, Timeout, HTTPError, ... We also add a logging to help debugging. task-no
This fixes a display issue where manually resized list columns could stay too wide or too narrow after the browser window changed size. Lists now recalculate their column widths on resize, helping users make better use of available screen space and avoid awkward table layouts.
Original PR description
In a list view, first manually resize a column. Doing so, the table can either overflow (if the column has been extended), or be smaller that the available space. Then, resize the page. Before this commit, the table kept is previous width, i.e. it could not benefit from the potential available space that came from resizing the window. With this commit, we force the whole widths computation to be reset after a window resize. opw~4318312 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This pull request reverts a previous change related to rounding methods in the POS Blackbox module. The update was deemed unnecessary as users primarily interact with these settings through the configuration window, allowing them to manually adjust the appropriate settings. This ensures continued functionality without disrupting the user experience.
Original PR description
This reverts commit 261181bd5ab84418d51310ba7bfa52061ffc893e. Shouldn't touch py files in this module and the change isn't neccesary in this case anyways since in the context of this error, customers will be in the config window. Hopefully they will be able to figure out the correct setting to switch to. Forward-Port-Of: odoo/enterprise#75113
This update eliminates redundant salary rules within the Odoo Enterprise India payroll module. The 'Assignment of Salary' and 'Attachment of Salary' rules were previously duplicated, leading to inefficiencies. This change ensures accurate payroll calculations and streamlines the system.
Original PR description
Currently, the 'Assignment of Salary' and 'Attachment of Salary' rules are duplicated in the salary rules, and the NET formula is the same. I have removed these duplicate rules from the India payroll. task-4383807
Miscellaneous changes
[FIX] base: interval_type is required Steps: - Install CRM - Open Settings/CRM - "Rule-Based Assignment" is disabled - Go to open the scheduled action: "CRM: Lead Assignment" - No interval type defined - Enable it Other steps: - Install CRM - Open Settings/CRM - Enable "Rule-Based Assignment" Repeatedly - Go to open the scheduled action: "CRM: Lead Assignment" - Change the interval to nothing Actual result: - Scheduled actions will not run anymore (cron) - KeyEr
Original PR description
[FIX] base: interval_type is required
Steps:
- Install CRM
- Open Settings/CRM
- "Rule-Based Assignment" is disabled
- Go to open the scheduled action: "CRM: Lead Assignment"
- No interval type defined
- Enable it
Other steps:
- Install CRM
- Open Settings/CRM
- Enable "Rule-Based Assignment" Repeatedly
- Go to open the scheduled action: "CRM: Lead Assignment"
- Change the interval to nothing
Actual result:
- Scheduled actions will not run anymore (cron)
- KeyError: None
- `interval = _intervalTypes[job['interval_type']](job['interval_number'])`
Expected result:
- You cannot enable a scheduled action without an interval_type defined
opw-4370139
opw-4318230
Forward-Port-Of: odoo/odoo#189684