Monday, December 9, 2024
13 changes
1 change
Resolved issues and error corrections
The self-ordering system now correctly determines which product categories are available when the current time is exactly midnight. This prevents rare automated test failures and helps ensure category availability rules behave reliably at all times of day.
Original PR description
The computation of available category was wrong when the current time was exactly midnight. This was causing runbot error on some test that was exactly executed at midnight. runbot error: 104523, 66109, 107831...
1 change
Resolved issues and error corrections
This fix ensures Knowledge article property settings are updated before their related values. It helps prevent inconsistent or failed updates when users change structured information in Knowledge articles.
Original PR description
For property fields, we should always update its definition field before updating its value. https://github.com/odoo/odoo/pull/182599
9 changes
Resolved issues and error corrections
Emoji reactions in Mail are now styled so reactions from others are less visually prominent in dark theme. This makes it easier for users to distinguish their own highlighted reactions while keeping the light theme unchanged.
Original PR description
When message has emoji reactions, they have slightly different visual whether the current user has reacted or not: When the user has reacted, this is highlighted. This works great in white them, but in dark theme the non-self reacted visual was more highlighted, which goes against the intend of highlighting self-reactions more. The problem is that non-self reactions are too distracting in dark theme, which isn't the case in white theme, This comes from borders being too visible. The color of default `border` is too much in dark theme. This commit fixes the issue by using `border-secondary`, which has reduced opacity in dark theme. In white theme, this is unchanged. Before <img width="868" alt="Screenshot 2024-12-09 at 13 03 23" src="https://github.com/user-attachments/assets/963f6b65-a280-4be9-b15f-8a1cdbd562a5"> After <img width="864" alt="Screenshot 2024-12-09 at 13 03 31" src="https://github.com/user-attachments/assets/5c43b705-d750-4370-af5b-2f3ab3dac51e">
2 changes
Resolved issues and error corrections
This pull request reverts a previous change related to rounding methods in the POS Blackbox module. The update was deemed unnecessary as users primarily interact with these settings through the configuration window, allowing them to manually adjust the appropriate settings. This ensures continued functionality without disrupting the user experience.
Original PR description
This reverts commit 261181bd5ab84418d51310ba7bfa52061ffc893e. Shouldn't touch py files in this module and the change isn't neccesary in this case anyways since in the context of this error, customers will be in the config window. Hopefully they will be able to figure out the correct setting to switch to. Forward-Port-Of: odoo/enterprise#75113
This fixes an issue where installing batch picking could unintentionally change the appearance of empty-screen messages across Odoo. The styling is now limited to the intended stock batch and fleet views, keeping other screens visually consistent.
Original PR description
**[FIX] stock_{picking_batch,fleet}: scope no content helper**
Since [1], a CSS rule was changing the size of all the no content
helpers throughout Odoo when `stock_picking_batch` was installed.
This commit fixes that by scoping the rule to its original intent.
opw-4370026
[1]: https://github.com/odoo/odoo/commit/06d1d48199ccfc79a80aea314f75d649b3149dba#diff-87ad06e3496be4ac6761b7052a11d9e9f1464e291d305405aae839f1a4d2ba9cR1
---
In order to achieve this, we needed to add support for the class attribute for graph and pivot views. It is only a matter of RNG validation as the code already support the parsing of the `class` attribute. The following commit is therefore added:
**[FIX] base,web: class attr for `<graph/>` & `<pivot/>`**
Before this commit, the class attribute for `<graph/>` and `<pivot/>` views
was not allowed.
As there is no valid reason not to do so, this commit now allows it.Spellcheck indicators in the Odoo HTML editor now appear only when the user is actively focused on the editor. This keeps red spelling underlines from staying visible in places where rich text content is being viewed but not edited, making screens cleaner and less distracting.
Original PR description
This commit fixes the behavior of spellcheck on the WYSIWIG component, which previously enabled this only on focus. Since we use this element in many scenarios accross Odoo, we don't want red lines to keep their visibility all the time, when the WYSIWIG is not directly focused. ~~A test has been introduced, since the contenteditable attribute was not correctly accessed by the hook.~~
This fix updates an internal website editor test so it matches the allowed customization behavior for button styles. It helps keep quality checks active for the website editor and reduces the risk of regressions in future updates.
Original PR description
In this commit, we fix the test_tour in order to reactivate it from v18. The probleme that is fixed in this commit is that we can't customize a "secondary" button in the sidebar of web editor tools but it is allowed with "custom" button. runbot-error-id~109213 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes an automated online shop test wait for the page address to fully update before checking it. It reduces false test failures, helping teams trust release checks without changing the customer shopping experience.
Original PR description
In this commit, we fix a undeterministic behavior about check the pathname of window in function assertPathName. In this function, we check the url of the window but the url can changes few ms after the DOM has been loaded. So the check can occurs after the DOM has been loaded. To avoid this behavior, we wait for the pathname instead of check it direclty. runbot-error-id~70316
The Knowledge app now lets users create new records from externally embedded views without hitting an error. This restores expected behavior for teams using embedded Knowledge views and prevents interruptions when adding content.
Original PR description
This commit fixes an issue with the external embedded views in Knowledge where the `New` button would raise a traceback. The issue was introduced in the big Knowledge refactor via #67083. This was caused by the action service when the doAction was called inside the createRecord of the ReadonlyEmbeddedViewComponent. The views returned by the find method called upon the action's views array were always undefined. This meant that we never found the correct view to use which raised the traceback. To fix this, the arrow function given to the find method has been updated so that it returns a correct value. task-4367683
The Documents app now silently handles cases where a document access link is used after the document has already been deleted. This prevents confusing “missing record” messages and keeps document cleanup flows smooth for users.
Original PR description
The goal of this commit is to avoid getting an error message when using the /documents/touch/ route for an access_token that no longer exists. This bug was detected in the document_delete_tour where this route is used when the document has already been deleted. This caused a "missing record" message to appear. This commit fixes this behavior.
Dragging a document shortcut to My Drive now places it in My Drive instead of leaving it in the original folder. This makes document organization behave as users expect and reduces confusion when moving shortcuts.
Original PR description
**Before this PR**: Dragging a shortcut to My Drive would create the shortcut within the current folder. **After this PR**: The shortcut will be created in My Drive, rather than remaining in the original folder. **Task**-4313298
A timing issue in the document deletion flow was corrected so the automated deletion check waits for recent access tracking before removing items. This helps keep document deletion behavior reliable and prevents false failures in quality checks.
Original PR description
The logAccess method is a debounce function with a 1000ms delay, which is a good idea to avoid flooding the network in case a user clicks incessantly in the browser. The bug identified in the document_delete_tour tour is that this method is called AFTER the selected item has been deleted... only because of this "debounce". The tour engine is faster than the 1 second it takes µfor the debounce to be executed BEFORE the deletion of the selected document(s). The solution is therefore that this debounce is directly executed when the document deletion modal opens.
This update eliminates redundant salary rules within the Odoo Enterprise India payroll module. The 'Assignment of Salary' and 'Attachment of Salary' rules were previously duplicated, leading to inefficiencies. This change ensures accurate payroll calculations and streamlines the system.
Original PR description
Currently, the 'Assignment of Salary' and 'Attachment of Salary' rules are duplicated in the salary rules, and the NET formula is the same. I have removed these duplicate rules from the India payroll. task-4383807