Wednesday, December 11, 2024
7 changes · 17.0
Resolved issues and error corrections
This fix prevents audit trail checks from treating harmless whitespace changes in email subjects, such as line breaks, as real content changes. Businesses can send follow-up and reminder emails without encountering an audit trail error caused only by subject formatting.
Original PR description
An error can occur when the email subject contains line breaks when the audit trail is enabled.
For example, steps to reproduce using follow-up reports:
1. Add or modify the "Payment Reminder" mail template to add a line break in the subject, like {{ '\n' }
2. Install the 'account_audit_trail' module.
3. Enable audit trail in the settings
4. Attempt to send a follow-up report email to the partner
5. An error will occur: "You cannot remove parts of the audit trail.
Archive the record instead."
The issue arises because the subject is considered different from the original message, prompting Odoo to attempt an update.
New behavior:
We allow any subject whitespace modifications to be ignored whenchecking for changes in the audit trail.
opw-4317844This fixes an internal issue where the mail module used the wrong underlying process when refreshing instant messaging presence status. It helps ensure user availability information is updated reliably without changing how users interact with the system.
Original PR description
The mail module override of `_invalidate_im_status` is calling the wrong super method. This PR fixes the issue. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Webhook automation actions now always receive the expected payload field, even when a request sends an empty JSON value. This prevents crashes in automated workflows and makes webhook behavior more reliable for users.
Original PR description
- Create a web hook - In the web hook action, use the `payload` variable - Call the webhook URL with a POST request with no data The web hook crashes because the variable `payload` is undefined. The root cause comes from [1] which returns `None` in this specific case since `get_data` returns `null`. Since the `payload` is `None`, is is not included in the `eval_context`, leading to a crash. [1] https://github.com/odoo/odoo/blob/4ad762c406c942b1975060756c261444ad5a9971/odoo/http.py#L1574 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Problem: A loyalty rewards points member don't receive their points for their confirmed order if they don't sign into their account when signing their quotation online from a link they received in their email. This bug only occurs if the quotation is set to "online signature" only. The bug is not reproducible when the quotation is set to both "online signature" and "online payment" or if website_sale_loyalty is not installed. Purpose: It is expected that customers should receive their reward
Original PR description
Problem: A loyalty rewards points member don't receive their points for their confirmed order if they don't sign into their account when signing their quotation online from a link they received in…
Problem: A loyalty rewards points member don't receive their points for their confirmed order if they don't sign into their account when signing their quotation online from a link they received in their email. This bug only occurs if the quotation is set to "online signature" only. The bug is not reproducible when the quotation is set to both "online signature" and "online payment" or if website_sale_loyalty is not installed. Purpose: It is expected that customers should receive their reward points for their order without needing to sign in because they accessed the link to sign the quotation from their email. It should be consistent with the behavior exhibited from having "online payment" set for the quotation or without website_sale_loyalty installed. Steps to Reproduce on Runbot: 1. Install Sales app, website_sale_loyalty, loyalty, sale_loyalty 2. Create a loyalty program that reward points based on orders 3. Create a quotation for a partner, set "online signature" in Other info, and click "Send by email" 4. Access the email in Settings > Technical > Emails 5. Copy the "Accept & sign" link and paste into incognito window 6. Sign the quote as a public user 7. Observe that the loyalty card for the partner did not update the points opw-4205826 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#182545
Defines dataset directly on website elements such that it can be overridden by other modules if necessary. This was done due to the override in the `test_themes` module completely overriding all attributes of the website_switcher's dropdown items. Runbot Error 106501 Forward-Port-Of: odoo/odoo#187391
Original PR description
Defines dataset directly on website elements such that it can be overridden by other modules if necessary. This was done due to the override in the `test_themes` module completely overriding all attributes of the website_switcher's dropdown items. Runbot Error 106501 Forward-Port-Of: odoo/odoo#187391
Steps to reproduce: 1. Add a stored computed field on `res.users` that depends on `groups_id` 2. Add a constraint on `res.users` that depends on `groups_id` 3. Give the user a group 4. Modify the given group and add an implied group Result: - The computed field is not recomputed - The constraint is not checked The reason for this is that the users groups are updated with a raw SQL query, and the ORM is not aware of the changes. This is a regression since 5f12e244. This issue w
Original PR description
Steps to reproduce: 1. Add a stored computed field on `res.users` that depends on `groups_id` 2. Add a constraint on `res.users` that depends on `groups_id` 3. Give the user a group 4. Modify the given group and add an implied group Result: - The computed field is not recomputed - The constraint is not checked The reason for this is that the users groups are updated with a raw SQL query, and the ORM is not aware of the changes. This is a regression since 5f12e244. This issue was partially detected and fixed in 459e6dc1, but only for a single constraint. This commit makes sure that the ORM properly propagates the changes to computed fields and all constraints, not just the one that was explicitly checked. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177301
Previously, the fields in the calendar popover were misaligned. This fix ensures proper alignment of the fields. Task-4315829 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188757
Original PR description
Previously, the fields in the calendar popover were misaligned. This fix ensures proper alignment of the fields. Task-4315829 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188757