Odoo Changelog — 2024-12-12

Thursday, December 12, 2024

2 changes · 17.0

Bug Fixes(2)

Resolved issues and error corrections

[FIX] mrp_workorder: display correct WO for an user in shop floor

Enterprise17.0mrp_workorderMedium

This update fixes an issue where users were seeing work orders assigned to other employees, even when using the 'My Work Orders' filter. The problem stemmed from incorrect cache handling after a PIN code was entered. Now, users will only see work orders assigned to their own account, ensuring accurate shop floor visibility.

Original PR description

### Steps to Reproduce
* Navigate to the Employees app and set a PIN code for Mark Demo
* In the Manufacturing app, assing a work order to Mark Demo and another to Michael Admin
* Open the Shop Floor interface, adding Michael Admin and Mark Demo as active employees
* Click on the My WO filter and select Michael
* Switch to Mark Demo and enter his PIN code

### Current Behavior
* The work orders assigned to Michael are displayed for Mark, even with the My WO filter enabled.

### Expected Behavior
Only the work orders assigned to Mark should be
displayed

### Reason
This issue occurs when a PIN is activated for an employee. When the PIN validation pop-up is displayed, the cache cleanup is performed for the previously logged-in user rather than the newly connected user. Consequently, the old user's workorders remain visible because the cache is not refreshed correctly.

### Fix
Ensure that the cache is cleared only after the PIN is successfully validated and the user is connected. Additionally, verify that the My WO filter corresponds to the newly connected user before updating the cache. This will ensure that only the relevant work orders are displayed.

opw-4256568

#work orders#shop floor#user permissions

[DRAFT][FIX] pos_preparation_display: fix kitchen display sorting

PR #75564

Enterprise17.0pos_orderMedium

This update fixes an issue where the kitchen display incorrectly prioritized display lines when reducing product quantities in POS orders. Now, the system correctly sorts display lines based on their stage (e.g., 'To Cook', 'Ready'), ensuring the most relevant line is updated first. This improves the efficiency of order preparation.

Original PR description

In a POS restaurant order, when reducing the product quantity of an order line, the reduced display line in the preparation display was always the first one created, regardless of which order line…

In a POS restaurant order, when reducing the product quantity of an order line, the reduced display line in the preparation display was always the first one created, regardless of which order line was changed.

Steps to reproduce:

1.  In the POS restaurant, add a product with a quantity of 2 and an internal note. Confirm the order.
2.  Add another order with the same product and internal note but with a quantity of 5.
3.  In the kitchen display, change the stage of the first display line (quantity 2) from "To Cook" to "Ready."
4.  In the POS, reduce the quantity of the second order line (quantity 5) to 4.

Issue: The system reduces the quantity of the first display line (the one in the "Ready" stage).

Cause: In `_process_preparation_changes` of `pos_order.py` in the `pos_preparation_display` module, display lines are filtered and sorted based on their creation order. However, since there is no 1-to-1 relation between display lines and order lines, it is impossible to directly target specific display lines.

Fix: After this commit, display lines are now sorted based on their stage. Priority for quantity reduction is given to the line in the earliest stage. 

opw-4354093

### Steps to Reproduce * Navigate to the Employees app and set a PIN code for Mark Demo * In the Manufacturing app, assing a work order to Mark Demo and another to Michael Admin * Open the Shop Floor interface, adding Michael Admin and Mark Demo as active employees * Click on the My WO filter and select Michael * Switch to Mark Demo and enter his PIN code ### Current Behavior * The work orders assigned to Michael are displayed for Mark, even with the My WO filter enabled. ### Expected Behavior Only the work orders assigned to Mark should be displayed ### Reason This issue occurs when a PIN is activated for an employee. When the PIN validation pop-up is displayed, the cache cleanup is performed for the previously logged-in user rather than the newly connected user. Consequently, the old user's workorders remain visible because the cache is not refreshed correctly. ### Fix Ensure that the cache is cleared only after the PIN is successfully validated and the user is connected. Additionally, verify that the My WO filter corresponds to the newly connected user before updating the cache. This will ensure that only the relevant work orders are displayed. opw-4256568

In a POS restaurant order, when reducing the product quantity of an order line, the reduced display line in the preparation display was always the first one created, regardless of which order line was changed. Steps to reproduce: 1. In the POS restaurant, add a product with a quantity of 2 and an internal note. Confirm the order. 2. Add another order with the same product and internal note but with a quantity of 5. 3. In the kitchen display, change the stage of the first display line (quantity 2) from "To Cook" to "Ready." 4. In the POS, reduce the quantity of the second order line (quantity 5) to 4. Issue: The system reduces the quantity of the first display line (the one in the "Ready" stage). Cause: In `_process_preparation_changes` of `pos_order.py` in the `pos_preparation_display` module, display lines are filtered and sorted based on their creation order. However, since there is no 1-to-1 relation between display lines and order lines, it is impossible to directly target specific display lines. Fix: After this commit, display lines are now sorted based on their stage. Priority for quantity reduction is given to the line in the earliest stage. opw-4354093