Thursday, December 12, 2024
3 changes · saas-17.2
Resolved issues and error corrections
A web interface test was adjusted to match a recent change in keyboard shortcut behavior. This helps keep automated checks reliable without changing the product experience for users.
Original PR description
fix test broken by: https://github.com/odoo/odoo/pull/189163/commits/be23ed0ef17d0e5522c2cadc6267799f0a690fdb --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents the Point of Sale from repeatedly asking staff to choose a loyalty program when adding products tied to multiple programs. The selection prompt now appears only for gift card or eWallet cases where the choice is actually useful, making checkout smoother.
Original PR description
When clicking on a product that is linked to multiple loyalty programs you are prompted to select one of them everytime you add one item via the ui. Steps to reproduce: ------------------- * Create 2 loyalty programs activated when buying a certain product * Open PoS and click on the product > Observation: You will get a prompt everytime you click on the product Why the fix: ------------ The variable `selected_program` is actually only usefull if the program selected is gift card or an eWallet program. So we filter it before and only prompt when the output will be usefull. opw-4187037
Expense reports with taxes forced to be included in the price now round tax amounts consistently. This prevents valid expense reports from failing with an “Unbalanced Entry” error in specific tax and global rounding setups, such as Canadian GST/QST.
Original PR description
In expenses, we want to keep the tax included in price. Even if the tax is defined as not included in price we force the computation to be price included. However, with specific combination of price…
In expenses, we want to keep the tax included in price. Even if the tax is defined as not included in price we force the computation to be price included. However, with specific combination of price and tax amount, the computation result in amount not rounded correctly. As result, users trying to post journal entry from expense report may face an "Unbalanced Entry" error. Steps to reproduce: - With Canadian accounting set up in Canadian company - Set rounding method to "Round globally" - Create an expense: - Add total: 77.87 CAD - Use tax: 14.975 GST+QST - Paid By: Company - Create Report > Submit to manager > Approve Error will raise ``` The move (Draft Entry (test)) is not balanced. The total of debits equals 77.87 $ and the total of credits equals 77.87 $. You might want to specify a default account on journal "Bank" to automatically balance each move. ``` In this specific configuration, we get tax values from unrounded computations, i.e. we set `amount_currency` to 67.72776690584911, that will be stored as 67.73. However, from the expense report we compute a (correct) balance of 67.72, when the move line is created the balance will be updated from this amount (currency is company currency), so the move balance will be off, raising the error opw-4148134