Friday, December 13, 2024
5 changes · 18.0
Enhancements to existing features
The emoji picker has been refreshed visually in both light and dark modes, making it easier and more pleasant to use. Keyboard navigation and search results were also improved, helping users find and insert emojis more quickly in conversations.
Original PR description
Also improve keyboard navigation. Also improve search results. Backport of https://github.com/odoo/odoo/pull/189975 Before / After (white) <img width="288" alt="Screenshot 2024-12-09 at 12 23 52" src="https://github.com/user-attachments/assets/6ba233da-820b-4a00-86f5-d65e8df8b49f"> <img width="286" alt="Screenshot 2024-12-12 at 17 32 37" src="https://github.com/user-attachments/assets/0b9e68d9-c6d1-43d9-a679-2362d4f805e0" /> Before / After (dark) <img width="289" alt="Screenshot 2024-12-09 at 12 24 00" src="https://github.com/user-attachments/assets/0422ac98-d73c-4132-9d73-a37087444013"> <img width="287" alt="Screenshot 2024-12-12 at 17 32 27" src="https://github.com/user-attachments/assets/c661bb17-5b66-4be5-81a4-26106a809f5c" />
Users will now see a clear warning in the interface when Odoo Discuss is not working. This helps reduce confusion and makes service issues visible instead of leaving users unsure why messaging is unavailable.
Payments that use a bank account as the outstanding account are now automatically marked as validated when created. This prevents payments from remaining stuck “In process” when businesses intentionally skip reconciliation to create accounting entries more quickly.
Original PR description
### Purpose Since the Payment without Entry, we've added new Payment Statuses on the payment. We've already added some heuristics to automatically mark payments as validated when the payment is reconciled. But we allow the users to set Bank accounts directly as Outstanding. It's often used by people who want to easily get their Accounting entry created, but they want to skip the reconciliation process. The problem is that, as the reconciliation is skipped, the auto-validation heuristic is never applied, and so all those payments stay "In process". ### Implementation If the Outstanding account set on the Payment Method is of type Bank, the payment is auto-validated once created. task-4392152
Resolved issues and error corrections
This fix prevents Odoo workers from repeatedly reloading internal data or clearing caches when requests use read-only database replicas. It improves stability and resource usage for deployments using database replication, while keeping normal request handling on the intended database mode.
Original PR description
The PostgreSQL streaming physical replication notably does not synchonize sequence data[^1]. For sequences that are only used to generate unique IDs (for primary keys), this is not a concern because…
The PostgreSQL streaming physical replication notably does not synchonize sequence data[^1].
For sequences that are only used to generate unique IDs (for primary keys), this is not a concern because those IDs *will be* replicated correctly.
However it's a different story for sequences that are used directly. For us it means that on read-only cursors targeting database replicas, the registry and cache generation numbers (`base_registry_signaling` and `base_cache_signaling_*`) will remain fixed and out of sync with the values on the read-write master database.
As a consequence, workers serving alternating read-write and read-only requests will keep reloading the registry or discarding caches, because they will jump between the progressing master sequences, and the fixed sequences on the replica.
For HTTP workers this causes a peformance hit and suboptimal usage of resources, as the registry will be needlessly reloaded after a "sequence jump", or caches discarded.
For Gevent workers it may be much worse, because the registry reloading will *yield* and may be started by hundreds of different greenlets, blocking as many database connections, until the connection pool is exhausted. Repeat and rinse...
Note that the problem could manifest even for a worker that only ever processes read-write requests (like Gevent), because the registry and signaling checks were explicitly done in read-only mode.
As a mitigation, this patch forces the cursor mode to "read-write" during the registry loading and signaling checks, regardless of the actual request mode. This causes some minimal extra load on the master database, but ensures that the signaling checks will always use the correct sequences. The actual request handling, which is the costly part, will still be executed in the dynamically selected cursor mode.
PS: this patch does not change the possibility of having a pure read-only server, with a replica connection used for both the read-write and read-only database connections in the config. One should however be aware that the signaling sequences will never advance, so the replica will not receive the signals.
-----
Note: in master we could overcome this limitation by defining an explicit append-only `base_signal` table, with an `id` PK column driven by a sequence, like all tables. Then, whenever we want to trigger a signal, we would simply insert a row in the table with the corresponding signal:
```sql
CREATE TABLE base_signal (
id SERIAL PRIMARY KEY,
signal VARCHAR
);
-- increment signal `registry`
INSERT INTO base_signal (signal) VALUES ('registry')
-- check current signal `registry`:
SELECT max(id) FROM base_signal WHERE signal = 'registry';
```
The `base_signal` table would be properly synchronized and visible on replicas, and could be trivially garbage collected by the autovacuum system. As a bonus, it would also make signaling transactional, in the sense that a transaction would be unable to trigger a signal and then rollback due to a later error. The sequence ID might advance, but the row won't be inserted.
Cfr task-4399456
[^1]: https://www.postgresql.org/docs/16/logical-replication-restrictions.htmlThis fixes an error that could occur when adding image icons to email templates. Users can now save templates with icons reliably, reducing interruptions when preparing branded or visual email communications.
Original PR description
Currently, an error occurs when using an image icon in the email template. Step to produce: - Install the ```mail``` module. - Go to Settings / Technical / Email / Email Templates, and open any templates. - Insert any image icon, and save the record. ValueError: `unknown color specifier: '1x1'` An error occurred when attempting to retrieve computed styles for the element during inlining converting. Specifically, when the system tries to fetch the color code and other CSS properties, it returns empty values because `getComputedStyle` fails to properly access the full set of styles from the cloned element. This is because `getComputedStyle` cannot retrieve styles from an element when it is detached from DOM (a cloned element not in a DOM). To resolve this issue, The cloned element is temporarily added to the DOM,So `getComputedStyle` access the required style properties. Ref:- https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle Sentry-5747299019