Odoo Changelog — 2024-12-13

Friday, December 13, 2024

8 changes

Branch: 18.0

5 changes

Bug Fixes(5)

Resolved issues and error corrections

[FIX] mail: make discuss sidebar less distracting (backport)

PR #190627

Core18.0mail

The Discuss sidebar now visually de-emphasizes inactive conversations so the active chat remains easier to focus on. Unread conversations still stand out enough to be noticed, improving usability without changing functionality.

Original PR description

Discuss sidebar items are too catchy, which is distracting when the core part of Discuss app is the conversation itself. As much as possible, conversation should be very visible while other elements are slightly less visible.

This problem is even more pronunced when the sidebar is compact, because the avatars in sidebar are next to avatars of conversation, which is even more distracting.

This commit fixes the issue by reducing opacity slightly on non-active sidebar items. Conversation that are unread and unactive have an in-between opacity so they are more visible than other read and non-active conversations but still have reduced opacity so that this is less distracting than the conversation itself.

Backport of https://github.com/odoo/odoo/pull/190071

#discuss#sidebar#usability

[FIX] html_editor: remove format toolbar button

PR #189797

Core18.0html_editor

The HTML editor now correctly enables the remove formatting button when any selected content includes formatting, even if other selected text is plain. This makes editing formatted content more predictable and prevents users from being blocked from clearing styles in mixed selections.

Original PR description

When the selection contains formatted nodes among unformatted nodes, the remove format toolbar button should be available.

This is not the case currently because the `hasAnyFormat` method, which is used to determine whether the button should be disabled, checks if **every** node in the selection is formatted.

This commit fixes the issue by checking if **any** node in the selection is formatted instead.

task-4385246

#editor#formatting#toolbar

[FIX] account: x2many button on payment view

PR #190039

Core18.0account

Fixes an error that occurred when users clicked the “Same payment” link after duplicating a confirmed payment. The payment screen now opens the related business document correctly, preventing an unexpected interruption in accounting workflows.

Original PR description

In the payment view, he `x2many_buttons` widget on `duplicate_payment_ids`
calls the `action_open_business_doc`, but this method is not implemented
on `account.payment`. This was not not a problem before 01b87f1230beac0568f4e3b1b76e547909506892
since a payment was always linked to a move, therefore we were calling
the method from `account.move`.

With this commit, we implement the `action_open_business_doc` in
`account.payment`.

Step:

- Create a payment and confirm
- Duplicate it
- Click on the 'Same payment' hyperlink
-> Error: "The method 'action_open_business_doc' does not exist on the
   model 'account.payment'"

opw-4363907

#payments#duplicate payments#accounting

[FIX] fleet: allow overriding the behavior on contract easily

PR #190539

Core18.0fleet

Fleet contract status changes now use the same internal actions whether they are triggered automatically or by date updates. This makes custom behavior for opening or closing contracts easier to maintain and reduces the risk of inconsistent contract handling.

Original PR description

Since there are two mechanism that changes the status of a contract (a cron and the write of a date), we have to override 2 different places when we want to add a behavior on closing or opening of contracts.

As there are already functions (action_expire, ...) that exist and are use in the write part, we also use them in the cron, so we'll have only one place where we need to override it.


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#fleet#contracts#customization

[FIX] documents: fix open folder after preview

PR #74976

Enterprise18.0documents

This fixes an issue in Documents where opening a folder could fail after previewing a file, closing the preview, and switching views. Users can now continue navigating folders normally without encountering an error.

Original PR description

Steps to reproduce the traceback:
- preview a file from the kanban view
- close the preview
- switch to list view
- open a folder

To Be:
The folder should open correctly.

Technical:
The traceback happens because the 'getSelectedDocumentsElements' calls a querySelectorAll on the component root element without checking if it exists.
Fixing the issue by making sure the component effectively have a root element before calling the method.

Task-4373626

#documents#folder navigation#preview#stability

Branch: 17.0

3 changes

Bug Fixes(3)

Resolved issues and error corrections

[FW][FIX] account_bank_statement_import_camt: import debited charges

PR #75626

Enterprise17.0account

This update fixes an issue where bank statement imports were not accurately capturing debited charges. Now, the system correctly includes these charges in the imported transaction amounts, ensuring more precise financial reporting. This improves the reliability of bank statement data within the Enterprise system.

Original PR description

Before this commit:
Import a statement having transactions including debited charges in their total credited amount. In that case, the retrieved amount is incorrect, it does not include the charges.

After this commit:
The debited charges are retrieved and included in the amount.

opw-3208721

Forward-Port-Of: odoo/enterprise#74962

#bank statements#finance#accounting

[FIX] account_consolidation: handle empty totals when formatting account lines

PR #74938

Enterprise17.0account

This update resolves a stability issue in the consolidated balance report. Previously, an empty totals list could cause a crash. The fix ensures that the report only attempts to modify data when totals are present, preventing errors and improving reliability.

Original PR description

**[FIX] account_consolidation: handle empty totals when formatting account lines**

When processing account lines, the totals list might be empty resulting in an IndexError when trying to set auditable to false on the last column, which leads to consolidated balance to crash.

This fix just makes sure that modifying the column on this line is only done when the cols actually contains some data.

opw-4205722

#reporting#stability#account

[FIX] l10n_jp_zengin: fix code while append error message

PR #75475

Enterprise17.0l10n_jp_zengin

This update resolves an issue where the system incorrectly attempted to raise an error message when a bank account lacked a client code. The fix corrects a coding error that was passing multiple arguments to the `append` function, ensuring proper error handling and preventing the system from crashing.

Original PR description

An error occurs when the system try to raise an error message when a bank account has not client code.

```TypeError: list.append() takes no keyword arguments```

Currently in code [1] mistakenly provides multiple values via keyword arguments to the `append` method. which is incorrect. So instead of it, we need to change the formatting to pass a single argument as a string to resolve the error.

Link [1]: https://github.com/odoo/enterprise/blob/07fae63e381dfa7a8035f67837f19d619600d434/l10n_jp_zengin/models/account_batch_payment.py#L77

Sentry-6128197646

#accounting#japan

Discuss sidebar items are too catchy, which is distracting when the core part of Discuss app is the conversation itself. As much as possible, conversation should be very visible while other elements are slightly less visible. This problem is even more pronunced when the sidebar is compact, because the avatars in sidebar are next to avatars of conversation, which is even more distracting. This commit fixes the issue by reducing opacity slightly on non-active sidebar items. Conversation that are unread and unactive have an in-between opacity so they are more visible than other read and non-active conversations but still have reduced opacity so that this is less distracting than the conversation itself. Backport of https://github.com/odoo/odoo/pull/190071

When the selection contains formatted nodes among unformatted nodes, the remove format toolbar button should be available. This is not the case currently because the `hasAnyFormat` method, which is used to determine whether the button should be disabled, checks if **every** node in the selection is formatted. This commit fixes the issue by checking if **any** node in the selection is formatted instead. task-4385246

In the payment view, he `x2many_buttons` widget on `duplicate_payment_ids` calls the `action_open_business_doc`, but this method is not implemented on `account.payment`. This was not not a problem before 01b87f1230beac0568f4e3b1b76e547909506892 since a payment was always linked to a move, therefore we were calling the method from `account.move`. With this commit, we implement the `action_open_business_doc` in `account.payment`. Step: - Create a payment and confirm - Duplicate it - Click on the 'Same payment' hyperlink -> Error: "The method 'action_open_business_doc' does not exist on the model 'account.payment'" opw-4363907

Since there are two mechanism that changes the status of a contract (a cron and the write of a date), we have to override 2 different places when we want to add a behavior on closing or opening of contracts. As there are already functions (action_expire, ...) that exist and are use in the write part, we also use them in the cron, so we'll have only one place where we need to override it. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce the traceback: - preview a file from the kanban view - close the preview - switch to list view - open a folder To Be: The folder should open correctly. Technical: The traceback happens because the 'getSelectedDocumentsElements' calls a querySelectorAll on the component root element without checking if it exists. Fixing the issue by making sure the component effectively have a root element before calling the method. Task-4373626

Before this commit: Import a statement having transactions including debited charges in their total credited amount. In that case, the retrieved amount is incorrect, it does not include the charges. After this commit: The debited charges are retrieved and included in the amount. opw-3208721 Forward-Port-Of: odoo/enterprise#74962

**[FIX] account_consolidation: handle empty totals when formatting account lines** When processing account lines, the totals list might be empty resulting in an IndexError when trying to set auditable to false on the last column, which leads to consolidated balance to crash. This fix just makes sure that modifying the column on this line is only done when the cols actually contains some data. opw-4205722

An error occurs when the system try to raise an error message when a bank account has not client code. ```TypeError: list.append() takes no keyword arguments``` Currently in code [1] mistakenly provides multiple values via keyword arguments to the `append` method. which is incorrect. So instead of it, we need to change the formatting to pass a single argument as a string to resolve the error. Link [1]: https://github.com/odoo/enterprise/blob/07fae63e381dfa7a8035f67837f19d619600d434/l10n_jp_zengin/models/account_batch_payment.py#L77 Sentry-6128197646