Monday, December 16, 2024
10 changes · saas-17.2
Resolved issues and error corrections
Fixes an issue that caused an error when duplicating multiple users at once while the signup module is installed. This helps administrators manage user records in bulk without interruptions.
Original PR description
When we try to duplicate users in the Users section, this error occurs. Steps to reproduce: - Install the ``auth_signup`` module - Go to users and select ``Mitchell Admin`` and ``Marc Demo`` - Now duplicate both of them Traceback: ``ValueError: Expected singleton: res.users(2, 6)`` This error occurs at [1], where we are receiving multiple values in ``self``. This commit will fix the above error by changing the method name from ``copy`` to ``copy_data``. [1]- https://github.com/odoo/odoo/blob/0a52ad52b1a17f2732f92a5e24ec0814d929329b/addons/auth_signup/models/res_users.py#L348 sentry-5635211309 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Some users need to make invoices with 100% discount lines. If they try then will receive this UCFE error that does not let us to validate the invoice in DGI . > ERROR: CODE 31: Error: El contenido del elemento 'Item' en espacio de nombres 'http://cfe.dgi.gub.uy' está incompleto. Lista esperada de elementos posibles: 'SubDescuento, RecargoPct, RecargoMnt, SubRecargo, RetencPercep, MontoItem' en espacio de nombres 'http://cfe.dgi.gub.uy'. In order to make it work we need to adapt the module
Original PR description
Some users need to make invoices with 100% discount lines. If they try then will receive this UCFE error that does not let us to validate the invoice in DGI . > ERROR: CODE 31: Error: El contenido…
Some users need to make invoices with 100% discount lines. If they try then will receive this UCFE error that does not let us to validate the invoice in DGI . > ERROR: CODE 31: Error: El contenido del elemento 'Item' en espacio de nombres 'http://cfe.dgi.gub.uy' está incompleto. Lista esperada de elementos posibles: 'SubDescuento, RecargoPct, RecargoMnt, SubRecargo, RetencPercep, MontoItem' en espacio de nombres 'http://cfe.dgi.gub.uy'. In order to make it work we need to adapt the module to accept this kind of lines that actually represent an "Entrega Gratuita" (Indicator 5 in Uruguay) - We check if the line is a 100% discount, if it is then we marked as Entrega Gratuita when we are creating XML (Indicator 5) - Now that we can have lines and also invoices with total value 0.0 we need to adapt our XML because if value 0.0 then some tags were not added to the final XML - it was interpreted as False and the result was and invalid XML becasue we were missing a mandatory tag. Now we can tags that have 0.0 value to the final XML. - Now that we can have lines 0.0 total amount, and also invoices 0.0 total amount, if we are using foreign currency then we need to avoid error computing the currency rate (division by zero). Now we detect this cases and use the date rate. Also, the rate is only been computed when actually we are going to use it. LATAM 1296 / ADHOC Ticket 83295 Forward-Port-Of: odoo/enterprise#73956
When uploading a pdf through "Upload a pdf & sign" button, no template should be saved. Hence the "Template Properties" button shouldn't show up. This commit aims to hide the button for this type of files. Task: 4317966 Forward-Port-Of: odoo/enterprise#75176 Forward-Port-Of: odoo/enterprise#73912
Original PR description
When uploading a pdf through "Upload a pdf & sign" button, no template should be saved. Hence the "Template Properties" button shouldn't show up. This commit aims to hide the button for this type of files. Task: 4317966 Forward-Port-Of: odoo/enterprise#75176 Forward-Port-Of: odoo/enterprise#73912
Currently when receiving incoming calls, it's possible that all opened tabs will play the ringtone. To reduce the chaos, we now only play the incoming ringtone on the master tab. Task-4402909 Forward-Port-Of: odoo/enterprise#75534
Original PR description
Currently when receiving incoming calls, it's possible that all opened tabs will play the ringtone. To reduce the chaos, we now only play the incoming ringtone on the master tab. Task-4402909 Forward-Port-Of: odoo/enterprise#75534
When creating a supplier invoice for a provider of type "2nd category voucher issuer," the system incorrectly defaults the document type to 56 (Electronic Debit Note) instead of 71 (Electronic Fee Receipt). This results in additional manual corrections and risks errors if the document type is not updated before confirmation. This fix ensures the system automatically selects document type 71 for providers of this category, streamlining the process and reducing error potential. opw-4217228
Original PR description
When creating a supplier invoice for a provider of type "2nd category voucher issuer," the system incorrectly defaults the document type to 56 (Electronic Debit Note) instead of 71 (Electronic Fee Receipt). This results in additional manual corrections and risks errors if the document type is not updated before confirmation. This fix ensures the system automatically selects document type 71 for providers of this category, streamlining the process and reducing error potential. opw-4217228 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188166
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#190489
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#190489
Description of the issue/feature this PR addresses: - The last update on Mexican banks was five years ago. Since then, several new banks have emerged, while others have closed. Current behavior before PR: - 3 banks in our data no longer exist in real life. - 3 banks have outdated names. - 15 new banks aren't included, since they emerged after our bank data was updated. Desired behavior after PR is merged: - To align the bank list with those specified by the SAT (_Servicio de Administr
Original PR description
Description of the issue/feature this PR addresses: - The last update on Mexican banks was five years ago. Since then, several new banks have emerged, while others have closed. Current behavior before PR: - 3 banks in our data no longer exist in real life. - 3 banks have outdated names. - 15 new banks aren't included, since they emerged after our bank data was updated. Desired behavior after PR is merged: - To align the bank list with those specified by the SAT (_Servicio de Administración Tributaria_, Mexico's highest tax authority responsible for tax collection), you can refer to their [official documentation](http://omawww.sat.gob.mx/fichas_tematicas/buzon_tributario/Documents/catalogo_bancos.pdf). opw-[4327242](https://www.odoo.com/odoo/project.task/project.task/4327242) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#189387
Steps to reproduce the bug: - Create “route 1”: - applicable on: product - Rule: - Pull from - Operation type: internal transfer - Source Location: WH/Stock/Shelf 1 - Destination Location: WH/Stock/Shelf 2 - Supply Method: Take from stock - Create a storable product “P1”: - Orderpoint: - Location: WH/Stock/Shelf 2 - Min qty: 0 - route: “route 1” - create a repair order: - product to repair: selec
Original PR description
Steps to reproduce the bug: - Create “route 1”: - applicable on: product - Rule: - Pull from - Operation type: internal transfer - Source Location: WH/Stock/Shelf 1 - Destination Location:…
Steps to reproduce the bug:
- Create “route 1”:
- applicable on: product
- Rule:
- Pull from
- Operation type: internal transfer
- Source Location: WH/Stock/Shelf 1
- Destination Location: WH/Stock/Shelf 2
- Supply Method: Take from stock
- Create a storable product “P1”:
- Orderpoint:
- Location: WH/Stock/Shelf 2
- Min qty: 0
- route: “route 1”
- create a repair order:
- product to repair: select any one
- Part: Add one unit of P1
- Go to miscellaneous:
- source location: WH/Stock/Shelf 2
- Confirm the MO
Problem:
The order point will be triggered, and a stock move will be created
but not linked to a picking. This occurs because the product to be
repaired is storable and out of stock. As a result, the wizard
indicating insufficient quantity for the product is launched, and
default_repair_id is added to the context. Consequently, the move will
be created with the repair order field set and does not need to be
assigned.
https://github.com/odoo/odoo/blob/17.0/addons/repair/models/stock_move.py#L179-L182
opw-4224710
Forward-Port-Of: odoo/odoo#188280Have a list or kanban views with more than 10k records such that the count limit is reached, and the pager displays something like "1-80/10000+". Click on "10000+" to compute the real count. Before this commit, the context wasn't given to that call, which could obviously return a wrong result, for instance if the context has the "active_test" key set to false. task~4331708 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is mer
Original PR description
Have a list or kanban views with more than 10k records such that the count limit is reached, and the pager displays something like "1-80/10000+". Click on "10000+" to compute the real count. Before this commit, the context wasn't given to that call, which could obviously return a wrong result, for instance if the context has the "active_test" key set to false. task~4331708 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#190721
Improve loop detection and break. Indeed heavy usage of mailgateway on Odoo servers lead us to face email loops. Those lead to email being disabled on our servers due to email limit, and to other issues (spam, never ending notifications, ...) on hosted servers. Three scenarios are fixed with this PR. See individual commits for more details. Those are * having followers using alias email, and using a mail provider that rewrites msg-id: we cannot detect message duplication and this ma
Original PR description
Improve loop detection and break. Indeed heavy usage of mailgateway on Odoo servers lead us to face email loops. Those lead to email being disabled on our servers due to email limit, and to other…
Improve loop detection and break. Indeed heavy usage of mailgateway on Odoo servers lead us to face email loops. Those lead to email being disabled on our servers due to email limit, and to other issues (spam, never ending notifications, ...) on hosted servers. Three scenarios are fixed with this PR. See individual commits for more details. Those are * having followers using alias email, and using a mail provider that rewrites msg-id: we cannot detect message duplication and this may generate loops. Several mail providers rewrite message IDs and that is a pain for us. We therefore add a custom header allowing to keep message ID in envelope; * replying to bounce may create bounce in loops: this is fixed using the loop detection custom reference; * detect loops on record update in addition to record creation: do not limit loops detection on aliases creating records, also check updated records; Task-3895869 OPW-4051539 OPW-4295745 OPW-4302257 Forward-Port-Of: odoo/odoo#190516 Forward-Port-Of: odoo/odoo#187696