Tuesday, December 17, 2024
4 changes · 17.0
Resolved issues and error corrections
This update fixes an issue where quality checks weren't correctly displaying linked QC information for finished lots. The change ensures that quality check smart buttons accurately reflect the QC linked to finished lots, improving reporting accuracy and providing better visibility into product quality. This resolves a previous bug impacting manufacturing traceability.
Original PR description
Steps to reproduce the bug:
- Create a storable product “P1”:
- Tracked with SN
- Create a BoM:
- no need to component
- Add an operation “OP1” with steps
- Control by product
- Create a manufacturing order for one unit of P1
- Confirm the MO
- Go to the shop floor and process “OP1”
- Validate the MO
- Go to the SN of P1
Problem:
The quality check smart button is correctly computes the number of QC linked with finished_lot or lot_id thanks to:
https://github.com/odoo/enterprise/pull/72693/commits/2e2a49d4ee90b20fe899ca3c199a20ad88d185ad
but they are not read in the quality check view because the domain is
not correct
opw-4361358This update resolves an issue where uninstalling the Field Service app would incorrectly mark all projects as non-billable, leading to data loss. The change removes a previously implemented workaround, ensuring projects retain their billable status after the app is removed, maintaining accurate sales data.
Original PR description
**Issue:**
- Uninstalling the Field Service app will make all normal projects non-billable, resulting in the removal of customers and sales orders from their tasks.
**Steps To Reproduce:**
- Install the Field Service app.
- Create a project and set it as billable.
- Create a task for the project. set customer and sales order.
- Uninstall the Field Service app.
- Check the project's billable status and the task.
**Solution:**
- remove the `uninstall_hook` method since the original issue it was added for is no longer reproducable. https://github.com/odoo/enterprise/pull/32022/commits/341e68e6a3e569137aeb41d69203c731559f9ef8
opw-[4379638](https://www.odoo.com/web#id=4379638&view_type=form&model=project.task)This update fixes inaccuracies in the HR contract dashboard by dynamically calculating reporting based on contract start and end dates, rather than static status groupings. This ensures correct reporting for all contract statuses, including archived employees, providing a more reliable view of current and historical contract data.
This update ensures that a notification is sent to the preparation display when a line item's quantity is reduced in the restaurant order. Previously, the system didn't trigger this notification, leading to potential delays in kitchen preparation. The fix corrects a data logic issue to ensure timely updates.
Original PR description
Currently, when reducing the quantity of a line, the notification for the cancelled items is not sent Steps to reproduce: ------------------- * Set up the preparation display on the category food *…
Currently, when reducing the quantity of a line, the notification for the cancelled items is not sent
Steps to reproduce:
-------------------
* Set up the preparation display on the category food
* Open both restaurant and preparation display
* In the restaurant place an order for an item with a quantity of 3
* Send the order to the kitchen
* Change the quantity to 2
* Send the order to the kitchen
> Observation: The notification is not sent to the preparation display
Why the fix:
------------
When reducing the quantity, data looks like this
`{'change': True, 'sound': False, 'category_ids': {}}`. Since `category_ids` is empty, `preparation_displays` will alsos be empty which explains why the preparation display does not receive the notification, it is simply not sent.
https://github.com/odoo/enterprise/blob/42b7b322d6c720de45661e3370397adaf74fe1f4/pos_preparation_display/models/preparation_display_order.py#L29-L40
When augmenting the quantity we add the category here: https://github.com/odoo/enterprise/blob/681c4bca67e9e312f66d797e45fb7e1c3a10b983/pos_preparation_display/models/pos_order.py#L135
We use the same logic when reducing it. This is already done in more recent version:
https://github.com/odoo/enterprise/blob/42b7b322d6c720de45661e3370397adaf74fe1f4/pos_preparation_display/models/pos_order.py#L166
opw-4332578