Thursday, December 19, 2024
4 changes · saas-17.4
Resolved issues and error corrections
Fixed an eCommerce checkout issue where carts containing discounted products with different tax settings could get stuck in an endless browser reload. Discount totals are now grouped consistently, helping customers proceed smoothly to delivery selection.
Original PR description
Versions -------- - saas-17.4+ Steps ----- 1. Create a deliverable product with sales tax; 2. create another product without sales tax; 3. publish both to eCommerce; 4. create a discount program; 5. add both products to shopping cart; 6. apply discount; 7. go to delivery selection step. Issue ----- Endless browser reload cycle. Cause ----- The reload is supposed to sync the discount lines in the back-end with the discount lines displayed during checkout. If the number of lines don't match, a reload is triggered. The issue is that on the back-end, discounts are counted per line, while in eCommerce, the discounts are displayed per reward. This difference matters when a discount is applied on products with different sales taxes, creating a separate discount line for every sales tax. Solution -------- When iterating over discount lines in the controller, group them per `reward_id`, and sum up their subtotals. opw-4343959
This update brings the spreadsheet component to its latest maintenance version and fixes several user-facing issues. Users should see fewer crashes and more consistent behavior when editing cells, sheets, tables, and figures.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/6b827fc74 [REL] 17.4.16 Task: 0 https://github.com/odoo/o-spreadsheet/commit/a916927cc [FIX] cell: keep non-breaking…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/6b827fc74 [REL] 17.4.16 Task: 0 https://github.com/odoo/o-spreadsheet/commit/a916927cc [FIX] cell: keep non-breaking spaces Task: 4403607 https://github.com/odoo/o-spreadsheet/commit/82546a8ba [FIX] sheet view: DELETE_SHEET in initial revisions Task: 4405573 https://github.com/odoo/o-spreadsheet/commit/bd13a6c9f [FIX] table_style_editor_panel: disable "No Color" button Task: 4102704 https://github.com/odoo/o-spreadsheet/commit/8ac3b3c26 [FIX] SheetPlugin: Fix handling of unbounded zones Task: 4397745 https://github.com/odoo/o-spreadsheet/commit/5be769718 [FIX] figure: crash on deleting dragged figure Task: 4329240 https://github.com/odoo/o-spreadsheet/commit/c6924e6c1 [FIX] composer: topbar composer z-index Task: 4246966 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This fix prevents users with standard Point of Sale permissions from running into an unexpected error when opening POS categories from the dashboard. Instead of a confusing system traceback, access restrictions are handled properly, improving reliability for users whose roles have changed.
Original PR description
We encounter an error when trying to open any POS category from the ``Dashboard``, if the Administrator is assigned the role of ``User`` for ``Point of Sale``. Steps to reproduce: --- - Install…
We encounter an error when trying to open any POS category from the ``Dashboard``, if the Administrator is assigned the role of ``User`` for ``Point of Sale``.
Steps to reproduce:
---
- Install ``point_of_sale`` module
- Open POS
- Now go to Users and Change the right from ``Admin`` -> ``User`` in ``Point of Sale``
- Now go to ``Dashboard`` and try to open any category
Traceback:
---
```
ParseError: while parsing /home/odoo/src/odoo/saas-17.4/addons/product/data/product_demo.xml:5, somewhere inside <record id="base.group_user" model="res.groups">
<field name="implied_ids" eval="[(4, ref('product.group_product_variant'))]"/>
</record>
```
This error occurs when the POS application is opened, as the onWillStart method is triggered. However, if the user's permissions are changed, the method does not update accordingly, leading to an error.
sentry-5710465833
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prOdoo now cleans up more old device access logs to better control database growth. Logs are kept for six months, and IPv6 addresses are grouped more efficiently so storage is not wasted on near-duplicate entries.
Original PR description
The `res.device.log` model has a lot of data. In order to limit the growth of this table, an improved garbage collector is a good thing. We only keep the logs for 6 months (which is acceptable in terms of security). In addition, for IPv6, we compare the bits corresponding to the network (global routing prefix + subnet id) so that we don't keep a log for each IPv6 address. For example, with these changes, for ~ 4,500,000 logs, we can collect ~ 750,000 instead of ~ 35,000.