Friday, December 20, 2024
23 changes · saas-17.2
Resolved issues and error corrections
This fixes a small issue in the Discuss/mail area where a chat channel might not open as intended when the system explicitly asks it to. It helps ensure users are taken directly to the relevant conversation instead of seeing it folded or hidden.
Original PR description
Following 17fa8a4531df0cd7281962211797ba60df06f775, `force_open` was introduced as a parameter to the function, but the condition to set the folding state references `open` (python's default function to open a file), not `force_open` (the parameter), probably a typo. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Forward-Port-Of: odoo/enterprise#75807
Original PR description
Forward-Port-Of: odoo/enterprise#75807
On a previous commit: https://github.com/odoo/enterprise/commit/8e2957c238e28b8a952c0e354c46e39b1fdd03a6 We changed the condition on the VATNumber node on oss report, but actually it was a mistake and in some cases, this change broke some xml exports on other customer db. But, after more investigation, we decided to remove the fixedEstablishment node from the xml export, as we don't have any use cases where this node is required for now. no task Forward-Port-Of: odoo/enterprise#75964 Forw
Original PR description
On a previous commit: https://github.com/odoo/enterprise/commit/8e2957c238e28b8a952c0e354c46e39b1fdd03a6 We changed the condition on the VATNumber node on oss report, but actually it was a mistake and in some cases, this change broke some xml exports on other customer db. But, after more investigation, we decided to remove the fixedEstablishment node from the xml export, as we don't have any use cases where this node is required for now. no task Forward-Port-Of: odoo/enterprise#75964 Forward-Port-Of: odoo/enterprise#75705
Due to a typo in the directory name the warnings.xml file got duplicated and one of them is now unnecesary. linked pr: #67187 Forward-Port-Of: odoo/enterprise#75833
Original PR description
Due to a typo in the directory name the warnings.xml file got duplicated and one of them is now unnecesary. linked pr: #67187 Forward-Port-Of: odoo/enterprise#75833
There are new requirements for the ph check format: - No '*' allowed anymore - In amount in words: • no thousand comma separator • no 'And' between hundreds and tens https://www.metrobank.com.ph/articles/new-check-format-advisory This commit fixes also an issue with the cents format in the amount in words ('X/100' instead of 'X0/100') opw-4376550 Forward-Port-Of: odoo/enterprise#75647
Original PR description
There are new requirements for the ph check format:
- No '*' allowed anymore
- In amount in words:
• no thousand comma separator
• no 'And' between hundreds and tens
https://www.metrobank.com.ph/articles/new-check-format-advisory
This commit fixes also an issue with the cents format in the amount in
words ('X/100' instead of 'X0/100')
opw-4376550
Forward-Port-Of: odoo/enterprise#75647The aim of this commit is adapting the IMB (Soldes Intermédiaires de Gestion) to the new COA. task-4040854 Forward-Port-Of: odoo/enterprise#75777 Forward-Port-Of: odoo/enterprise#75373
Original PR description
The aim of this commit is adapting the IMB (Soldes Intermédiaires de Gestion) to the new COA. task-4040854 Forward-Port-Of: odoo/enterprise#75777 Forward-Port-Of: odoo/enterprise#75373
Steps to reproduce: - In the rental module, set a product as storable and uncheck 'Out-of-Stock: Continue Selling.' - Create a discount program for product purchase with 'Get Free Product' reward. - Add enough rental products to an order on the website to trigger the discount. Issue: - Traceback error: TypeError: < not supported between instances of datetime.datetime and bool. Cause: - The reward_line has reservation_begin = False, which results in a dictionary containing a False v
Original PR description
Steps to reproduce: - In the rental module, set a product as storable and uncheck 'Out-of-Stock: Continue Selling.' - Create a discount program for product purchase with 'Get Free Product' reward. - Add enough rental products to an order on the website to trigger the discount. Issue: - Traceback error: TypeError: < not supported between instances of datetime.datetime and bool. Cause: - The reward_line has reservation_begin = False, which results in a dictionary containing a False value alongside other datetime objects. Fix: - Filter the lines to ensure the loop iterates only over rental lines. opw-4360396 Forward-Port-Of: odoo/enterprise#75894
In ES localization Tax Report 349 is an informative tax return report for intra-Community operations. Currently, the tax report will show amounts from credit notes in the invoices section, instead of the refunds section Steps to reproduce: - Have an ES Company setup - Create and confirm credit note with: - EU partner - Type for mod 349: A - Go to Accounting > Reporting > Tax Report - Select Report: Tax Report (Mod 349) (ES) Issue: Credit Notes appear in the invoices section inst
Original PR description
In ES localization Tax Report 349 is an informative tax return report for intra-Community operations. Currently, the tax report will show amounts from credit notes in the invoices section, instead of the refunds section Steps to reproduce: - Have an ES Company setup - Create and confirm credit note with: - EU partner - Type for mod 349: A - Go to Accounting > Reporting > Tax Report - Select Report: Tax Report (Mod 349) (ES) Issue: Credit Notes appear in the invoices section instead of the refunds section opw-4358330 Forward-Port-Of: odoo/enterprise#75808 Forward-Port-Of: odoo/enterprise#75266
`quality_iot` listens continuously for measure updates. It also provides a "take measure" button for devices that don't send automatically their measure. On caliper devices, measures are sent continuously, so methods to read value once were not implemented, resulting in a error if we tried to call them. To avoid displaying an error popup, we implemented those actions on caliper drivers. opw-4332476 Forward-Port-Of: odoo/enterprise#75847
Original PR description
`quality_iot` listens continuously for measure updates. It also provides a "take measure" button for devices that don't send automatically their measure. On caliper devices, measures are sent continuously, so methods to read value once were not implemented, resulting in a error if we tried to call them. To avoid displaying an error popup, we implemented those actions on caliper drivers. opw-4332476 Forward-Port-Of: odoo/enterprise#75847
If Starshipit is configured with TNT service (Australia), the API does not return a pdf field for `orders/manifest` endpoint. This causes the transfer validation process to fail in Odoo. This fix does not resolve the core problem, but it will allow the stock picking to be marked as "Done", with tracking number and link available to the user. The downside is that the manifest PDF will not be available Task: 4195503 Forward-Port-Of: odoo/enterprise#74190
Original PR description
If Starshipit is configured with TNT service (Australia), the API does not return a pdf field for `orders/manifest` endpoint. This causes the transfer validation process to fail in Odoo. This fix does not resolve the core problem, but it will allow the stock picking to be marked as "Done", with tracking number and link available to the user. The downside is that the manifest PDF will not be available Task: 4195503 Forward-Port-Of: odoo/enterprise#74190
Steps to reproduce: - Try to add a parent to the base plan "Projects" Issue: Unclear error message Cause: This is a master data and the constraint raised an unclear message "Invalid Operation This column contains module data and cannot be removed!" https://github.com/odoo/odoo/blob/1621f12e90b5903d1132875db7b0d94fa68bc642/odoo/addons/base/models/ir_model.py#L857-L859 Solution: We specify a more user-friendly message during the onchange opw-4327913 Forward-Port-Of: odoo/odoo
Original PR description
Steps to reproduce: - Try to add a parent to the base plan "Projects" Issue: Unclear error message Cause: This is a master data and the constraint raised an unclear message "Invalid Operation This column contains module data and cannot be removed!" https://github.com/odoo/odoo/blob/1621f12e90b5903d1132875db7b0d94fa68bc642/odoo/addons/base/models/ir_model.py#L857-L859 Solution: We specify a more user-friendly message during the onchange opw-4327913 Forward-Port-Of: odoo/odoo#188778
Currently, a connection error shows when the ReadTimeout error occurs when calling the JSON-RPC endpoint in IAP. This commit will show users a timeout error when a "ReadTimeout" error is found in the JSON response in the RPC call. sentry-6059323528 Forward-Port-Of: odoo/odoo#190841
Original PR description
Currently, a connection error shows when the ReadTimeout error occurs when calling the JSON-RPC endpoint in IAP. This commit will show users a timeout error when a "ReadTimeout" error is found in the JSON response in the RPC call. sentry-6059323528 Forward-Port-Of: odoo/odoo#190841
[FIX] l10n_fr: add tax move lines in tax report In the l10n_fr tax report, the wrong `account_move_line` entries are used in the journal item list view of the tax report in section `TD-VAT Due`. As a result, the balance debit/credit displayed under the `TD-VAT Due` is not the same as the balance in the journal items list view. - Create a customer invoice with a price 1000 and a tax 20% Goods. - Create a vendor bill with a price 100 and a tax 20% Goods. - Open the tax report, under the TD -
Original PR description
[FIX] l10n_fr: add tax move lines in tax report In the l10n_fr tax report, the wrong `account_move_line` entries are used in the journal item list view of the tax report in section `TD-VAT Due`. As a…
[FIX] l10n_fr: add tax move lines in tax report In the l10n_fr tax report, the wrong `account_move_line` entries are used in the journal item list view of the tax report in section `TD-VAT Due`. As a result, the balance debit/credit displayed under the `TD-VAT Due` is not the same as the balance in the journal items list view. - Create a customer invoice with a price 1000 and a tax 20% Goods. - Create a vendor bill with a price 100 and a tax 20% Goods. - Open the tax report, under the TD - VAT Due, the balance is 180. - Click on the amount in TD - VAT Due, the debit is 20 but the credit is 1000 (should be 200). The formula for `TD-VAT Due` is defined as `box_16.balance - box_23.balance`. - `box_16` is the sum of box_xx.balance which are defined by `account_tag`. - The balances of these boxes were computed using the base `account_tag`, which calculates the correct amount but causes `_expand_aggregations` in `account_report_expression` to generate a list view based on base move lines instead of the corresponding tax lines. This can be seen the label field of the lines, which are not the tax label. `box_16` needs to be computed using `box_xx_taxe` instead of `box_xx_base` to ensure the correct tax lines are included. For box 08, 09, 9B, 10, 11, T1, T2, T3, T4, T5, T6, P1, P2, I1, I2, I3, I4, I5, I6 we replace balance to balance_from_tags (which uses box_xx_taxe) For box 13, 14, 15, T7, 5B we keep balance (which already uses box_xx_taxe) opw-4335396 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188640
This commit prevents dropping an "inner content" block into an image field. Steps to reproduce: - Go to the "/shop" page. - Click on one of the products to go to its product page. - Enter edit mode. - Bug: It is possible to drop any "inner content" block into the "product" image field. This commit also fixes the following bug: - Go to the homepage in edit mode. - Drag and drop a "text-image" block onto the page. - Drag and drop a "badge" (or any other "inner content" block) un
Original PR description
This commit prevents dropping an "inner content" block into an image field. Steps to reproduce: - Go to the "/shop" page. - Click on one of the products to go to its product page. - Enter edit mode. - Bug: It is possible to drop any "inner content" block into the "product" image field. This commit also fixes the following bug: - Go to the homepage in edit mode. - Drag and drop a "text-image" block onto the page. - Drag and drop a "badge" (or any other "inner content" block) under the image. This is possible, and it's the intended behavior. - Click on the image and add a link to it. - Bug: Try dragging and dropping a "badge" under the image again, it is no longer possible. [opw-4273436](https://www.odoo.com/web#id=4273436&cids=1&menu_id=4720&action=333&active_id=1695&model=project.task&view_type=form) Forward-Port-Of: odoo/odoo#191200 Forward-Port-Of: odoo/odoo#190732
This commit will add the basic package of the bahrain localisation. - Accounts - Taxes - Fiscal positions - States - Tax reports task: 3927915 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186027
Original PR description
This commit will add the basic package of the bahrain localisation. - Accounts - Taxes - Fiscal positions - States - Tax reports task: 3927915 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#186027
To allow compatibility between all db versions and new IoT Box images, we need to ensure that `path_file` method returns the path starting from `/home/pi` instead of the path of the service user (which is `/home/odoo` in newer images). Forward-Port-Of: odoo/odoo#191149 Forward-Port-Of: odoo/odoo#190963
Original PR description
To allow compatibility between all db versions and new IoT Box images, we need to ensure that `path_file` method returns the path starting from `/home/pi` instead of the path of the service user (which is `/home/odoo` in newer images). Forward-Port-Of: odoo/odoo#191149 Forward-Port-Of: odoo/odoo#190963
### Steps to reproduce: - Install "l10n_ch" and switch to "CH company" - Create a new invoice with a Swiss partner and confirm - Click "Send & Print" and select "Send by Post", confirm - Go in Setting > technical > Email > Snailmail Letters and find your invoice - Download the PDF document - The QR code and several other information are missing ### Cause: The snailmail module is setting specific paper format (base.paperformat_euro) when generating the PDF. https://github.com/odoo/o
Original PR description
### Steps to reproduce: - Install "l10n_ch" and switch to "CH company" - Create a new invoice with a Swiss partner and confirm - Click "Send & Print" and select "Send by Post", confirm - Go in Setting > technical > Email > Snailmail Letters and find your invoice - Download the PDF document - The QR code and several other information are missing ### Cause: The snailmail module is setting specific paper format (base.paperformat_euro) when generating the PDF. https://github.com/odoo/odoo/blob/ce92dedea0fd3cdc73da6366c20b8052bb04f7e9/addons/snailmail/models/ir_actions_report.py#L17-L24 But the Swiss reports have their own formats to display the QR code correctly. So the generated PDF have its QR code on another page that is lost when merging the PDF for the header and the one with the QR code. ### Solution: Force the paper format for the two "IrActionReports" responsible for the page with the Qr-code. opw-4399150 Forward-Port-Of: odoo/odoo#190881
When using MultiRecordSelector with domain, the domain will not automatically apply to SelectCreateDialog. See odoo/enterprise#68484 closes odoo/odoo#176850 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191125
Original PR description
When using MultiRecordSelector with domain, the domain will not automatically apply to SelectCreateDialog. See odoo/enterprise#68484 closes odoo/odoo#176850 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191125
We have a constraint enforcing the presence of a zip code on both the sender and the receiver of the invoice but we can't trace the origin of this constraint. It seems to not exists anymore in the doc or the schematrons. We therefore remove it as it cause unnecessary frictions when invoicing. task-no (feedback from our prod + tsb) Forward-Port-Of: odoo/odoo#191129
Original PR description
We have a constraint enforcing the presence of a zip code on both the sender and the receiver of the invoice but we can't trace the origin of this constraint. It seems to not exists anymore in the doc or the schematrons. We therefore remove it as it cause unnecessary frictions when invoicing. task-no (feedback from our prod + tsb) Forward-Port-Of: odoo/odoo#191129
Because of odoo/odoo@dd1dfbc1f2075c8f4b414fc6fe5287f6e0bf76c3 the test suite crashed when studio was not installed because the route has_group was called with no virtual endpoint. After this commit, this is fixed runbot-error-110790 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191299
Original PR description
Because of odoo/odoo@dd1dfbc1f2075c8f4b414fc6fe5287f6e0bf76c3 the test suite crashed when studio was not installed because the route has_group was called with no virtual endpoint. After this commit, this is fixed runbot-error-110790 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191299
The aim of this commit is updating the COA and the account groups for the new legislation in France. task-4040854 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#190908 Forward-Port-Of: odoo/odoo#190065
Original PR description
The aim of this commit is updating the COA and the account groups for the new legislation in France. task-4040854 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#190908 Forward-Port-Of: odoo/odoo#190065
Apply sudo to avoid an access error when importing records (e.g. partners). Example use case: - Uninstall `base_install_request` - A user without the Administrator > Settings permission - Go to Contacts and click on Import records - When uploading the file the access error occurs @Tecnativa TT51841 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188634
Original PR description
Apply sudo to avoid an access error when importing records (e.g. partners). Example use case: - Uninstall `base_install_request` - A user without the Administrator > Settings permission - Go to Contacts and click on Import records - When uploading the file the access error occurs @Tecnativa TT51841 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#188634
**Current behavior before PR:** The `probability` field, defined as a float, had values in demo data assigned as strings. This caused errors during domain evaluation. **Desired behavior after PR is merged:** This update ensures the `probability` field in demo data uses values compatible with its float type. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191098
Original PR description
**Current behavior before PR:** The `probability` field, defined as a float, had values in demo data assigned as strings. This caused errors during domain evaluation. **Desired behavior after PR is merged:** This update ensures the `probability` field in demo data uses values compatible with its float type. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191098