Odoo Changelog — 2024-12-20

Friday, December 20, 2024

4 changes · saas-17.4

Bug Fixes(4)

Resolved issues and error corrections

[FIX] hr: prevent error when computing avatar_128 for resource

PR #191170

Coresaas-17.4hr

This fix prevents an error when the system tries to load an avatar for a resource that is not linked to an employee. It improves reliability in HR workflows by safely leaving the avatar empty instead of causing a crash.

Original PR description

Currently, a traceback is occurring when the `_compute_avatar_128` 
method triggers with resource having no employee.

Error:- 
```
IndexError: tuple index out of range
```

Here in resource employee_id is not a required field. 
So when the resource doesn't have any employee_id, it leads to the above traceback.

In the if condition we already checked the presence of employee, but the issue is 
occurring from the else condition.
https://github.com/odoo/odoo/blob/fb4d758ed78211a61ea797759e1fb3b02b51be60/addons/hr/models/resource.py#L30-L34

We can resolve this issue by making the avatar_128 field value False, if there is no employee_id.

sentry-6134007941

#avatar#resource#employee#stability

[DRAFT][FIX] hr_timesheet: resolve error when portal user click time spent on sub-tasks

PR #75395

Enterprisesaas-17.4timesheet_grid

Portal users no longer encounter an error when opening the time spent on sub-tasks from a mobile device. The change avoids showing a view that is not available in the portal experience, keeping shared project access usable without adding unnecessary complexity.

Original PR description

- saas-17.4 ### Steps to reproduce: - Install the hr_timesheet module. - Create a portal user. - Create a project, task, and sub-task (with timesheet entries). - Share the project with the portal…

- saas-17.4

### Steps to reproduce:
- Install the hr_timesheet module.
- Create a portal user.
- Create a project, task, and sub-task (with timesheet entries).
- Share the project with the portal user.
- Log in as the portal user (mobile device).
- Open the shared project and navigate to the task.
- Click on the Time Spent on Sub-tasks action.

### Issue:
Traceback error

### Cause:
On mobile, it attempts to load the grid view.
Technically:
The grid view exists in session.view_info, but the grid view's file is not available in project.webclient, which is used to display view to portal users.

### Solution:
To display the grid view to portal users, we can include the grid view files in project.webclient. However, this would also require adding dependencies for JS classes, widgets, and providing access permissions for certain modules like resource calendar, timer, and public employee, making it a more costly solution.

To maintain similar behavior, we can opt to remove the grid view from the action specifically for portal users.

task-4369891

[FIX] pos_blackbox_be: unnecessary blackbox call

PR #75981

Enterprisesaas-17.4pos_blackbox_be

Belgian Point of Sale syncing now avoids contacting the blackbox device when an order has no line changes. This reduces needless processing during synchronization while preserving the required checks when order contents actually change.

Original PR description

We remove unnecessary blackbox call in preSyncAllOrders method. Before we were calling the blackbox every time we were syncing orders with the server, even if it was not useful when there was no line change. Now we only call the blackbox when there is at least a line change.

#point-of-sale#belgium#sync#performance

[FIX] l10n_co_dian,l10n_co_edi: add missing translations

PR #75913

Enterprisesaas-17.4

Original PR description

**Issue:**
Some terms don't appear in Spanish in DIAN invoice PDF files.
![image](https://github.com/user-attachments/assets/3a76f66c-9a53-473c-a5cd-68ef1e4c3980)

**Expected:**
These terms should be translated in Spanish.

**Steps to reproduce:**
- Activate Accounting app in a Colombian database;
- Configure the DIAN credentials, client, journal and product (https://www.odoo.com/documentation/18.0/applications/finance/fiscal_localizations/colombia.html?highlight=dian);
- Create a customer invoice;
- Send and print with (only) DIAN checkbox checked;
- Open the PDF for the invoice.

**Cause:**
No translations (or erroneous ones) have been found for these keys.

**Fix:**
Add Spanish translations for these terms.
<img width="642" alt="Capture d’écran 2024-12-09 à 11 52 44" src="https://github.com/user-attachments/assets/77f548f4-f87e-4823-9fdc-5b54d0db2a1f">
Backport of Odoo 18 fix: https://github.com/odoo/enterprise/commit/99f332e3211cf17eb7bf0a970544dd0e0e07a9f8

**Testing:**
Testing needs actual credentials and complete configuration (including setting the client's language to LATAM Spanish)
![Capture d’écran 2024-12-09 à 11 34 54](https://github.com/user-attachments/assets/3bbea0c4-2696-4fb9-88d0-38be9a8cae06)


opw-4343184

Currently, a traceback is occurring when the `_compute_avatar_128` method triggers with resource having no employee. Error:- ``` IndexError: tuple index out of range ``` Here in resource employee_id is not a required field. So when the resource doesn't have any employee_id, it leads to the above traceback. In the if condition we already checked the presence of employee, but the issue is occurring from the else condition. https://github.com/odoo/odoo/blob/fb4d758ed78211a61ea797759e1fb3b02b51be60/addons/hr/models/resource.py#L30-L34 We can resolve this issue by making the avatar_128 field value False, if there is no employee_id. sentry-6134007941

- saas-17.4 ### Steps to reproduce: - Install the hr_timesheet module. - Create a portal user. - Create a project, task, and sub-task (with timesheet entries). - Share the project with the portal user. - Log in as the portal user (mobile device). - Open the shared project and navigate to the task. - Click on the Time Spent on Sub-tasks action. ### Issue: Traceback error ### Cause: On mobile, it attempts to load the grid view. Technically: The grid view exists in session.view_info, but the grid view's file is not available in project.webclient, which is used to display view to portal users. ### Solution: To display the grid view to portal users, we can include the grid view files in project.webclient. However, this would also require adding dependencies for JS classes, widgets, and providing access permissions for certain modules like resource calendar, timer, and public employee, making it a more costly solution. To maintain similar behavior, we can opt to remove the grid view from the action specifically for portal users. task-4369891

We remove unnecessary blackbox call in preSyncAllOrders method. Before we were calling the blackbox every time we were syncing orders with the server, even if it was not useful when there was no line change. Now we only call the blackbox when there is at least a line change.

**Issue:** Some terms don't appear in Spanish in DIAN invoice PDF files. ![image](https://github.com/user-attachments/assets/3a76f66c-9a53-473c-a5cd-68ef1e4c3980) **Expected:** These terms should be translated in Spanish. **Steps to reproduce:** - Activate Accounting app in a Colombian database; - Configure the DIAN credentials, client, journal and product (https://www.odoo.com/documentation/18.0/applications/finance/fiscal_localizations/colombia.html?highlight=dian); - Create a customer invoice; - Send and print with (only) DIAN checkbox checked; - Open the PDF for the invoice. **Cause:** No translations (or erroneous ones) have been found for these keys. **Fix:** Add Spanish translations for these terms. <img width="642" alt="Capture d’écran 2024-12-09 à 11 52 44" src="https://github.com/user-attachments/assets/77f548f4-f87e-4823-9fdc-5b54d0db2a1f"> Backport of Odoo 18 fix: https://github.com/odoo/enterprise/commit/99f332e3211cf17eb7bf0a970544dd0e0e07a9f8 **Testing:** Testing needs actual credentials and complete configuration (including setting the client's language to LATAM Spanish) ![Capture d’écran 2024-12-09 à 11 34 54](https://github.com/user-attachments/assets/3bbea0c4-2696-4fb9-88d0-38be9a8cae06) opw-4343184