Monday, December 23, 2024
3 changes · saas-17.4
Resolved issues and error corrections
Fixed an issue where the point of sale customer display could send an incomplete request to the IoT Box. This helps ensure customer-facing display information is retrieved reliably during checkout and closing flows.
Original PR description
Customer display "get" action was missing `params` key, required for the IoT Box to understand the request correctly.
This fixes an issue where Point of Sale logins for another company could show an invalid "NaN" value in the login number. Businesses using multiple companies now get proper, readable login references, reducing confusion during POS access and tracking.
Original PR description
Before this commit, in a multi-company setup, logging into the PoS for the second company would result in the login number being NaN, such as 00337-NaN-0004. opw-4425868 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures the Colombian electronic invoicing certification option can only be enabled when the test environment is also enabled. It prevents companies from saving an inconsistent configuration that could disrupt DIAN certification setup.
Original PR description
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to…
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to cause this: 1. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | False | False | | End | False | True | Here, the write call will trigger l10n_co_dian_certification_process is set from False to True without triggering the “if” condition since l10n_co_dian_test_environment is not set. 2. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | True | False | | End | False | True | Here, l10n_co_dian_test_environment is set from True to False from the first write call, which will trigger the “if” condition, causing it to also set l10n_co_dian_certification_process to False. However, then the l10n_co_dian_certification_process is set from False to True by the second original write call. **Purpose:** Make the l10n_co_dian_certification_process field a computed field such that l10n_co_dian_certification_process cannot be set to True if l10n_co_dian_test_environment is False. **Steps to Reproduce on Runbot:** 1. Install l10n_co_dian Case 1: 2. Start at the state, where both l10n_co_dian_test_environment and l10n_co_dian_certification_process are False 3. Check the box for l10n_co_dian_test_environment so that the box for l10n_co_dian_certification_process will also show up. Then check the box for l10n_co_dian_certification_process and uncheck the box for l10n_co_dian_test_environment. Finally save the new configuration. Case 2: 2. Start at the state, where l10n_co_dian_test_environment is True and l10n_co_dian_certification_process is False 3. Check the box for l10n_co_dian_certification_process then uncheck the box for l10n_co_dian_test_environment. Finally save the new configuration. opw-4225471