Tuesday, December 24, 2024
21 changes · 18.0
Resolved issues and error corrections
This update aligns the Point of Sale rescue session action with the current view naming used in Odoo. It is a minor maintenance fix that helps keep the interface configuration consistent and also adds the contributor legal agreement record.
Original PR description
… session action. Description of the issue/feature this PR addresses: 1. Usage of 'tree' in outstanding rescue session action. 2. Missing CLA for contributions. Current behavior before PR: 1. The outstanding rescue session action uses 'tree' . 2. CLA file is not included. Desired behavior after PR is merged: 1. 'list' replaces 'tree' in the outstanding rescue session action. 2. CLA file is added for future contributions. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Project updates now place manufacturing order costs in the manufacturing order section instead of grouping them under other costs. This makes project cost reporting clearer and helps users better understand where manufacturing-related expenses come from.
Original PR description
This commit's purpose is to remove the cost from the aal of manufacturing order from the 'other cost' section and put it inside the 'manufacturing order' section. This section currently contains only the MO linked to a work order. task - 4184226 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Point of Sale payments now use the intermediary account configured on the payment method instead of the default temporary account. This helps keep accounting entries aligned with the intended payment setup and reduces reconciliation errors.
Original PR description
Before this commit, in the payment move for a normal order, the Default Temporary Account was used while it should use the payment method Intermediary Account. opw-4404557 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Website number chart snippets now resize correctly with their surrounding page layout. This helps pages remain visually consistent when editors adjust column sizes or visitors view content on different screen sizes.
Original PR description
This commit aims to make the graph in `s_numbers_charts` resize simultaneously with it's col parent. It looks like the problem came from the fact that the `s_chart` div was composed of the chart alone. Adding some other type of content makes the chart resize properly. task-4207620 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures that certain formatted content is handled correctly when the Knowledge app is installed. It prevents display or editing issues caused by incorrectly processed self-closing elements in Knowledge articles.
Original PR description
**Problem**: Similar to the issue addressed in [this commit](https://github.com/odoo/odoo/pull/191311/commits/9b159179a8d0ad85300bf31d3e1d67d7f1324b14), the `knowledge` module patches `HtmlField` and parses its content. Without this fix, self-closing tags are improperly handled when the `knowledge` module is installed. **Solution**: Apply the same fix to convert self-closing tags into open and closed tags to ensure proper handling in the `knowledge` module. opw-4394833
A new automated check covers the full process of creating manufacturing orders linked to projects. This helps ensure project profitability reports place related manufacturing costs in the correct section, reducing the risk of misleading project financials.
Original PR description
This commit's purpose is to add a test for the full flow of the creation of a BOM/MO when they are linked to a project. This is to ensure that the aal generated are generated correctly and that the project profitability is then computing them into the correct section. community pr: https://github.com/odoo/odoo/pull/186607 task - 4184226 affetced version 18.0 - master
Creating a shortcut to a document the user cannot access now produces a clearer, intentional error instead of failing due to an indirect side effect. This improves user understanding and makes the access check more reliable in the Documents app.
Original PR description
Purpose ======= When creating a shortcut to a document we can't access, an error is raised, because of side effect. This commit make the verification explicit. Task-4409538
Miscellaneous changes
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191594
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191594
Before this commit, in a multi-company setup, logging into the PoS for the second company would result in the login number being NaN, such as 00337-NaN-0004. opw-4425868 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191507
Original PR description
Before this commit, in a multi-company setup, logging into the PoS for the second company would result in the login number being NaN, such as 00337-NaN-0004. opw-4425868 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191507
When adding a reward to an order on a table, if you leave the table and come back to it the reward would be gone Steps to reproduce: ------------------- * Setup a promotion program that give 10% discount * Open a PoS restaurant open a table and add some products * The 10% discount should be applied * Leave the table and come back to it > Observation: The reward is gone Why the fix: ------------ We make sure to update the rewards when selecting the table, because when opening the ta
Original PR description
When adding a reward to an order on a table, if you leave the table and come back to it the reward would be gone Steps to reproduce: ------------------- * Setup a promotion program that give 10% discount * Open a PoS restaurant open a table and add some products * The 10% discount should be applied * Leave the table and come back to it > Observation: The reward is gone Why the fix: ------------ We make sure to update the rewards when selecting the table, because when opening the table we use the one saved on the server. opw-4161408 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191197 Forward-Port-Of: odoo/odoo#183949
## Description Previously, the scale ticks in Odoo charts did not respect localization settings. This PR resolves the issue by leveraging the formatValue method within the scale tick callback function. Task: [4273769](https://www.odoo.com/odoo/project/2328/tasks/4273769) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191473 Forward-Port-Of: odoo/odoo#189562
Original PR description
## Description Previously, the scale ticks in Odoo charts did not respect localization settings. This PR resolves the issue by leveraging the formatValue method within the scale tick callback function. Task: [4273769](https://www.odoo.com/odoo/project/2328/tasks/4273769) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191473 Forward-Port-Of: odoo/odoo#189562
The Viva Wallet integration relies on Odoo being called by Viva Wallet via a webhook. There have been many issues of this webhook never being called, and therefore payments getting stuck in Odoo. In this commit, we add a polling fallback. Every 5 seconds we query the Viva Wallet session, and if we get a response (success/failure) then we update the payment state in the PoS. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odo
Original PR description
The Viva Wallet integration relies on Odoo being called by Viva Wallet via a webhook. There have been many issues of this webhook never being called, and therefore payments getting stuck in Odoo. In this commit, we add a polling fallback. Every 5 seconds we query the Viva Wallet session, and if we get a response (success/failure) then we update the payment state in the PoS. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191241 Forward-Port-Of: odoo/odoo#190213
Steps to reproduce the bug: - Enable “Subcontracting” and “Expiration Date” in MRP settings. - Create a storable product “P1” with the following configurations: - tracked by: LOT - Expiration date: True - BoM: - BoM type: subcontracting - subcontractor: Azure interior - Create a lot “L1” with an expiration date set to 01-01-2026. - Expiration date: 01-01-2026 - Configure the operation type:: - Receipt: - use existing SN: True - Crea
Original PR description
Steps to reproduce the bug: - Enable “Subcontracting” and “Expiration Date” in MRP settings. - Create a storable product “P1” with the following configurations: - tracked by: LOT - Expiration date:…
Steps to reproduce the bug:
- Enable “Subcontracting” and “Expiration Date” in MRP settings.
- Create a storable product “P1” with the following configurations:
- tracked by: LOT
- Expiration date: True
- BoM:
- BoM type: subcontracting
- subcontractor: Azure interior
- Create a lot “L1” with an expiration date set to 01-01-2026.
- Expiration date: 01-01-2026
- Configure the operation type::
- Receipt:
- use existing SN: True
- Create a receipt:
- Receive from: Azure interior
- Product: one unit of P1
- Mark it as todo
- Open the detailed operation:
- Set the “L1”
- Record production
- Reopen the detailed operation
Problem:
The expiration date in the stock.move.line is set to today’s date instead of the lot’s expiration date.
Cause:
When marking the receipt as “To Do,” the SML is created. Since no lot_id is initially set, today’s date is assigned, thanks to the _compute_expiration_date method:
https://github.com/odoo/odoo/blob/9f1d555ac2d9b6e9d3d0d723d4f042eb44cf30b7/addons/product_expiry/models/stock_move_line.py#L37-L40
But When the lot_id is later set, the compute method is triggered again. However, since the SML already contains a date, the expiration date is not updated to match the lot’s expiration date.
opw-4394662
Forward-Port-Of: odoo/odoo#190747**Issue:** When printing a Purchase Order or Quotation in a company using the Indonesian tax chart, a tax code (Indonesian tax description) appears instead of the tax percentage. **Steps to Reproduce:** 1- Ensure the company uses the Indonesian chart of accounts. - Install the l10n_id module. - Go to Settings > Taxes and set the Fiscal Country to Indonesia. 2- Navigate to Purchase and create a Purchase Order. 3- Add a product line and select an Indonesian tax (ex: 11%). 4- Print the
Original PR description
**Issue:** When printing a Purchase Order or Quotation in a company using the Indonesian tax chart, a tax code (Indonesian tax description) appears instead of the tax percentage. **Steps to…
**Issue:** When printing a Purchase Order or Quotation in a company using the Indonesian tax chart, a tax code (Indonesian tax description) appears instead of the tax percentage. **Steps to Reproduce:** 1- Ensure the company uses the Indonesian chart of accounts. - Install the l10n_id module. - Go to Settings > Taxes and set the Fiscal Country to Indonesia. 2- Navigate to Purchase and create a Purchase Order. 3- Add a product line and select an Indonesian tax (ex: 11%). 4- Print the Purchase Order. The printed Purchase Order displays the tax code (description) instead of the tax percentage. The same behavior occurs in the Sales module regarding quotation printing (see screenshots attached) <img src ="https://github.com/user-attachments/assets/08dd6940-e07e-4e44-9f03-85f8ae2e8914" width=300 /> <img src ="https://github.com/user-attachments/assets/a8d16f6c-c6a0-441f-8c3f-3546387fb4e6" width=300 /> opw-4333143 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191367 Forward-Port-Of: odoo/odoo#187703
Also display lot/serial numbers products that are located in sub-locations. opw: 4415220 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191054
Original PR description
Also display lot/serial numbers products that are located in sub-locations. opw: 4415220 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#191054
**Current behavior before PR:** - In web studio, when text is selected and the page is scrolled, the toolbar does not stay aligned with the selected text. **Desired behavior after PR is merged:** - Now, when scrolling in web studio, the toolbar remains fixed to the initial selection. task-4317313 Forward-Port-Of: odoo/odoo#186925
Original PR description
**Current behavior before PR:** - In web studio, when text is selected and the page is scrolled, the toolbar does not stay aligned with the selected text. **Desired behavior after PR is merged:** - Now, when scrolling in web studio, the toolbar remains fixed to the initial selection. task-4317313 Forward-Port-Of: odoo/odoo#186925
Steps to reproduce: --- - Install ``planning`` module - Give the demo user as ``administrator`` in planning. - Log in as Demo user > Go to planning - Click on ``New`` > click on the ``Resource`` field Traceback: --- ``IndexError: tuple index out of range`` The error occurs at [1] because we couldn't find an employee in ``avatar_per_employee_id``. This happens when a new resource is created in the first tab, but the ``employee_id`` is not found in the ``resource`` in the second tab
Original PR description
Steps to reproduce: --- - Install ``planning`` module - Give the demo user as ``administrator`` in planning. - Log in as Demo user > Go to planning - Click on ``New`` > click on the ``Resource`` field Traceback: --- ``IndexError: tuple index out of range`` The error occurs at [1] because we couldn't find an employee in ``avatar_per_employee_id``. This happens when a new resource is created in the first tab, but the ``employee_id`` is not found in the ``resource`` in the second tab. This commit resolves the above error by returning false if an employee is not present. [1]- https://github.com/odoo/odoo/blob/fb4d758ed78211a61ea797759e1fb3b02b51be60/addons/hr/models/resource.py#L34 sentry-5508268100, 6134007941 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173598
Since the latest changes on https://github.com/odoo/enterprise/commit/6d49119281901e51910bb71e34300e414216123b, we use the gantt view as in appointments so when trying use the "More Options" from here, we will try to load the calendar form for which we will need to add the assets to not throw an error. Steps to reproduce: 1. Get a restaurant session in pos. 2. On the top right burguer menu, select Manage Bookings. 3. Then create a new one o select an existing one to open the dialog.
Original PR description
Since the latest changes on https://github.com/odoo/enterprise/commit/6d49119281901e51910bb71e34300e414216123b, we use the gantt view as in appointments so when trying use the "More Options" from here, we will try to load the calendar form for which we will need to add the assets to not throw an error. Steps to reproduce: 1. Get a restaurant session in pos. 2. On the top right burguer menu, select Manage Bookings. 3. Then create a new one o select an existing one to open the dialog. 4. Click on "More Options". opw-4334444 Forward-Port-Of: odoo/enterprise#74030
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to cause this: 1. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | False | False | | End | False | True | Here, the write call will trigger l10n_co_dian_certification_process is set from False to True without triggering the “
Original PR description
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to…
**Problem:** l10n_co_dian_certification_process (Activate the certification process) can still be checked if l10n_co_dian_test_environment (Test environment) is left unchecked. There are two ways to cause this: 1. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | False | False | | End | False | True | Here, the write call will trigger l10n_co_dian_certification_process is set from False to True without triggering the “if” condition since l10n_co_dian_test_environment is not set. 2. | | l10n_co_dian_test_environment | l10n_co_dian_certification_process | |--------|--------|--------| | Start | True | False | | End | False | True | Here, l10n_co_dian_test_environment is set from True to False from the first write call, which will trigger the “if” condition, causing it to also set l10n_co_dian_certification_process to False. However, then the l10n_co_dian_certification_process is set from False to True by the second original write call. **Purpose:** Make the l10n_co_dian_certification_process field a computed field such that l10n_co_dian_certification_process cannot be set to True if l10n_co_dian_test_environment is False. **Steps to Reproduce on Runbot:** 1. Install l10n_co_dian Case 1: 2. Start at the state, where both l10n_co_dian_test_environment and l10n_co_dian_certification_process are False 3. Check the box for l10n_co_dian_test_environment so that the box for l10n_co_dian_certification_process will also show up. Then check the box for l10n_co_dian_certification_process and uncheck the box for l10n_co_dian_test_environment. Finally save the new configuration. Case 2: 2. Start at the state, where l10n_co_dian_test_environment is True and l10n_co_dian_certification_process is False 3. Check the box for l10n_co_dian_certification_process then uncheck the box for l10n_co_dian_test_environment. Finally save the new configuration. opw-4225471 Forward-Port-Of: odoo/enterprise#73532
Steps to reproduce ================== - Archive default "Projects" workspace - Create a new Project - Create a task and attach a file - Click on the smart button to view the document - Go back to the home menu and open the documents app => `Cannot read properties of undefined (reading 'id')` Solution ======== Prevent the archiving of the projects workspace opw-4308132 Forward-Port-Of: odoo/enterprise#75659
Original PR description
Steps to reproduce ================== - Archive default "Projects" workspace - Create a new Project - Create a task and attach a file - Click on the smart button to view the document - Go back to the home menu and open the documents app => `Cannot read properties of undefined (reading 'id')` Solution ======== Prevent the archiving of the projects workspace opw-4308132 Forward-Port-Of: odoo/enterprise#75659
To be more clear, we add the original amount from the statement we are to reconciliating on the open balance line. task-4194671 Forward-Port-Of: odoo/enterprise#75776 Forward-Port-Of: odoo/enterprise#70785
Original PR description
To be more clear, we add the original amount from the statement we are to reconciliating on the open balance line. task-4194671 Forward-Port-Of: odoo/enterprise#75776 Forward-Port-Of: odoo/enterprise#70785