Odoo Changelog — 2025-01-06

Monday, January 6, 2025

19 changes · saas-17.4

Bug Fixes(4)

Resolved issues and error corrections

[FIX] website_sale, delivery: add missing terms in `location_selector`

PR #192102

Coresaas-17.4deliverywebsite_sale

Some delivery pickup/location selection text on the website was not being translated for shoppers. The change makes those labels available in the website sales area so customers see them in their selected language.

Original PR description

There are some terms that are defined in `delivery` module but are not translated when you see them on the website. This happens because these strings are defined in the `delivery` module, which is not a frontend module. This commit redefines those strings in the `website_sale` module, which is a frontend module.

Task-4328208
OPW-4403072
OPW-4326840

#translations#website#delivery#checkout

[FIX] im_livechat: correct author name display for visitor messages in demo data

PR #192003

Coresaas-17.4im_livechat

Live chat demo conversations now correctly show visitor messages as coming from “Visitor” instead of “Odoobot.” This makes demo data clearer and avoids confusion when showcasing or testing the live chat experience.

Original PR description

**Current behavior before PR:**

Messages posted by visitors in demo data incorrectly displayed the author name
as `Odoobot` instead of `Visitor`. This happened because the messages created
for visitors in the demo data do not have the `author_id` field explicitly set to
`False`, leading the `_message_compute_author()` method to compute the author incorrectly.

**Desired behavior after PR is merged:**

Messages posted by visitors in demo data correctly display the author name as Visitor.


Task-[4420677](https://www.odoo.com/odoo/project/1519/tasks/4420677)



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#livechat#demo data#visitor messages

[FIX] point_of_sale: add default filter pos order

PR #192377

Coresaas-17.4point_of_sale

The Point of Sale order report now excludes cancelled orders by default. This helps business users see more accurate sales reporting without cancelled transactions inflating or confusing the results.

Original PR description

Cancelled order should be ignored by default in the POS order report.

Steps to reproduce:
-------------------
* Open PoS create an order and go back to the backedn
* Open the PoS again and close the PoS, it will cancel the order
> Observation: Open PoS order report, it will include the cancelled
order, that can be missleading.

Why the fix:
------------
We add a new default filter that apply a domain to exclude the cancelled order from the report.

opw-4257734

#pos#orders#reporting

[FIX] sale_subscription: prevent AccessError in kanban

PR #75677

Enterprisesaas-17.4sale_subscription

Non-Sales users can now open product Kanban views without hitting an access error related to subscription pricing. The view now only shows subscription pricing details to users with Sales permissions, avoiding disruption for Inventory and other users.

Original PR description

Steps to reproduce:
-------------------

	- Install sale_subscription and inventory.
	- Create a subscription product.
	- Log in as a non-Sales user (e.g., Inventory user).
	- Access the product list in Kanban view.(from stock)

Issue:
-------

Non-Sales users encounter an AccessError when the Kanban view attempts to read product_subscription_pricing_ids. This is due to:
 - "record.product_subscription_pricing_ids.raw_value.length" Attempted to be computed even if the user does not have the access rights.

Fix:
-----

Updated the Kanban view to conditionally render subscription pricing fields only for users in the Sales group.

opw-4404190

#subscriptions#access rights#kanban#products

Other(15)

Miscellaneous changes

[FW][FIX] product: always compute zoomable with `bin_size=False`

PR #192409

Coresaas-17.4product

Original PR description

Changing a product template's image with the `can_image_1024_be_zoomed` field present in the view produces a crash on save.

**STEPS TO REPRODUCE**
1. Open a product form view
2. Using studio, add the `can_image_1024_be_zoomed` field
3. Change the image and save

The product will be updated, but this error will be thrown:

```
binascii.Error: Incorrect padding
```

**CAUSE**
https://github.com/odoo/odoo/blob/a74684777c27e26639b75b0668bb15afadb78c4f/addons/product/models/product_template.py#L186-L188

In the `RecordSet`'s context, `bin_size=True`, so accessing `image_<size>` returns a size instead of a binary. `_compute_can_image_1024_be_zoomed` calls `tools.is_image_size_above` with this binary size, while the method expects the full base64 encoded image. Ultimately, this causes `base64.b64decode` to crash with the above error.

**FIX** Update the `RecordSet`'s context to `bin_size=False`. Accessing `image_<size>` from the `RecordSet` will then return the full binary instead of the size.

**NOTES**
In versions <17.0, read and write were done in separate network calls causing the recompute to happen during the flush of the write, which doesn't have `bin_size=True` in the context. Because the field is stored, the read will not cause a recompute and thus avoids any error. In >=17.0, because the read occurs before the flush, and the write has invalidated the field, the recompute will occur with the context of the read (`bin_size=True`), causing the issue.

opw-4413647

Forward-Port-Of: odoo/odoo#192047

There are some terms that are defined in `delivery` module but are not translated when you see them on the website. This happens because these strings are defined in the `delivery` module, which is not a frontend module. This commit redefines those strings in the `website_sale` module, which is a frontend module. Task-4328208 OPW-4403072 OPW-4326840

**Current behavior before PR:** Messages posted by visitors in demo data incorrectly displayed the author name as `Odoobot` instead of `Visitor`. This happened because the messages created for visitors in the demo data do not have the `author_id` field explicitly set to `False`, leading the `_message_compute_author()` method to compute the author incorrectly. **Desired behavior after PR is merged:** Messages posted by visitors in demo data correctly display the author name as Visitor. Task-[4420677](https://www.odoo.com/odoo/project/1519/tasks/4420677) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Cancelled order should be ignored by default in the POS order report. Steps to reproduce: ------------------- * Open PoS create an order and go back to the backedn * Open the PoS again and close the PoS, it will cancel the order > Observation: Open PoS order report, it will include the cancelled order, that can be missleading. Why the fix: ------------ We add a new default filter that apply a domain to exclude the cancelled order from the report. opw-4257734

Steps to reproduce: ------------------- - Install sale_subscription and inventory. - Create a subscription product. - Log in as a non-Sales user (e.g., Inventory user). - Access the product list in Kanban view.(from stock) Issue: ------- Non-Sales users encounter an AccessError when the Kanban view attempts to read product_subscription_pricing_ids. This is due to: - "record.product_subscription_pricing_ids.raw_value.length" Attempted to be computed even if the user does not have the access rights. Fix: ----- Updated the Kanban view to conditionally render subscription pricing fields only for users in the Sales group. opw-4404190

Changing a product template's image with the `can_image_1024_be_zoomed` field present in the view produces a crash on save. **STEPS TO REPRODUCE** 1. Open a product form view 2. Using studio, add the `can_image_1024_be_zoomed` field 3. Change the image and save The product will be updated, but this error will be thrown: ``` binascii.Error: Incorrect padding ``` **CAUSE** https://github.com/odoo/odoo/blob/a74684777c27e26639b75b0668bb15afadb78c4f/addons/product/models/product_template.py#L186-L188 In the `RecordSet`'s context, `bin_size=True`, so accessing `image_<size>` returns a size instead of a binary. `_compute_can_image_1024_be_zoomed` calls `tools.is_image_size_above` with this binary size, while the method expects the full base64 encoded image. Ultimately, this causes `base64.b64decode` to crash with the above error. **FIX** Update the `RecordSet`'s context to `bin_size=False`. Accessing `image_<size>` from the `RecordSet` will then return the full binary instead of the size. **NOTES** In versions <17.0, read and write were done in separate network calls causing the recompute to happen during the flush of the write, which doesn't have `bin_size=True` in the context. Because the field is stored, the read will not cause a recompute and thus avoids any error. In >=17.0, because the read occurs before the flush, and the write has invalidated the field, the recompute will occur with the context of the read (`bin_size=True`), causing the issue. opw-4413647 Forward-Port-Of: odoo/odoo#192047

Scenario: - install l10n_ch - go to /report/barcode/?barcode_type=QR&value=&width=150&height=150&mask=ch_cross => the ch_cross mask (swiss cross that should be in the center) is not in the center Issue: Reportlab QrCodeWidget has a fixed size to 32mm (with mm that is 72(ppi) / 25.4(1mm to inch) so ~2.83 pixels) and to get the widget to the full size, a zoom is applied on the Drawing content (so on the QrCodeWidget). Here are the zoom that are applied for several Drawing size: - for 100 pixels: 100 / (32 * mm) => 1.012… - for 256 pixels: 256 / (32 * mm) => 2.822… - for 400 pixels: 400 / (32 * mm) => 4.409… But in the code, the zoom is just hardcoded to mm (~2.83) which corresponds to a barcode size of mm * 32 * mm => 257.127 pixels which is kind of good enough for 256 pixels, but wrong for most other size. In base code we only use 256 x 256 pixels so this is not much of an issue unless someone want to use it for something else. Fix: With this commit, we apply the Drawing zoom (on which we have the QrCodeWidget) to the ch_cross image. Note: Without the fix, the added test only fail on the third assertion for each loop iteration, the farer we are from 257x257 pixels the bigger the error is, for example for 256x256: Result: (38.45140, 38.45140, 52.25725984251969, 52.25725984251969) Expected: (38.28288, 38.28288, 52.02823111111111, 52.02823111111111) opw-4307177 PR NOTE: this could be merged in an higher version, and we could also just not fix this since as far as I can tell, we only need to support 256x256 and with and without the fix there is just one pixel of difference in this case. ![a](https://github.com/user-attachments/assets/f38e26ee-a129-4fd1-ae92-a9768274dbbb) Forward-Port-Of: odoo/odoo#192091

Bug Fixes(4)

[FIX] website_sale, delivery: add missing terms in `location_selector`

[FIX] im_livechat: correct author name display for visitor messages in demo data

[FIX] point_of_sale: add default filter pos order

[FIX] sale_subscription: prevent AccessError in kanban

Other(15)

[FW][FIX] product: always compute zoomable with `bin_size=False`

Bug Fixes(4)

[FIX] website_sale, delivery: add missing terms in `location_selector`

[FIX] im_livechat: correct author name display for visitor messages in demo data

[FIX] point_of_sale: add default filter pos order

[FIX] sale_subscription: prevent AccessError in kanban

Other(15)

[FW][FIX] product: always compute zoomable with `bin_size=False`

[FW][FIX] portal, point_of_sale: return new instance of fields list

[FW][FIX] hr_holidays: resource leave should exist if not fully covered by public holiday

[FW][FIX] website_payment: fix s_donation slider for RTL languages

[FW][FIX] web: fix active class on extra menu items

[FW][FIX] product: fix traceback when deleting the archived product variants

[FW][FIX] point_of_sale: allow search partners by VAT

[FW][FIX] spreadsheet_edition: allow base user to restore a spreadsheet

[FW][FIX] l10n_be_hr_payroll: Update withholding tax rate up to Jan 2025

[FW][FIX] web_studio: reportEditor: do not remove spans

[FW][FIX] account_report: options on composite report export

[FW][FIX] l10n_mx_reports: missing labels

[FW][FIX] account_report: options on composite report creation

[FW][FIX] hr_timesheet: adjust colspan when timesheets are groupby

[FW][FIX] l10n_ch: non 256 size barcode has cross centered